discourse/spec/models/s3_region_site_setting_spec.rb

# frozen_string_literal: true

require 'rails_helper'

describe S3RegionSiteSetting do

  describe 'valid_value?' do
    it 'returns true for a valid S3 region' do
      expect(S3RegionSiteSetting.valid_value?('us-west-1')).to eq(true)
    end

    it 'returns false for an invalid S3 region' do
      expect(S3RegionSiteSetting.valid_value?('the-moon')).to eq(false)
    end
  end

end
DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction 2019-04-30 08:27:42 +08:00			`# frozen_string_literal: true`

Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails. 2015-10-11 17:41:23 +08:00			`require 'rails_helper'`
Make s3 region site setting a drop down 2013-06-12 02:23:52 +08:00
			`describe S3RegionSiteSetting do`

			`describe 'valid_value?' do`
			`it 'returns true for a valid S3 region' do`
			`expect(S3RegionSiteSetting.valid_value?('us-west-1')).to eq(true)`
			`end`

			`it 'returns false for an invalid S3 region' do`
			`expect(S3RegionSiteSetting.valid_value?('the-moon')).to eq(false)`
			`end`
			`end`

values is a much more consistent name than all_values ... we use {}.values not {}.all_values also fixes random ordering of tests failure in site settings 2013-06-23 13:07:25 +08:00			`end`