discourse/app/assets/javascripts/admin/addon/components/admin-editable-field.js

import Component from "@ember/component";
export default Component.extend({
  tagName: "",

  buffer: "",
  editing: false,

  init() {
    this._super(...arguments);
    this.set("editing", false);
  },

  actions: {
    edit() {
      this.set("buffer", this.value);
      this.toggleProperty("editing");
    },

    save() {
      // Action has to toggle 'editing' property.
      this.action(this.buffer);
    },
  },
});
REFACTOR: Remove `Ember.Component` global variable Use imports instead. 2019-10-24 00:30:52 +08:00			`import Component from "@ember/component";`
			`export default Component.extend({`
FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 22:28:29 +08:00			`tagName: "",`

			`buffer: "",`
			`editing: false,`

			`init() {`
			`this._super(...arguments);`
			`this.set("editing", false);`
			`},`

DEV: Remove usage of `{{action}}` modifiers (#18333) This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression 2022-10-04 16:42:46 +08:00			`actions: {`
Revert "DEV: Remove usage of `{{action}}` modifiers (#18333)" (#18469) This reverts commit ba27ee16376c961c93a4e3854b038a42f9577613. We found some issues with handling of cmd/ctrl/shift + click on `<a` elements 2022-10-04 19:27:26 +08:00			`edit() {`
			`this.set("buffer", this.value);`
			`this.toggleProperty("editing");`
			`},`

FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 22:28:29 +08:00			`save() {`
			`// Action has to toggle 'editing' property.`
DEV: global s/this.get\("(\w+)"\)/this.$1 (#7592) 2019-05-27 16:15:39 +08:00			`this.action(this.buffer);`
FIX: Properly reset controller of admin-user-index. (#6760) 2018-12-17 22:28:29 +08:00			`},`
			`},`
			`});`