2019-05-03 06:17:27 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
class TopicCreator
|
2015-08-11 13:46:21 +08:00
|
|
|
attr_reader :user, :guardian, :opts
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
include HasErrors
|
2013-06-05 02:13:01 +08:00
|
|
|
|
2013-07-22 09:40:39 +08:00
|
|
|
def self.create(user, guardian, opts)
|
|
|
|
self.new(user, guardian, opts).create
|
|
|
|
end
|
|
|
|
|
2013-06-05 02:13:01 +08:00
|
|
|
def initialize(user, guardian, opts)
|
|
|
|
@user = user
|
|
|
|
@guardian = guardian
|
|
|
|
@opts = opts
|
2014-09-08 23:11:56 +08:00
|
|
|
@added_users = []
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def valid?
|
|
|
|
topic = Topic.new(setup_topic_params)
|
2015-08-11 13:46:21 +08:00
|
|
|
# validate? will clear the error hash
|
|
|
|
# so we fire the validation event after
|
|
|
|
# this allows us to add errors
|
|
|
|
valid = topic.valid?
|
2016-04-26 03:55:15 +08:00
|
|
|
|
2022-12-01 18:26:35 +08:00
|
|
|
validate_visibility(topic)
|
|
|
|
|
2021-04-19 07:43:50 +08:00
|
|
|
category = find_category
|
|
|
|
if category.present? && guardian.can_tag?(topic)
|
2021-10-28 14:29:46 +08:00
|
|
|
tags = @opts[:tags].presence || []
|
FIX: Miscellaneous tagging errors (#21490)
* FIX: Displaying the wrong number of minimum tags in the composer
When the minimum number of tags set for the category is larger than the minimum number of tags
set in the category tag-groups, the composer was displaying the wrong value.
This commit fixes the value displayed in the composer to show the max value between the required
for the category and the tag-groups set for the category.
This bug was reported on Meta in https://meta.discourse.org/t/tags-from-multiple-tag-groups-required-only-suggest-select-at-least-one-tag/263817
* FIX: Limiting tags in categories not working as expected
When a category was restricted to a tag group A, which was set to only allow
one tag from the group per topic, selecting a tag belonging only to A returned
other tags from A that also belonged to other group/s (if any).
Example:
Tag group A: alpha, beta, gamma, epsilon, delta
Tag group B: alpha, beta, gamma
Both tag groups set to only allow one tag from the group per topic.
If Category 1 was set to only allow tags from the tag group A, and the first tag
selected was epsilon, then, because they also belonged to tag group B, the tags
alpha, beta, and gamma were still returned as valid options when they should not be.
This commit ensures that once a tag from a tag group that restricts its tags to
one per topic is selected, no other tag from this group is returned.
This bug was reported on Meta in https://meta.discourse.org/t/limiting-tags-to-categories-not-working-as-expected/263143.
* FIX: Moving topics does not prompt to add required tag for new category
When a topic moved from a category to another, the tag requirements
of the new category were not being checked.
This allowed a topic to be created and moved to a category:
- that limited the tags to a tag group, with the topic containing tags
not allowed.
- that required N tags from a tag group, with the topic not containing
the required tags.
This bug was reported on Meta in https://meta.discourse.org/t/moving-tagged-topics-does-not-prompt-to-add-required-tag-for-new-category/264138.
* FIX: Editing topics with tag groups from parents allows incorrect tagging
When there was a combination between parent tags defined in a tag group
set to allow only one tag from the group per topic, and other tag groups
relying on this restriction to combine the children tag types with the
parent tag, editing a topic could allow the user to insert an invalid
combination of these tags.
Example:
Automakers tag group: landhover, toyota
- group set to limit one tag from the group per topic
Toyota models group: land-cruiser, hilux, corolla
Landhover models group: evoque, defender, discovery
If a topic was initially set up with the tags toyota, land-cruiser it was
possible to edit it by removing the tag toyota and adding the tag landhover
and other landhover model tags like evoque for example.
In this case, the topic would end up with the tags toyota, land-cruiser,
landhover, evoque because Discourse will automatically insert the
missing parent tag toyota when it detects the tag land-cruiser.
This combination of tags would violate the restriction specified in
the Automakers tag group resulting in an invalid combination of tags.
This commit enforces that the "one tag from the group per topic"
restriction is verified before updating the topic tags and also
make sure the verification checks the compatibility of parent tags that
would be automatically inserted.
After the changes, the user will receive an error similar to:
The tags land-cruiser, landhover cannot be used simultaneously.
Please include only one of them.
2023-05-16 04:19:41 +08:00
|
|
|
|
|
|
|
# adds topic.errors
|
|
|
|
DiscourseTagging.validate_category_tags(guardian, topic, category, tags)
|
2021-04-19 07:43:50 +08:00
|
|
|
end
|
|
|
|
|
2015-08-11 13:46:21 +08:00
|
|
|
DiscourseEvent.trigger(:after_validate_topic, topic, self)
|
|
|
|
valid &&= topic.errors.empty?
|
|
|
|
|
|
|
|
add_errors_from(topic) unless valid
|
|
|
|
|
|
|
|
valid
|
2015-03-27 04:57:50 +08:00
|
|
|
end
|
|
|
|
|
2013-06-05 02:13:01 +08:00
|
|
|
def create
|
2015-03-27 04:57:50 +08:00
|
|
|
topic = Topic.new(setup_topic_params)
|
2022-12-01 18:26:35 +08:00
|
|
|
|
|
|
|
validate_visibility!(topic)
|
2016-05-05 02:02:47 +08:00
|
|
|
setup_tags(topic)
|
2020-02-05 17:32:03 +08:00
|
|
|
|
2019-05-25 21:53:03 +08:00
|
|
|
if fields = @opts[:custom_fields]
|
2023-10-10 11:23:56 +08:00
|
|
|
topic.custom_fields = fields
|
2019-05-25 21:53:03 +08:00
|
|
|
end
|
2016-05-05 02:02:47 +08:00
|
|
|
|
2015-08-11 13:46:21 +08:00
|
|
|
DiscourseEvent.trigger(:before_create_topic, topic, self)
|
2013-06-05 02:13:01 +08:00
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
setup_auto_close_time(topic)
|
|
|
|
process_private_message(topic)
|
|
|
|
save_topic(topic)
|
|
|
|
create_warning(topic)
|
|
|
|
watch_topic(topic)
|
2018-03-14 03:59:12 +08:00
|
|
|
create_shared_draft(topic)
|
2019-01-04 01:03:01 +08:00
|
|
|
UserActionManager.topic_created(topic)
|
2013-07-22 09:40:39 +08:00
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
topic
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
2022-12-01 18:26:35 +08:00
|
|
|
def validate_visibility(topic)
|
|
|
|
if !@opts[:skip_validations] && !topic.visible && !guardian.can_create_unlisted_topic?(topic)
|
|
|
|
topic.errors.add(:base, :unable_to_unlist)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def validate_visibility!(topic)
|
|
|
|
validate_visibility(topic)
|
|
|
|
|
|
|
|
rollback_from_errors!(topic) if topic.errors.full_messages.present?
|
|
|
|
end
|
|
|
|
|
2018-03-14 03:59:12 +08:00
|
|
|
def create_shared_draft(topic)
|
2020-12-15 03:08:20 +08:00
|
|
|
return if @opts[:shared_draft].blank? || @opts[:shared_draft] == "false"
|
|
|
|
|
|
|
|
category_id =
|
|
|
|
@opts[:category].blank? ? SiteSetting.shared_drafts_category.to_i : @opts[:category]
|
|
|
|
SharedDraft.create(topic_id: topic.id, category_id: category_id)
|
2018-03-14 03:59:12 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def create_warning(topic)
|
2014-09-08 23:11:56 +08:00
|
|
|
return unless @opts[:is_warning]
|
|
|
|
|
|
|
|
# We can only attach warnings to PMs
|
2015-03-27 04:57:50 +08:00
|
|
|
rollback_with!(topic, :warning_requires_pm) unless topic.private_message?
|
2014-09-08 23:11:56 +08:00
|
|
|
|
|
|
|
# Don't create it if there is more than one user
|
2015-03-27 04:57:50 +08:00
|
|
|
rollback_with!(topic, :too_many_users) if @added_users.size != 1
|
2014-09-08 23:11:56 +08:00
|
|
|
|
|
|
|
# Create a warning record
|
2017-04-15 12:11:02 +08:00
|
|
|
UserWarning.create(topic: topic, user: @added_users.first, created_by: @user)
|
2014-09-08 23:11:56 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def watch_topic(topic)
|
|
|
|
topic.notifier.watch_topic!(topic.user_id) unless @opts[:auto_track] == false
|
2014-01-22 14:46:52 +08:00
|
|
|
|
2017-08-31 12:06:56 +08:00
|
|
|
topic.reload.topic_allowed_users.each do |tau|
|
2015-12-15 06:17:09 +08:00
|
|
|
next if tau.user_id == -1 || tau.user_id == topic.user_id
|
|
|
|
topic.notifier.watch!(tau.user_id)
|
|
|
|
end
|
2014-06-25 00:31:36 +08:00
|
|
|
|
2019-08-16 16:23:51 +08:00
|
|
|
topic.reload.topic_allowed_groups.each do |topic_allowed_group|
|
|
|
|
topic_allowed_group.group.set_message_default_notification_levels!(topic)
|
2014-01-22 14:46:52 +08:00
|
|
|
end
|
2013-07-22 09:40:39 +08:00
|
|
|
end
|
|
|
|
|
2014-02-07 03:52:50 +08:00
|
|
|
def setup_topic_params
|
2016-07-27 17:50:13 +08:00
|
|
|
@opts[:visible] = true if @opts[:visible].nil?
|
|
|
|
|
2014-01-24 19:57:48 +08:00
|
|
|
topic_params = {
|
|
|
|
title: @opts[:title],
|
|
|
|
user_id: @user.id,
|
2016-07-27 17:50:13 +08:00
|
|
|
last_post_user_id: @user.id,
|
|
|
|
visible: @opts[:visible],
|
2014-01-24 19:57:48 +08:00
|
|
|
}
|
|
|
|
|
2023-10-10 11:23:56 +08:00
|
|
|
%i[subtype archetype import_mode advance_draft].each do |key|
|
2014-02-07 03:52:50 +08:00
|
|
|
topic_params[key] = @opts[key] if @opts[key].present?
|
2014-01-24 19:57:48 +08:00
|
|
|
end
|
|
|
|
|
2015-07-16 14:11:20 +08:00
|
|
|
if topic_params[:import_mode] && @opts[:views].to_i > 0
|
|
|
|
topic_params[:views] = @opts[:views].to_i
|
|
|
|
end
|
|
|
|
|
2020-09-10 06:16:57 +08:00
|
|
|
if topic_params[:import_mode] && @opts[:participant_count].to_i > 0
|
|
|
|
topic_params[:participant_count] = @opts[:participant_count].to_i
|
|
|
|
end
|
|
|
|
|
2014-09-09 01:23:40 +08:00
|
|
|
# Automatically give it a moderator warning subtype if specified
|
|
|
|
topic_params[:subtype] = TopicSubtype.moderator_warning if @opts[:is_warning]
|
|
|
|
|
2014-02-07 03:52:50 +08:00
|
|
|
category = find_category
|
2015-10-17 15:48:56 +08:00
|
|
|
unless (@opts[:skip_validations] || @opts[:archetype] == Archetype.private_message)
|
|
|
|
@guardian.ensure_can_create!(Topic, category)
|
2019-05-10 07:33:02 +08:00
|
|
|
end
|
2019-05-10 01:22:09 +08:00
|
|
|
|
2019-05-10 07:33:02 +08:00
|
|
|
raise Discourse::InvalidParameters.new(:category) if @opts[:category].present? && category.nil?
|
2023-01-09 20:10:19 +08:00
|
|
|
|
2013-06-05 02:13:01 +08:00
|
|
|
topic_params[:category_id] = category.id if category.present?
|
2020-03-10 22:35:40 +08:00
|
|
|
topic_params[:created_at] = convert_time(@opts[:created_at]) if @opts[:created_at].present?
|
|
|
|
topic_params[:pinned_at] = convert_time(@opts[:pinned_at]) if @opts[:pinned_at].present?
|
2015-03-14 04:24:11 +08:00
|
|
|
topic_params[:pinned_globally] = @opts[:pinned_globally] if @opts[:pinned_globally].present?
|
2022-02-09 11:55:32 +08:00
|
|
|
topic_params[:external_id] = @opts[:external_id] if @opts[:external_id].present?
|
2021-08-05 17:38:39 +08:00
|
|
|
topic_params[:featured_link] = @opts[:featured_link]
|
2016-12-05 20:31:43 +08:00
|
|
|
|
2013-06-05 02:13:01 +08:00
|
|
|
topic_params
|
|
|
|
end
|
|
|
|
|
2020-03-10 22:35:40 +08:00
|
|
|
def convert_time(timestamp)
|
|
|
|
if timestamp.is_a?(Time)
|
|
|
|
timestamp
|
|
|
|
else
|
|
|
|
Time.zone.parse(timestamp.to_s)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-02-07 03:52:50 +08:00
|
|
|
def find_category
|
2019-05-09 14:46:20 +08:00
|
|
|
@category ||=
|
|
|
|
begin
|
|
|
|
# PM can't have a category
|
|
|
|
if @opts[:archetype].present? && @opts[:archetype] == Archetype.private_message
|
|
|
|
@opts.delete(:category)
|
2023-01-09 20:10:19 +08:00
|
|
|
end
|
2014-02-07 03:52:50 +08:00
|
|
|
|
2019-05-09 14:46:20 +08:00
|
|
|
return Category.find(SiteSetting.shared_drafts_category) if @opts[:shared_draft]
|
2018-03-14 03:59:12 +08:00
|
|
|
|
2023-01-21 02:52:49 +08:00
|
|
|
if (@opts[:category].is_a? Integer) || (@opts[:category] =~ /\A\d+\z/)
|
2019-05-09 14:46:20 +08:00
|
|
|
Category.find_by(id: @opts[:category])
|
2023-01-09 20:10:19 +08:00
|
|
|
end
|
2019-05-09 14:46:20 +08:00
|
|
|
end
|
2014-02-07 03:52:50 +08:00
|
|
|
end
|
|
|
|
|
2016-05-05 02:02:47 +08:00
|
|
|
def setup_tags(topic)
|
2021-05-14 21:52:10 +08:00
|
|
|
if @opts[:tags].present?
|
|
|
|
valid_tags = DiscourseTagging.tag_topic_by_names(topic, @guardian, @opts[:tags])
|
|
|
|
unless valid_tags
|
|
|
|
topic.errors.add(:base, :unable_to_tag)
|
|
|
|
rollback_from_errors!(topic)
|
|
|
|
end
|
2018-03-29 02:40:26 +08:00
|
|
|
end
|
2021-04-23 21:55:34 +08:00
|
|
|
|
2021-05-14 21:52:10 +08:00
|
|
|
watched_words = WordWatcher.words_for_action(:tag)
|
|
|
|
if watched_words.present?
|
|
|
|
word_watcher = WordWatcher.new("#{@opts[:title]} #{@opts[:raw]}")
|
|
|
|
word_watcher_tags = topic.tags.map(&:name)
|
2022-08-02 16:06:03 +08:00
|
|
|
watched_words.each do |word, opts|
|
|
|
|
if word_watcher.word_matches?(word, case_sensitive: opts[:case_sensitive])
|
|
|
|
word_watcher_tags += opts[:replacement].split(",")
|
|
|
|
end
|
2021-04-23 21:55:34 +08:00
|
|
|
end
|
2021-05-14 21:52:10 +08:00
|
|
|
DiscourseTagging.tag_topic_by_names(topic, Discourse.system_user.guardian, word_watcher_tags)
|
2021-04-23 21:55:34 +08:00
|
|
|
end
|
2016-05-05 02:02:47 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def setup_auto_close_time(topic)
|
2014-02-07 03:52:50 +08:00
|
|
|
return unless @opts[:auto_close_time].present?
|
2015-03-27 04:57:50 +08:00
|
|
|
return unless @guardian.can_moderate?(topic)
|
2015-05-28 00:22:34 +08:00
|
|
|
topic.set_auto_close(@opts[:auto_close_time], by_user: @user)
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def process_private_message(topic)
|
2014-02-07 03:52:50 +08:00
|
|
|
return unless @opts[:archetype] == Archetype.private_message
|
2015-03-27 04:57:50 +08:00
|
|
|
topic.subtype = TopicSubtype.user_to_user unless topic.subtype
|
2013-06-05 02:13:01 +08:00
|
|
|
|
2017-08-29 00:07:30 +08:00
|
|
|
unless @opts[:target_usernames].present? || @opts[:target_emails].present? ||
|
|
|
|
@opts[:target_group_names].present?
|
2015-03-27 04:57:50 +08:00
|
|
|
rollback_with!(topic, :no_user_selected)
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2018-08-27 09:38:11 +08:00
|
|
|
if @opts[:target_emails].present? && !@guardian.can_send_private_messages_to_email?
|
2021-03-30 17:18:57 +08:00
|
|
|
rollback_with!(topic, :send_to_email_disabled)
|
2017-08-29 00:07:30 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
add_users(topic, @opts[:target_usernames])
|
2017-08-29 00:07:30 +08:00
|
|
|
add_emails(topic, @opts[:target_emails])
|
2015-03-27 04:57:50 +08:00
|
|
|
add_groups(topic, @opts[:target_group_names])
|
2018-12-10 11:45:02 +08:00
|
|
|
|
|
|
|
topic.topic_allowed_users.build(user_id: @user.id) if !@added_users.include?(user)
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def save_topic(topic)
|
2015-04-22 04:48:39 +08:00
|
|
|
topic.disable_rate_limits! if @opts[:skip_validations]
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
rollback_from_errors!(topic) unless topic.save(validate: !@opts[:skip_validations])
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
def add_users(topic, usernames)
|
|
|
|
return unless usernames
|
2015-12-02 12:49:43 +08:00
|
|
|
|
2020-05-26 00:04:05 +08:00
|
|
|
names = usernames.split(",").flatten.map(&:downcase)
|
2015-12-02 12:49:43 +08:00
|
|
|
len = 0
|
|
|
|
|
2020-10-08 08:28:07 +08:00
|
|
|
User
|
|
|
|
.includes(:user_option)
|
|
|
|
.where("username_lower in (?)", names)
|
|
|
|
.find_each do |user|
|
2014-09-08 23:11:56 +08:00
|
|
|
check_can_send_permission!(topic, user)
|
|
|
|
@added_users << user
|
2013-06-05 02:13:01 +08:00
|
|
|
topic.topic_allowed_users.build(user_id: user.id)
|
2015-12-02 12:49:43 +08:00
|
|
|
len += 1
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
2015-12-02 12:49:43 +08:00
|
|
|
|
|
|
|
rollback_with!(topic, :target_user_not_found) unless len == names.length
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2017-08-29 00:07:30 +08:00
|
|
|
def add_emails(topic, emails)
|
|
|
|
return unless emails
|
|
|
|
|
2017-09-28 12:25:42 +08:00
|
|
|
begin
|
|
|
|
emails = emails.split(",").flatten
|
|
|
|
len = 0
|
|
|
|
|
|
|
|
emails.each do |email|
|
|
|
|
display_name = email.split("@").first
|
|
|
|
|
|
|
|
if user = find_or_create_user(email, display_name)
|
2018-12-10 11:45:02 +08:00
|
|
|
if !@added_users.include?(user)
|
|
|
|
@added_users << user
|
|
|
|
topic.topic_allowed_users.build(user_id: user.id)
|
|
|
|
end
|
2017-09-28 12:25:42 +08:00
|
|
|
len += 1
|
|
|
|
end
|
|
|
|
end
|
|
|
|
ensure
|
|
|
|
rollback_with!(topic, :target_user_not_found) unless len == emails.length
|
2017-08-29 00:07:30 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-06-05 02:13:01 +08:00
|
|
|
def add_groups(topic, groups)
|
|
|
|
return unless groups
|
2020-05-28 04:49:00 +08:00
|
|
|
names = groups.split(",").flatten.map(&:downcase)
|
2015-12-02 12:49:43 +08:00
|
|
|
len = 0
|
|
|
|
|
2020-05-28 04:49:00 +08:00
|
|
|
Group
|
|
|
|
.where("lower(name) in (?)", names)
|
|
|
|
.each do |group|
|
2015-03-27 04:57:50 +08:00
|
|
|
check_can_send_permission!(topic, group)
|
2013-06-05 02:13:01 +08:00
|
|
|
topic.topic_allowed_groups.build(group_id: group.id)
|
2015-12-02 12:49:43 +08:00
|
|
|
len += 1
|
2015-12-20 14:21:31 +08:00
|
|
|
group.update_columns(has_messages: true) unless group.has_messages
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
2015-12-02 12:49:43 +08:00
|
|
|
|
|
|
|
rollback_with!(topic, :target_group_not_found) unless len == names.length
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
|
|
|
|
2015-03-27 04:57:50 +08:00
|
|
|
def check_can_send_permission!(topic, obj)
|
2019-01-24 19:26:59 +08:00
|
|
|
unless @opts[:skip_validations] ||
|
2019-01-24 19:52:17 +08:00
|
|
|
@guardian.can_send_private_message?(
|
|
|
|
obj,
|
|
|
|
notify_moderators: topic&.subtype == TopicSubtype.notify_moderators,
|
|
|
|
)
|
2019-01-24 19:26:59 +08:00
|
|
|
rollback_with!(topic, :cant_send_pm)
|
|
|
|
end
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|
2017-08-29 00:07:30 +08:00
|
|
|
|
|
|
|
def find_or_create_user(email, display_name)
|
|
|
|
user = User.find_by_email(email)
|
|
|
|
|
2017-09-28 12:25:42 +08:00
|
|
|
if !user && SiteSetting.enable_staged_users
|
2017-08-29 00:07:30 +08:00
|
|
|
username = UserNameSuggester.sanitize_username(display_name) if display_name.present?
|
2017-09-28 12:25:42 +08:00
|
|
|
|
2017-08-29 00:07:30 +08:00
|
|
|
user =
|
|
|
|
User.create!(
|
|
|
|
email: email,
|
|
|
|
username: UserNameSuggester.suggest(username.presence || email),
|
|
|
|
name: display_name.presence || User.suggest_name(email),
|
|
|
|
staged: true,
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
user
|
|
|
|
end
|
2013-06-05 02:13:01 +08:00
|
|
|
end
|