2015-06-12 18:02:36 +08:00
|
|
|
require_dependency "file_helper"
|
|
|
|
require_dependency "url_helper"
|
|
|
|
require_dependency "db_helper"
|
|
|
|
require_dependency "file_store/local_store"
|
2013-06-17 08:46:42 +08:00
|
|
|
|
2013-06-16 16:39:48 +08:00
|
|
|
class OptimizedImage < ActiveRecord::Base
|
|
|
|
belongs_to :upload
|
|
|
|
|
2015-05-28 07:03:24 +08:00
|
|
|
# BUMP UP if optimized image algorithm changes
|
|
|
|
VERSION = 1
|
|
|
|
|
2018-01-24 05:22:08 +08:00
|
|
|
def self.lock(upload_id, width, height)
|
2018-01-24 05:53:17 +08:00
|
|
|
@hostname ||= `hostname`.strip rescue "unknown"
|
|
|
|
# note, the extra lock here ensures we only optimize one image per machine
|
2018-01-24 05:22:08 +08:00
|
|
|
# this can very easily lead to runaway CPU so slowing it down is beneficial
|
2018-01-24 05:53:17 +08:00
|
|
|
DistributedMutex.synchronize("optimized_image_host_#{@hostname}") do
|
2018-01-24 05:22:08 +08:00
|
|
|
DistributedMutex.synchronize("optimized_image_#{upload_id}_#{width}_#{height}") do
|
|
|
|
yield
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.create_for(upload, width, height, opts = {})
|
2013-11-06 02:04:47 +08:00
|
|
|
return unless width > 0 && height > 0
|
2015-06-11 00:15:10 +08:00
|
|
|
return if upload.try(:sha1).blank?
|
2013-07-08 07:39:08 +08:00
|
|
|
|
2018-01-24 05:22:08 +08:00
|
|
|
lock(upload.id, width, height) do
|
2015-05-12 22:45:33 +08:00
|
|
|
# do we already have that thumbnail?
|
|
|
|
thumbnail = find_by(upload_id: upload.id, width: width, height: height)
|
2013-06-17 08:46:42 +08:00
|
|
|
|
2015-06-01 23:49:58 +08:00
|
|
|
# make sure we have an url
|
2015-05-12 22:45:33 +08:00
|
|
|
if thumbnail && thumbnail.url.blank?
|
|
|
|
thumbnail.destroy
|
|
|
|
thumbnail = nil
|
|
|
|
end
|
2013-11-06 02:04:47 +08:00
|
|
|
|
2015-05-12 22:45:33 +08:00
|
|
|
# return the previous thumbnail if any
|
|
|
|
return thumbnail unless thumbnail.nil?
|
2013-06-17 08:46:42 +08:00
|
|
|
|
2015-05-12 22:45:33 +08:00
|
|
|
# create the thumbnail otherwise
|
2015-06-01 09:17:42 +08:00
|
|
|
original_path = Discourse.store.path_for(upload)
|
|
|
|
if original_path.blank?
|
2015-06-11 00:18:20 +08:00
|
|
|
external_copy = Discourse.store.download(upload) rescue nil
|
2015-06-01 09:17:42 +08:00
|
|
|
original_path = external_copy.try(:path)
|
2015-02-04 01:44:18 +08:00
|
|
|
end
|
2014-11-04 02:54:10 +08:00
|
|
|
|
2015-05-12 22:45:33 +08:00
|
|
|
if original_path.blank?
|
|
|
|
Rails.logger.error("Could not find file in the store located at url: #{upload.url}")
|
|
|
|
else
|
|
|
|
# create a temp file with the same extension as the original
|
|
|
|
extension = File.extname(original_path)
|
|
|
|
temp_file = Tempfile.new(["discourse-thumbnail", extension])
|
|
|
|
temp_path = temp_file.path
|
|
|
|
|
|
|
|
if extension =~ /\.svg$/i
|
|
|
|
FileUtils.cp(original_path, temp_path)
|
|
|
|
resized = true
|
2016-05-23 22:18:30 +08:00
|
|
|
elsif opts[:crop]
|
|
|
|
resized = crop(original_path, temp_path, width, height, opts)
|
2013-11-06 02:04:47 +08:00
|
|
|
else
|
2015-05-12 22:45:33 +08:00
|
|
|
resized = resize(original_path, temp_path, width, height, opts)
|
2013-11-06 02:04:47 +08:00
|
|
|
end
|
2015-05-12 22:45:33 +08:00
|
|
|
|
|
|
|
if resized
|
|
|
|
thumbnail = OptimizedImage.create!(
|
|
|
|
upload_id: upload.id,
|
2016-09-02 14:50:13 +08:00
|
|
|
sha1: Upload.generate_digest(temp_path),
|
2015-05-12 22:45:33 +08:00
|
|
|
extension: extension,
|
|
|
|
width: width,
|
|
|
|
height: height,
|
|
|
|
url: "",
|
|
|
|
)
|
|
|
|
# store the optimized image and update its url
|
2015-05-29 19:02:05 +08:00
|
|
|
File.open(temp_path) do |file|
|
|
|
|
url = Discourse.store.store_optimized_image(file, thumbnail)
|
|
|
|
if url.present?
|
|
|
|
thumbnail.url = url
|
|
|
|
thumbnail.save
|
|
|
|
end
|
2015-05-12 22:45:33 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# close && remove temp file
|
|
|
|
temp_file.close!
|
2013-11-06 02:04:47 +08:00
|
|
|
end
|
|
|
|
|
2015-05-12 22:45:33 +08:00
|
|
|
# make sure we remove the cached copy from external stores
|
|
|
|
if Discourse.store.external?
|
2018-03-28 16:20:08 +08:00
|
|
|
external_copy&.close
|
2015-05-12 22:45:33 +08:00
|
|
|
end
|
2013-06-17 08:46:42 +08:00
|
|
|
|
2015-05-12 22:45:33 +08:00
|
|
|
thumbnail
|
2015-02-10 00:00:58 +08:00
|
|
|
end
|
2013-06-17 07:00:25 +08:00
|
|
|
end
|
|
|
|
|
2013-06-21 15:34:02 +08:00
|
|
|
def destroy
|
|
|
|
OptimizedImage.transaction do
|
2013-08-14 04:09:27 +08:00
|
|
|
Discourse.store.remove_optimized_image(self)
|
2013-06-21 15:34:02 +08:00
|
|
|
super
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-05-26 10:32:52 +08:00
|
|
|
def local?
|
2017-07-28 09:20:09 +08:00
|
|
|
!(url =~ /^(https?:)?\/\//)
|
2015-05-26 10:32:52 +08:00
|
|
|
end
|
|
|
|
|
2016-12-19 07:16:18 +08:00
|
|
|
def self.safe_path?(path)
|
|
|
|
# this matches instructions which call #to_s
|
|
|
|
path = path.to_s
|
|
|
|
return false if path != File.expand_path(path)
|
2017-01-02 23:28:14 +08:00
|
|
|
return false if path !~ /\A[\w\-\.\/]+\z/m
|
2016-12-19 07:16:18 +08:00
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
def self.ensure_safe_paths!(*paths)
|
|
|
|
paths.each do |path|
|
|
|
|
raise Discourse::InvalidAccess unless safe_path?(path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-08-15 11:56:57 +08:00
|
|
|
IM_DECODERS ||= /\A(jpe?g|png|tiff?|bmp|ico|gif)\z/i
|
2018-07-26 04:00:04 +08:00
|
|
|
|
|
|
|
def self.prepend_decoder!(path)
|
|
|
|
extension = File.extname(path)[1..-1]
|
2018-08-13 04:02:17 +08:00
|
|
|
raise Discourse::InvalidAccess unless extension.present? && extension[IM_DECODERS]
|
2018-07-26 05:55:06 +08:00
|
|
|
"#{extension}:#{path}"
|
2018-07-26 04:00:04 +08:00
|
|
|
end
|
|
|
|
|
2017-07-25 17:48:39 +08:00
|
|
|
def self.thumbnail_or_resize
|
|
|
|
SiteSetting.strip_image_metadata ? "thumbnail" : "resize"
|
|
|
|
end
|
2016-12-19 07:16:18 +08:00
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.resize_instructions(from, to, dimensions, opts = {})
|
2016-12-19 07:16:18 +08:00
|
|
|
ensure_safe_paths!(from, to)
|
|
|
|
|
2018-07-26 05:55:06 +08:00
|
|
|
from = prepend_decoder!(from)
|
|
|
|
to = prepend_decoder!(to)
|
2018-07-26 04:00:04 +08:00
|
|
|
|
2014-06-11 22:01:01 +08:00
|
|
|
# NOTE: ORDER is important!
|
2015-02-25 22:08:33 +08:00
|
|
|
%W{
|
2015-07-22 23:10:42 +08:00
|
|
|
convert
|
2015-02-25 22:08:33 +08:00
|
|
|
#{from}[0]
|
2017-06-22 22:53:49 +08:00
|
|
|
-auto-orient
|
2015-02-25 22:08:33 +08:00
|
|
|
-gravity center
|
|
|
|
-background transparent
|
2017-07-25 17:48:39 +08:00
|
|
|
-#{thumbnail_or_resize} #{dimensions}^
|
2015-02-25 22:08:33 +08:00
|
|
|
-extent #{dimensions}
|
2018-07-17 15:48:59 +08:00
|
|
|
-interpolate catrom
|
2015-02-25 22:08:33 +08:00
|
|
|
-unsharp 2x0.5+0.7+0
|
2017-06-27 05:19:48 +08:00
|
|
|
-interlace none
|
2015-02-25 22:08:33 +08:00
|
|
|
-quality 98
|
2016-03-08 06:26:28 +08:00
|
|
|
-profile #{File.join(Rails.root, 'vendor', 'data', 'RT_sRGB.icm')}
|
2015-02-25 22:08:33 +08:00
|
|
|
#{to}
|
|
|
|
}
|
2015-02-21 00:24:37 +08:00
|
|
|
end
|
2014-05-22 15:34:33 +08:00
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.resize_instructions_animated(from, to, dimensions, opts = {})
|
2016-12-19 07:16:18 +08:00
|
|
|
ensure_safe_paths!(from, to)
|
|
|
|
|
2015-02-25 22:08:33 +08:00
|
|
|
%W{
|
2015-07-22 23:10:42 +08:00
|
|
|
gifsicle
|
|
|
|
--colors=256
|
|
|
|
--resize-fit #{dimensions}
|
|
|
|
--optimize=3
|
|
|
|
--output #{to}
|
2016-07-28 00:48:02 +08:00
|
|
|
#{from}
|
2015-02-25 22:08:33 +08:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.crop_instructions(from, to, dimensions, opts = {})
|
2016-12-19 07:16:18 +08:00
|
|
|
ensure_safe_paths!(from, to)
|
|
|
|
|
2018-07-26 05:55:06 +08:00
|
|
|
from = prepend_decoder!(from)
|
|
|
|
to = prepend_decoder!(to)
|
2018-07-26 04:00:04 +08:00
|
|
|
|
2016-05-23 22:18:30 +08:00
|
|
|
%W{
|
|
|
|
convert
|
|
|
|
#{from}[0]
|
2017-06-22 22:53:49 +08:00
|
|
|
-auto-orient
|
2016-05-23 22:18:30 +08:00
|
|
|
-gravity north
|
|
|
|
-background transparent
|
2017-07-25 17:48:39 +08:00
|
|
|
-#{thumbnail_or_resize} #{opts[:width]}
|
2016-05-23 22:18:30 +08:00
|
|
|
-crop #{dimensions}+0+0
|
|
|
|
-unsharp 2x0.5+0.7+0
|
2017-06-27 05:19:48 +08:00
|
|
|
-interlace none
|
2016-05-23 22:18:30 +08:00
|
|
|
-quality 98
|
|
|
|
-profile #{File.join(Rails.root, 'vendor', 'data', 'RT_sRGB.icm')}
|
|
|
|
#{to}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.crop_instructions_animated(from, to, dimensions, opts = {})
|
2016-12-19 07:16:18 +08:00
|
|
|
ensure_safe_paths!(from, to)
|
|
|
|
|
2016-07-28 00:48:02 +08:00
|
|
|
%W{
|
|
|
|
gifsicle
|
|
|
|
--crop 0,0+#{dimensions}
|
|
|
|
--colors=256
|
|
|
|
--optimize=3
|
|
|
|
--output #{to}
|
|
|
|
#{from}
|
|
|
|
}
|
2016-05-23 22:18:30 +08:00
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.downsize_instructions(from, to, dimensions, opts = {})
|
2016-12-19 07:16:18 +08:00
|
|
|
ensure_safe_paths!(from, to)
|
|
|
|
|
2018-07-26 05:55:06 +08:00
|
|
|
from = prepend_decoder!(from)
|
|
|
|
to = prepend_decoder!(to)
|
2018-07-26 04:00:04 +08:00
|
|
|
|
2015-02-25 22:08:33 +08:00
|
|
|
%W{
|
2015-07-22 23:10:42 +08:00
|
|
|
convert
|
2015-02-25 22:08:33 +08:00
|
|
|
#{from}[0]
|
2017-06-22 22:53:49 +08:00
|
|
|
-auto-orient
|
2015-02-25 22:08:33 +08:00
|
|
|
-gravity center
|
|
|
|
-background transparent
|
2017-06-27 05:19:48 +08:00
|
|
|
-interlace none
|
2017-05-11 06:16:57 +08:00
|
|
|
-resize #{dimensions}
|
2016-03-08 06:26:28 +08:00
|
|
|
-profile #{File.join(Rails.root, 'vendor', 'data', 'RT_sRGB.icm')}
|
2015-02-25 22:08:33 +08:00
|
|
|
#{to}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.downsize_instructions_animated(from, to, dimensions, opts = {})
|
2015-07-22 23:10:42 +08:00
|
|
|
resize_instructions_animated(from, to, dimensions, opts)
|
2014-05-22 15:34:33 +08:00
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.resize(from, to, width, height, opts = {})
|
2015-08-13 00:33:13 +08:00
|
|
|
optimize("resize", from, to, "#{width}x#{height}", opts)
|
2015-02-21 00:24:37 +08:00
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.crop(from, to, width, height, opts = {})
|
2016-05-23 22:18:30 +08:00
|
|
|
opts[:width] = width
|
|
|
|
optimize("crop", from, to, "#{width}x#{height}", opts)
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.downsize(from, to, dimensions, opts = {})
|
2015-08-13 00:33:13 +08:00
|
|
|
optimize("downsize", from, to, dimensions, opts)
|
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.optimize(operation, from, to, dimensions, opts = {})
|
2015-02-25 22:08:33 +08:00
|
|
|
method_name = "#{operation}_instructions"
|
2015-09-21 04:01:03 +08:00
|
|
|
if !!opts[:allow_animation] && (from =~ /\.GIF$/i || opts[:filename] =~ /\.GIF$/i)
|
|
|
|
method_name += "_animated"
|
|
|
|
end
|
2015-08-13 00:33:13 +08:00
|
|
|
instructions = self.send(method_name.to_sym, from, to, dimensions, opts)
|
2018-07-26 10:17:38 +08:00
|
|
|
convert_with(instructions, to, opts)
|
2015-02-25 22:08:33 +08:00
|
|
|
end
|
|
|
|
|
2018-07-26 10:17:38 +08:00
|
|
|
def self.convert_with(instructions, to, opts = {})
|
2018-07-17 15:48:59 +08:00
|
|
|
Discourse::Utils.execute_command(*instructions)
|
2017-07-25 17:48:39 +08:00
|
|
|
FileHelper.optimize_image!(to)
|
2015-02-21 00:24:37 +08:00
|
|
|
true
|
2018-07-18 14:11:23 +08:00
|
|
|
rescue => e
|
2018-07-26 10:17:38 +08:00
|
|
|
if opts[:raise_on_error]
|
2018-07-26 09:16:14 +08:00
|
|
|
raise e
|
|
|
|
else
|
2018-08-15 11:27:24 +08:00
|
|
|
error = +"Failed to optimize image:"
|
|
|
|
|
|
|
|
if e.message =~ /^convert:([^`]+)/
|
|
|
|
error << $1
|
|
|
|
else
|
|
|
|
error << " unknown reason"
|
|
|
|
end
|
|
|
|
|
|
|
|
Discourse.warn(error, location: to, error_message: e.message)
|
2018-07-26 09:16:14 +08:00
|
|
|
false
|
|
|
|
end
|
2015-02-21 00:24:37 +08:00
|
|
|
end
|
|
|
|
|
2017-07-28 09:20:09 +08:00
|
|
|
def self.migrate_to_new_scheme(limit = nil)
|
2015-06-12 18:02:36 +08:00
|
|
|
problems = []
|
|
|
|
|
|
|
|
if SiteSetting.migrate_to_new_scheme
|
|
|
|
max_file_size_kb = SiteSetting.max_image_size_kb.kilobytes
|
|
|
|
local_store = FileStore::LocalStore.new
|
|
|
|
|
2016-09-02 10:55:11 +08:00
|
|
|
scope = OptimizedImage.includes(:upload)
|
|
|
|
.where("url NOT LIKE '%/optimized/_X/%'")
|
|
|
|
.order(id: :desc)
|
|
|
|
|
|
|
|
scope.limit(limit) if limit
|
|
|
|
|
|
|
|
scope.each do |optimized_image|
|
2015-06-12 18:02:36 +08:00
|
|
|
begin
|
|
|
|
# keep track of the url
|
|
|
|
previous_url = optimized_image.url.dup
|
|
|
|
# where is the file currently stored?
|
|
|
|
external = previous_url =~ /^\/\//
|
|
|
|
# download if external
|
|
|
|
if external
|
|
|
|
url = SiteSetting.scheme + ":" + previous_url
|
2017-05-25 01:42:52 +08:00
|
|
|
file = FileHelper.download(
|
|
|
|
url,
|
|
|
|
max_file_size: max_file_size_kb,
|
|
|
|
tmp_file_name: "discourse",
|
|
|
|
follow_redirect: true
|
|
|
|
) rescue nil
|
2015-06-12 18:02:36 +08:00
|
|
|
path = file.path
|
|
|
|
else
|
|
|
|
path = local_store.path_for(optimized_image)
|
|
|
|
file = File.open(path)
|
|
|
|
end
|
|
|
|
# compute SHA if missing
|
|
|
|
if optimized_image.sha1.blank?
|
2016-09-02 14:50:13 +08:00
|
|
|
optimized_image.sha1 = Upload.generate_digest(path)
|
2015-06-12 18:02:36 +08:00
|
|
|
end
|
|
|
|
# optimize if image
|
2017-07-25 17:48:39 +08:00
|
|
|
FileHelper.optimize_image!(path)
|
2015-06-12 18:02:36 +08:00
|
|
|
# store to new location & update the filesize
|
|
|
|
File.open(path) do |f|
|
|
|
|
optimized_image.url = Discourse.store.store_optimized_image(f, optimized_image)
|
|
|
|
optimized_image.save
|
|
|
|
end
|
|
|
|
# remap the URLs
|
|
|
|
DbHelper.remap(UrlHelper.absolute(previous_url), optimized_image.url) unless external
|
|
|
|
DbHelper.remap(previous_url, optimized_image.url)
|
|
|
|
# remove the old file (when local)
|
|
|
|
unless external
|
2018-03-28 16:20:08 +08:00
|
|
|
FileUtils.rm(path, force: true)
|
2015-06-12 18:02:36 +08:00
|
|
|
end
|
|
|
|
rescue => e
|
|
|
|
problems << { optimized_image: optimized_image, ex: e }
|
2015-06-16 00:30:11 +08:00
|
|
|
# just ditch the optimized image if there was any errors
|
|
|
|
optimized_image.destroy
|
2015-06-12 18:02:36 +08:00
|
|
|
ensure
|
2018-03-28 16:20:08 +08:00
|
|
|
file&.unlink
|
|
|
|
file&.close
|
2015-06-12 18:02:36 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
problems
|
|
|
|
end
|
|
|
|
|
2013-06-16 16:39:48 +08:00
|
|
|
end
|
2013-06-17 08:48:58 +08:00
|
|
|
|
|
|
|
# == Schema Information
|
|
|
|
#
|
|
|
|
# Table name: optimized_images
|
|
|
|
#
|
|
|
|
# id :integer not null, primary key
|
2013-06-17 10:02:17 +08:00
|
|
|
# sha1 :string(40) not null
|
|
|
|
# extension :string(10) not null
|
2013-06-17 08:48:58 +08:00
|
|
|
# width :integer not null
|
|
|
|
# height :integer not null
|
|
|
|
# upload_id :integer not null
|
2018-02-20 14:28:58 +08:00
|
|
|
# url :string not null
|
2013-06-17 08:48:58 +08:00
|
|
|
#
|
|
|
|
# Indexes
|
|
|
|
#
|
|
|
|
# index_optimized_images_on_upload_id (upload_id)
|
|
|
|
# index_optimized_images_on_upload_id_and_width_and_height (upload_id,width,height) UNIQUE
|
|
|
|
#
|