discourse/lib/validators/url_validator.rb

# frozen_string_literal: true

class UrlValidator < ActiveModel::EachValidator
  def validate_each(record, attribute, value)
    if value.present?
      valid =
        begin
          uri = URI.parse(value)
          uri.is_a?(URI::HTTP) && !uri.host.nil? && uri.host.include?(".")
        rescue URI::Error => e
          if (e.message =~ /URI must be ascii only/)
            value = URI.encode(value)
            retry
          end

          nil
        end

      unless valid
        record.errors.add(attribute, options[:message] || I18n.t('errors.messages.invalid'))
      end
    end
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-03 06:17:27 +08:00			`# frozen_string_literal: true`

FEATURE: add flair to avatars using new settings in the groups admin UI 2016-08-17 00:34:04 +08:00			`class UrlValidator < ActiveModel::EachValidator`
			`def validate_each(record, attribute, value)`
			`if value.present?`
Improve URL validation to check for a valid host. Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com> 2017-12-21 12:27:17 +08:00			`valid =`
			`begin`
			`uri = URI.parse(value)`
			`uri.is_a?(URI::HTTP) && !uri.host.nil? && uri.host.include?(".")`
FIX: store the topic links using the cooked upload url 2018-08-14 18:23:32 +08:00			`rescue URI::Error => e`
Treat non-ascii URLs in `UrlValidator`. 2017-12-21 14:22:55 +08:00			`if (e.message =~ /URI must be ascii only/)`
			`value = URI.encode(value)`
			`retry`
			`end`

Improve URL validation to check for a valid host. Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com> 2017-12-21 12:27:17 +08:00			`nil`
			`end`
FEATURE: add flair to avatars using new settings in the groups admin UI 2016-08-17 00:34:04 +08:00
Improve URL validation to check for a valid host. Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com> 2017-12-21 12:27:17 +08:00			`unless valid`
DEV: Add support for Rails 6 Minor fixes to add Rails 6 support to Discourse, we now will boot with RAILS_MASTER=1, all specs pass Only one tiny deprecation left Largest change was the way ActiveModel:Errors changed interface a bit but there is a simple backwards compat way of working it 2019-04-30 14:58:18 +08:00			`record.errors.add(attribute, options[:message] \|\| I18n.t('errors.messages.invalid'))`
FEATURE: add flair to avatars using new settings in the groups admin UI 2016-08-17 00:34:04 +08:00			`end`
			`end`
			`end`
			`end`