2019-04-30 08:27:42 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-08 18:40:48 +08:00
|
|
|
RSpec::Matchers.define :add_notification do |user, notification_type|
|
|
|
|
match(notify_expectation_failures: true) do |actual|
|
|
|
|
notifications = user.notifications
|
|
|
|
before = notifications.count
|
|
|
|
|
|
|
|
actual.call
|
|
|
|
|
|
|
|
expect(notifications.count).to eq(before + 1), "expected 1 new notification, got #{notifications.count - before}"
|
|
|
|
|
|
|
|
last_notification_type = notifications.last.notification_type
|
|
|
|
expect(last_notification_type).to eq(Notification.types[notification_type]),
|
|
|
|
"expected notification type to be '#{notification_type}', got '#{Notification.types.key(last_notification_type)}'"
|
|
|
|
end
|
|
|
|
|
|
|
|
match_when_negated do |actual|
|
|
|
|
expect { actual.call }.to_not change { user.notifications.where(notification_type: Notification.types[notification_type]).count }
|
|
|
|
end
|
|
|
|
|
|
|
|
supports_block_expectations
|
|
|
|
end
|
|
|
|
|
2018-04-07 05:37:29 +08:00
|
|
|
RSpec::Matchers.define_negated_matcher :not_add_notification, :add_notification
|
|
|
|
|
2022-07-28 10:27:38 +08:00
|
|
|
RSpec.describe PostAlerter do
|
2021-12-16 01:41:14 +08:00
|
|
|
fab!(:category) { Fabricate(:category) }
|
2014-03-18 12:22:39 +08:00
|
|
|
|
2021-12-16 01:41:14 +08:00
|
|
|
fab!(:topic) { Fabricate(:topic) }
|
|
|
|
fab!(:post) { Fabricate(:post) }
|
|
|
|
|
|
|
|
fab!(:private_message_topic) { Fabricate(:private_message_topic) }
|
|
|
|
fab!(:private_message_topic_post1) { Fabricate(:post, topic: private_message_topic) }
|
|
|
|
fab!(:private_message_topic_post2) { Fabricate(:post, topic: private_message_topic) }
|
|
|
|
|
|
|
|
fab!(:group) { Fabricate(:group) }
|
|
|
|
|
|
|
|
fab!(:admin) { Fabricate(:admin) }
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:evil_trout) { Fabricate(:evil_trout) }
|
2021-12-16 01:41:14 +08:00
|
|
|
fab!(:coding_horror) { Fabricate(:coding_horror) }
|
|
|
|
fab!(:walterwhite) { Fabricate(:walter_white) }
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:user) { Fabricate(:user) }
|
2021-11-24 04:25:54 +08:00
|
|
|
fab!(:tl2_user) { Fabricate(:user, trust_level: TrustLevel[2]) }
|
2014-03-18 12:22:39 +08:00
|
|
|
|
|
|
|
def create_post_with_alerts(args = {})
|
|
|
|
post = Fabricate(:post, args)
|
2014-03-19 09:07:48 +08:00
|
|
|
PostAlerter.post_created(post)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with private message" do
|
2016-03-22 11:28:14 +08:00
|
|
|
it "notifies for pms correctly" do
|
|
|
|
pm = Fabricate(:topic, archetype: 'private_message', category_id: nil)
|
2018-06-05 15:29:17 +08:00
|
|
|
op = Fabricate(:post, user: pm.user)
|
2016-03-22 11:28:14 +08:00
|
|
|
pm.allowed_users << pm.user
|
|
|
|
PostAlerter.post_created(op)
|
2018-06-05 15:29:17 +08:00
|
|
|
|
|
|
|
reply = Fabricate(:post, user: pm.user, topic: pm, reply_to_post_number: 1)
|
2016-03-22 11:28:14 +08:00
|
|
|
PostAlerter.post_created(reply)
|
|
|
|
|
2018-06-05 15:29:17 +08:00
|
|
|
reply2 = Fabricate(:post, topic: pm, reply_to_post_number: 1)
|
2016-03-22 11:28:14 +08:00
|
|
|
PostAlerter.post_created(reply2)
|
|
|
|
|
|
|
|
# we get a green notification for a reply
|
2019-10-21 18:32:27 +08:00
|
|
|
expect(Notification.where(user_id: pm.user_id).pluck_first(:notification_type)).to eq(Notification.types[:private_message])
|
2016-03-22 11:28:14 +08:00
|
|
|
|
|
|
|
TopicUser.change(pm.user_id, pm.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
|
|
|
|
Notification.destroy_all
|
|
|
|
|
2018-06-05 15:29:17 +08:00
|
|
|
reply3 = Fabricate(:post, topic: pm)
|
2016-03-22 11:28:14 +08:00
|
|
|
PostAlerter.post_created(reply3)
|
|
|
|
|
|
|
|
# no notification cause we are tracking
|
|
|
|
expect(Notification.where(user_id: pm.user_id).count).to eq(0)
|
|
|
|
|
|
|
|
Notification.destroy_all
|
|
|
|
|
2018-06-05 15:29:17 +08:00
|
|
|
reply4 = Fabricate(:post, topic: pm, reply_to_post_number: 1)
|
2016-03-22 11:28:14 +08:00
|
|
|
PostAlerter.post_created(reply4)
|
|
|
|
|
|
|
|
# yes notification cause we were replied to
|
|
|
|
expect(Notification.where(user_id: pm.user_id).count).to eq(1)
|
|
|
|
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with group inboxes" do
|
2020-09-22 01:33:29 +08:00
|
|
|
fab!(:user1) { Fabricate(:user) }
|
|
|
|
fab!(:user2) { Fabricate(:user) }
|
2022-03-11 18:57:47 +08:00
|
|
|
fab!(:group) { Fabricate(:group, users: [user2], name: "TestGroup", default_notification_level: 2) }
|
2020-09-22 01:33:29 +08:00
|
|
|
fab!(:pm) { Fabricate(:topic, archetype: 'private_message', category_id: nil, allowed_groups: [group]) }
|
|
|
|
fab!(:op) { Fabricate(:post, user: pm.user, topic: pm) }
|
|
|
|
|
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
pm.allowed_users << user1
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.post_created(op)
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user1], op])
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user2], op])
|
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
it "triggers group summary notification" do
|
2022-03-11 18:57:47 +08:00
|
|
|
Jobs.run_immediately!
|
2020-09-22 01:33:29 +08:00
|
|
|
TopicUser.change(user2.id, pm.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
|
2017-07-20 04:51:32 +08:00
|
|
|
PostAlerter.post_created(op)
|
2020-09-22 01:33:29 +08:00
|
|
|
group_summary_notification = Notification.where(user_id: user2.id)
|
|
|
|
|
|
|
|
expect(group_summary_notification.count).to eq(1)
|
|
|
|
expect(group_summary_notification.first.notification_type).to eq(Notification.types[:group_message_summary])
|
|
|
|
|
|
|
|
notification_payload = JSON.parse(group_summary_notification.first.data)
|
|
|
|
expect(notification_payload["group_name"]).to eq(group.name)
|
2022-03-11 18:57:47 +08:00
|
|
|
expect(notification_payload["inbox_count"]).to eq(1)
|
|
|
|
|
|
|
|
# archiving the only PM clears the group summary notification
|
|
|
|
GroupArchivedMessage.archive!(group.id, pm)
|
|
|
|
expect(Notification.where(user_id: user2.id)).to be_blank
|
|
|
|
|
|
|
|
# moving to inbox the only PM restores the group summary notification
|
|
|
|
GroupArchivedMessage.move_to_inbox!(group.id, pm)
|
|
|
|
group_summary_notification = Notification.where(user_id: user2.id)
|
|
|
|
expect(group_summary_notification.first.notification_type).to eq(Notification.types[:group_message_summary])
|
|
|
|
|
|
|
|
updated_payload = JSON.parse(group_summary_notification.first.data)
|
|
|
|
expect(updated_payload["group_name"]).to eq(group.name)
|
|
|
|
expect(updated_payload["inbox_count"]).to eq(1)
|
|
|
|
|
|
|
|
# adding a second PM updates the count
|
|
|
|
pm2 = Fabricate(:topic, archetype: 'private_message', category_id: nil, allowed_groups: [group])
|
|
|
|
op2 = Fabricate(:post, user: pm2.user, topic: pm2)
|
|
|
|
TopicUser.change(user2.id, pm2.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
|
|
|
|
PostAlerter.post_created(op2)
|
|
|
|
group_summary_notification = Notification.where(user_id: user2.id)
|
|
|
|
updated_payload = JSON.parse(group_summary_notification.first.data)
|
|
|
|
|
|
|
|
expect(updated_payload["group_name"]).to eq(group.name)
|
|
|
|
expect(updated_payload["inbox_count"]).to eq(2)
|
|
|
|
|
|
|
|
# archiving the second PM quietly updates the group summary count for the acting user
|
|
|
|
GroupArchivedMessage.archive!(group.id, pm2, acting_user_id: user2.id)
|
|
|
|
group_summary_notification = Notification.where(user_id: user2.id)
|
|
|
|
expect(group_summary_notification.first.read).to eq(true)
|
|
|
|
updated_payload = JSON.parse(group_summary_notification.first.data)
|
|
|
|
|
|
|
|
expect(updated_payload["inbox_count"]).to eq(1)
|
|
|
|
|
|
|
|
# moving to inbox the second PM quietly updates the group summary count for the acting user
|
|
|
|
GroupArchivedMessage.move_to_inbox!(group.id, pm2, acting_user_id: user2.id)
|
|
|
|
group_summary_notification = Notification.where(user_id: user2.id)
|
|
|
|
expect(group_summary_notification.first.read).to eq(true)
|
|
|
|
updated_payload = JSON.parse(group_summary_notification.first.data)
|
|
|
|
|
|
|
|
expect(updated_payload["group_name"]).to eq(group.name)
|
|
|
|
expect(updated_payload["inbox_count"]).to eq(2)
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
|
2021-12-06 23:31:44 +08:00
|
|
|
it 'updates the consolidated group summary inbox count and bumps the notification' do
|
|
|
|
user2.update!(last_seen_at: 5.minutes.ago)
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
TopicUser.change(user2.id, pm.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
PostAlerter.post_created(op)
|
|
|
|
|
2021-12-10 21:32:15 +08:00
|
|
|
starting_count = Notification.where(
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
user_id: user2.id,
|
|
|
|
notification_type: Notification.types[:group_message_summary]
|
2021-12-10 21:32:15 +08:00
|
|
|
).pluck("data::json ->> 'inbox_count'").last.to_i
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
|
|
|
|
another_pm = Fabricate(:topic, archetype: 'private_message', category_id: nil, allowed_groups: [group])
|
|
|
|
another_post = Fabricate(:post, user: another_pm.user, topic: another_pm)
|
|
|
|
TopicUser.change(user2.id, another_pm.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
|
2021-12-06 23:31:44 +08:00
|
|
|
message_data = MessageBus.track_publish("/notification/#{user2.id}") do
|
|
|
|
PostAlerter.post_created(another_post)
|
|
|
|
end.first.data
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
|
2021-12-10 21:32:15 +08:00
|
|
|
expect(Notification.where(user: user2).count).to eq(1)
|
2021-12-06 23:31:44 +08:00
|
|
|
expect(message_data.dig(:last_notification, :notification, :data, :inbox_count)).to eq(starting_count + 1)
|
|
|
|
expect(message_data[:unread_notifications]).to eq(1)
|
REFACTOR: Improve support for consolidating notifications. (#14904)
* REFACTOR: Improve support for consolidating notifications.
Before this commit, we didn't have a single way of consolidating notifications. For notifications like group summaries, we manually removed old ones before creating a new one. On the other hand, we used an after_create callback for likes and group membership requests, which caused unnecessary work, as we need to delete the record we created to replace it with a consolidated one.
We now have all the consolidation rules centralized in a single place: the consolidation planner class. Other parts of the app looking to create a consolidable notification can do so by calling Notification#consolidate_or_save!, instead of the default Notification#create! method.
Finally, we added two more rules: one for re-using existing group summaries and another for deleting duplicated dashboard problems PMs notifications when the user is tracking the moderator's inbox. Setting the threshold to one forces the planner to apply this rule every time.
I plan to add plugin support for adding custom rules in another PR to keep this one relatively small.
* DEV: Introduces a plugin API for consolidating notifications.
This commit removes the `Notification#filter_by_consolidation_data` scope since plugins could have to define their criteria. The Plan class now receives two blocks, one to query for an already consolidated notification, which we'll try to update, and another to query for existing ones to consolidate.
It also receives a consolidation window, which accepts an ActiveSupport::Duration object, and filter notifications created since that value.
2021-12-01 00:36:14 +08:00
|
|
|
end
|
2021-12-15 20:07:39 +08:00
|
|
|
|
|
|
|
it 'sends a PM notification when replying to a member tracking the topic' do
|
|
|
|
group.add(user1)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: pm, user: user1)
|
|
|
|
TopicUser.change(user1.id, pm.id, notification_level: TopicUser.notification_levels[:tracking])
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: 'this is a reply to your post...', topic: pm, user: user2,
|
|
|
|
reply_to_post_number: post.post_number
|
|
|
|
)
|
|
|
|
}.to change(
|
|
|
|
user1.notifications.where(notification_type: Notification.types[:private_message]),
|
|
|
|
:count
|
|
|
|
).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies a group member if someone replies to their post' do
|
|
|
|
group.add(user1)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: pm, user: user1)
|
|
|
|
TopicUser.change(user1.id, pm.id, notification_level: TopicUser.notification_levels[:regular])
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: 'this is a reply to your post...', topic: pm, user: user2,
|
|
|
|
reply_to_post_number: post.post_number
|
|
|
|
)
|
|
|
|
}.to change(user1.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
2022-03-11 18:57:47 +08:00
|
|
|
it 'notifies a group member if someone quotes their post' do
|
2021-12-15 20:07:39 +08:00
|
|
|
group.add(user1)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: pm, user: user1)
|
|
|
|
TopicUser.change(user1.id, pm.id, notification_level: TopicUser.notification_levels[:regular])
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
quote_raw = <<~MD
|
2021-12-15 20:07:39 +08:00
|
|
|
[quote="#{user1.username}, post:1, topic:#{pm.id}"]#{post.raw}[/quote]
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
MD
|
2021-12-15 20:07:39 +08:00
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote_raw, topic: pm, user: user2,
|
|
|
|
)
|
|
|
|
}.to change(user1.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "Doesn't notify non-admin users when their post is quoted inside a whisper" do
|
|
|
|
group.add(admin)
|
|
|
|
|
|
|
|
TopicUser.change(user2.id, pm.id, notification_level: TopicUser.notification_levels[:regular])
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
quote_raw = <<~MD
|
2021-12-15 20:07:39 +08:00
|
|
|
[quote="#{user2.username}, post:1, topic:#{pm.id}"]#{op.raw}[/quote]
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
MD
|
2021-12-15 20:07:39 +08:00
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote_raw, topic: pm, user: admin, post_type: Post.types[:whisper]
|
|
|
|
)
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(user2.notifications, :count)
|
2021-12-15 20:07:39 +08:00
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
2016-03-22 11:28:14 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with unread" do
|
2015-10-20 04:31:48 +08:00
|
|
|
it "does not return whispers as unread posts" do
|
2015-11-30 14:03:47 +08:00
|
|
|
_whisper = Fabricate(:post, raw: 'this is a whisper post',
|
2021-12-16 01:41:14 +08:00
|
|
|
user: admin,
|
|
|
|
topic: post.topic,
|
|
|
|
reply_to_post_number: post.post_number,
|
2015-10-20 04:31:48 +08:00
|
|
|
post_type: Post.types[:whisper])
|
|
|
|
|
2021-12-16 01:41:14 +08:00
|
|
|
expect(PostAlerter.new.first_unread_post(post.user, post.topic)).to be_blank
|
2015-10-20 04:31:48 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with edits' do
|
2016-03-03 13:00:14 +08:00
|
|
|
it 'notifies correctly on edits' do
|
2019-05-08 16:07:14 +08:00
|
|
|
Jobs.run_immediately!
|
2016-12-22 13:46:22 +08:00
|
|
|
PostActionNotifier.enable
|
2015-06-19 10:31:36 +08:00
|
|
|
|
|
|
|
post = Fabricate(:post, raw: 'I love waffles')
|
|
|
|
|
2020-08-31 11:07:18 +08:00
|
|
|
expect do
|
|
|
|
post.revise(admin, raw: 'I made a revision')
|
|
|
|
end.to add_notification(post.user, :edited)
|
2015-06-19 10:31:36 +08:00
|
|
|
|
2020-05-04 15:40:09 +08:00
|
|
|
# lets also like this post which should trigger a notification
|
2020-08-31 11:07:18 +08:00
|
|
|
expect do
|
|
|
|
PostActionCreator.new(
|
|
|
|
admin,
|
|
|
|
post,
|
|
|
|
PostActionType.types[:like]
|
|
|
|
).perform
|
|
|
|
end.to add_notification(post.user, :liked)
|
2020-05-04 15:40:09 +08:00
|
|
|
|
|
|
|
# skip this notification cause we already notified on an edit by the same user
|
|
|
|
# in the previous edit
|
2017-07-24 21:17:42 +08:00
|
|
|
freeze_time 2.hours.from_now
|
2020-08-31 11:07:18 +08:00
|
|
|
|
|
|
|
expect do
|
|
|
|
post.revise(admin, raw: 'I made another revision')
|
|
|
|
end.to_not change { Notification.count }
|
2015-06-19 10:31:36 +08:00
|
|
|
|
2020-05-04 15:55:00 +08:00
|
|
|
# this we do not skip cause 1 day has passed
|
|
|
|
freeze_time 23.hours.from_now
|
|
|
|
|
2020-08-31 11:07:18 +08:00
|
|
|
expect do
|
|
|
|
post.revise(admin, raw: 'I made another revision xyz')
|
|
|
|
end.to add_notification(post.user, :edited)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post.revise(Fabricate(:admin), raw: 'I made a revision')
|
|
|
|
end.to add_notification(post.user, :edited)
|
2016-03-03 13:00:14 +08:00
|
|
|
|
2017-07-24 21:17:42 +08:00
|
|
|
freeze_time 2.hours.from_now
|
2016-03-03 13:00:14 +08:00
|
|
|
|
2020-08-31 11:07:18 +08:00
|
|
|
expect do
|
|
|
|
post.revise(admin, raw: 'I made another revision')
|
|
|
|
end.to add_notification(post.user, :edited)
|
2016-03-03 13:00:14 +08:00
|
|
|
end
|
2018-04-07 05:37:29 +08:00
|
|
|
|
|
|
|
it 'notifies flaggers when flagged post gets unhidden by edit' do
|
|
|
|
post = create_post
|
|
|
|
|
|
|
|
PostActionNotifier.enable
|
2019-05-25 02:13:03 +08:00
|
|
|
Reviewable.set_priorities(high: 4.0)
|
|
|
|
SiteSetting.hide_post_sensitivity = Reviewable.sensitivity[:low]
|
2018-04-07 05:37:29 +08:00
|
|
|
|
2019-01-04 01:03:01 +08:00
|
|
|
PostActionCreator.spam(evil_trout, post)
|
|
|
|
PostActionCreator.spam(walterwhite, post)
|
2018-04-07 05:37:29 +08:00
|
|
|
|
|
|
|
post.reload
|
|
|
|
expect(post.hidden).to eq(true)
|
|
|
|
|
|
|
|
expect {
|
|
|
|
post.revise(post.user, raw: post.raw + " ha I edited it ")
|
|
|
|
}.to add_notification(evil_trout, :edited)
|
|
|
|
.and add_notification(walterwhite, :edited)
|
|
|
|
|
|
|
|
post.reload
|
|
|
|
expect(post.hidden).to eq(false)
|
|
|
|
|
|
|
|
notification = walterwhite.notifications.last
|
|
|
|
expect(notification.topic_id).to eq(post.topic.id)
|
|
|
|
expect(notification.post_number).to eq(post.post_number)
|
|
|
|
expect(notification.data_hash["display_username"]).to eq(post.user.username)
|
|
|
|
|
2019-01-04 01:03:01 +08:00
|
|
|
PostActionCreator.create(coding_horror, post, :spam)
|
|
|
|
PostActionCreator.create(walterwhite, post, :off_topic)
|
2018-04-07 05:37:29 +08:00
|
|
|
|
|
|
|
post.reload
|
|
|
|
expect(post.hidden).to eq(true)
|
|
|
|
|
|
|
|
expect {
|
|
|
|
post.revise(post.user, raw: post.raw + " ha I edited it again ")
|
|
|
|
}.to not_add_notification(evil_trout, :edited)
|
|
|
|
.and not_add_notification(coding_horror, :edited)
|
|
|
|
.and not_add_notification(walterwhite, :edited)
|
|
|
|
end
|
2016-03-03 13:00:14 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with quotes' do
|
2021-12-16 01:41:14 +08:00
|
|
|
fab!(:category) { Fabricate(:category) }
|
|
|
|
fab!(:topic) { Fabricate(:topic, category: category) }
|
2014-03-18 12:22:39 +08:00
|
|
|
|
2015-03-24 08:55:22 +08:00
|
|
|
it 'does not notify for muted users' do
|
2022-06-10 00:52:28 +08:00
|
|
|
post = Fabricate(:post, raw: '[quote="Eviltrout, post:1"]whatup[/quote]', topic: topic)
|
2015-03-24 08:55:22 +08:00
|
|
|
MutedUser.create!(user_id: evil_trout.id, muted_user_id: post.user_id)
|
|
|
|
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2015-03-24 08:55:22 +08:00
|
|
|
PostAlerter.post_created(post)
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2015-03-24 08:55:22 +08:00
|
|
|
end
|
|
|
|
|
2019-03-21 19:15:34 +08:00
|
|
|
it 'does not notify for ignored users' do
|
2020-02-14 13:41:42 +08:00
|
|
|
post = Fabricate(:post, raw: '[quote="EvilTrout, post:1"]whatup[/quote]', topic: topic)
|
2020-11-03 20:38:54 +08:00
|
|
|
Fabricate(:ignored_user, user: evil_trout, ignored_user: post.user)
|
2019-03-21 19:15:34 +08:00
|
|
|
|
|
|
|
expect {
|
|
|
|
PostAlerter.post_created(post)
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2019-03-21 19:15:34 +08:00
|
|
|
end
|
|
|
|
|
2020-02-14 13:41:42 +08:00
|
|
|
it 'does not notify for users with new reply notification' do
|
2022-06-10 00:52:28 +08:00
|
|
|
post = Fabricate(:post, raw: '[quote="eviltRout, post:1"]whatup[/quote]', topic: topic)
|
2020-02-14 13:41:42 +08:00
|
|
|
notification = Notification.create!(topic: post.topic,
|
|
|
|
post_number: post.post_number,
|
|
|
|
read: false,
|
|
|
|
notification_type: Notification.types[:replied],
|
|
|
|
user: evil_trout,
|
|
|
|
data: { topic_title: "test topic" }.to_json
|
|
|
|
)
|
|
|
|
expect {
|
2020-05-04 15:40:09 +08:00
|
|
|
PostAlerter.post_edited(post)
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2018-05-25 11:59:29 +08:00
|
|
|
|
2020-02-14 13:41:42 +08:00
|
|
|
notification.destroy
|
|
|
|
expect {
|
2020-05-04 15:40:09 +08:00
|
|
|
PostAlerter.post_edited(post)
|
2020-02-14 13:41:42 +08:00
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not collapse quote notifications' do
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2018-05-25 11:59:29 +08:00
|
|
|
2.times do
|
|
|
|
create_post_with_alerts(
|
2022-06-10 00:52:28 +08:00
|
|
|
raw: '[quote="eviltrout, post:1"]whatup[/quote]',
|
2018-05-25 11:59:29 +08:00
|
|
|
topic: topic
|
|
|
|
)
|
|
|
|
end
|
2019-06-28 06:20:43 +08:00
|
|
|
}.to change(evil_trout.notifications, :count).by(2)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "won't notify the user a second time on revision" do
|
|
|
|
p1 = create_post_with_alerts(raw: '[quote="Evil Trout, post:1"]whatup[/quote]')
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2014-10-28 05:06:43 +08:00
|
|
|
p1.revise(p1.user, raw: '[quote="Evil Trout, post:1"]whatup now?[/quote]')
|
2015-04-25 23:18:35 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't notify the poster" do
|
|
|
|
topic = create_post_with_alerts.topic
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2014-03-18 12:22:39 +08:00
|
|
|
Fabricate(:post, topic: topic, user: topic.user, raw: '[quote="Bruce Wayne, post:1"]whatup[/quote]')
|
2015-04-25 23:18:35 +08:00
|
|
|
}.not_to change(topic.user.notifications, :count)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
|
|
|
it "triggers :before_create_notifications_for_users" do
|
2022-06-10 00:52:28 +08:00
|
|
|
post = Fabricate(:post, raw: '[quote="eviltrout, post:1"]whatup[/quote]')
|
2017-07-20 04:51:32 +08:00
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[evil_trout], post])
|
|
|
|
end
|
2022-06-10 00:52:28 +08:00
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with notifications when prioritizing full names" do
|
2022-06-10 00:52:28 +08:00
|
|
|
before do
|
|
|
|
SiteSetting.prioritize_username_in_ux = false
|
|
|
|
SiteSetting.display_name_on_posts = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sends to correct user' do
|
|
|
|
quote = <<~MD
|
|
|
|
[quote="#{evil_trout.name}, post:1, username:#{evil_trout.username}"]whatup[/quote]
|
|
|
|
MD
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote,
|
|
|
|
topic: topic
|
|
|
|
)
|
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sends to correct users when nested quotes with multiple users' do
|
|
|
|
quote = <<~MD
|
|
|
|
[quote="#{evil_trout.name}, post:1, username:#{evil_trout.username}"]this [quote="#{walterwhite.name}, post:2, username:#{walterwhite.username}"]whatup[/quote][/quote]
|
|
|
|
MD
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote,
|
|
|
|
topic: topic
|
|
|
|
)
|
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
.and change(walterwhite.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sends to correct users when multiple quotes' do
|
|
|
|
user = Fabricate(:user)
|
|
|
|
quote = <<~MD
|
|
|
|
[quote="#{evil_trout.name}, post:1, username:#{evil_trout.username}"]"username:#{user.username}" [/quote]/n [quote="#{walterwhite.name}, post:2, username:#{walterwhite.username}"]whatup[/quote]
|
|
|
|
MD
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote,
|
|
|
|
topic: topic
|
|
|
|
)
|
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
.and change(walterwhite.notifications, :count).by(1)
|
2022-07-19 22:03:03 +08:00
|
|
|
.and not_change(user.notifications, :count)
|
2022-06-10 00:52:28 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "sends to correct user when user has a full name that matches another user's username" do
|
|
|
|
user_with_matching_full_name = Fabricate(:user, name: evil_trout.username)
|
|
|
|
quote = <<~MD
|
|
|
|
[quote="#{user_with_matching_full_name.name}, post:1, username:#{user_with_matching_full_name.username}"]this [/quote]
|
|
|
|
MD
|
|
|
|
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(
|
|
|
|
raw: quote,
|
|
|
|
topic: topic
|
|
|
|
)
|
|
|
|
}.to change(user_with_matching_full_name.notifications, :count).by(1)
|
2022-07-19 22:03:03 +08:00
|
|
|
.and not_change(evil_trout.notifications, :count)
|
2022-06-10 00:52:28 +08:00
|
|
|
end
|
|
|
|
end
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with linked' do
|
2017-07-20 04:51:32 +08:00
|
|
|
let(:post1) { create_post }
|
|
|
|
let(:user) { post1.user }
|
|
|
|
let(:linking_post) { create_post(raw: "my magic topic\n##{Discourse.base_url}#{post1.url}") }
|
|
|
|
|
2018-05-31 15:53:49 +08:00
|
|
|
before do
|
2019-03-14 22:47:38 +08:00
|
|
|
Jobs.run_immediately!
|
2018-05-31 15:53:49 +08:00
|
|
|
end
|
|
|
|
|
2014-03-19 09:07:48 +08:00
|
|
|
it "will notify correctly on linking" do
|
2017-07-20 04:51:32 +08:00
|
|
|
linking_post
|
2014-03-19 09:07:48 +08:00
|
|
|
|
2015-04-25 23:18:35 +08:00
|
|
|
expect(user.notifications.count).to eq(1)
|
2014-03-19 09:07:48 +08:00
|
|
|
|
2015-12-31 07:51:58 +08:00
|
|
|
watcher = Fabricate(:user)
|
|
|
|
TopicUser.create!(user_id: watcher.id, topic_id: topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
create_post(topic_id: topic.id, user: user, raw: "my magic topic\n##{Discourse.base_url}#{post1.url}")
|
2014-03-19 09:07:48 +08:00
|
|
|
|
|
|
|
user.reload
|
2016-04-13 02:09:59 +08:00
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:linked]).count).to eq(1)
|
2014-07-29 13:40:05 +08:00
|
|
|
|
2015-12-31 07:51:58 +08:00
|
|
|
expect(watcher.notifications.count).to eq(1)
|
|
|
|
|
2014-07-29 13:40:05 +08:00
|
|
|
# don't notify on reflection
|
|
|
|
post1.reload
|
2015-04-25 23:18:35 +08:00
|
|
|
expect(PostAlerter.new.extract_linked_users(post1).length).to eq(0)
|
2014-03-19 09:07:48 +08:00
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
linking_post
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user], linking_post])
|
|
|
|
end
|
2020-01-17 02:17:16 +08:00
|
|
|
|
2020-01-23 03:33:25 +08:00
|
|
|
it "doesn't notify the linked user if the user is staged and the category is restricted and allows strangers" do
|
2020-01-17 02:17:16 +08:00
|
|
|
staged_user = Fabricate(:staged)
|
|
|
|
group_member = Fabricate(:user)
|
|
|
|
group.add(group_member)
|
|
|
|
|
|
|
|
private_category = Fabricate(
|
|
|
|
:private_category, group: group,
|
|
|
|
email_in: 'test@test.com', email_in_allow_strangers: true
|
|
|
|
)
|
|
|
|
|
|
|
|
staged_user_post = create_post(user: staged_user, category: private_category)
|
|
|
|
|
|
|
|
linking = create_post(
|
|
|
|
user: group_member,
|
|
|
|
category: private_category,
|
|
|
|
raw: "my magic topic\n##{Discourse.base_url}#{staged_user_post.url}")
|
|
|
|
|
|
|
|
staged_user.reload
|
|
|
|
expect(staged_user.notifications.where(notification_type: Notification.types[:linked]).count).to eq(0)
|
|
|
|
end
|
2014-03-19 09:07:48 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with @here' do
|
2021-11-24 04:25:54 +08:00
|
|
|
let(:post) { create_post_with_alerts(raw: "Hello @here how are you?", user: tl2_user, topic: topic) }
|
2021-12-16 01:41:14 +08:00
|
|
|
fab!(:other_post) { Fabricate(:post, topic: topic) }
|
2021-11-24 04:25:54 +08:00
|
|
|
|
|
|
|
before do
|
|
|
|
Jobs.run_immediately!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not notify unrelated users' do
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { post }.not_to change(evil_trout.notifications, :count)
|
2021-11-24 04:25:54 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not work if user here exists' do
|
|
|
|
Fabricate(:user, username: SiteSetting.here_mention)
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { post }.not_to change(other_post.user.notifications, :count)
|
2021-11-24 04:25:54 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies users who replied' do
|
|
|
|
post2 = Fabricate(:post, topic: topic, post_type: Post.types[:whisper])
|
|
|
|
post3 = Fabricate(:post, topic: topic)
|
|
|
|
|
|
|
|
expect { post }
|
|
|
|
.to change(other_post.user.notifications, :count).by(1)
|
2022-07-19 22:03:03 +08:00
|
|
|
.and not_change(post2.user.notifications, :count)
|
2021-11-24 04:25:54 +08:00
|
|
|
.and change(post3.user.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies users who whispered' do
|
|
|
|
post2 = Fabricate(:post, topic: topic, post_type: Post.types[:whisper])
|
|
|
|
post3 = Fabricate(:post, topic: topic)
|
|
|
|
|
|
|
|
tl2_user.grant_admin!
|
|
|
|
|
|
|
|
expect { post }
|
|
|
|
.to change(other_post.user.notifications, :count).by(1)
|
|
|
|
.and change(post2.user.notifications, :count).by(1)
|
|
|
|
.and change(post3.user.notifications, :count).by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies only last max_here_mentioned users' do
|
|
|
|
SiteSetting.max_here_mentioned = 2
|
|
|
|
3.times { Fabricate(:post, topic: topic) }
|
|
|
|
expect { post }.to change { Notification.count }.by(2)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with @group mentions' do
|
2015-11-30 14:03:47 +08:00
|
|
|
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:group) { Fabricate(:group, name: 'group', mentionable_level: Group::ALIAS_LEVELS[:everyone]) }
|
2017-07-20 04:51:32 +08:00
|
|
|
let(:post) { create_post_with_alerts(raw: "Hello @group how are you?") }
|
|
|
|
before { group.add(evil_trout) }
|
2015-11-30 14:03:47 +08:00
|
|
|
|
2017-07-20 04:51:32 +08:00
|
|
|
it 'notifies users correctly' do
|
2015-11-30 14:03:47 +08:00
|
|
|
expect {
|
2017-07-20 04:51:32 +08:00
|
|
|
post
|
2015-11-30 14:03:47 +08:00
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
|
2015-12-01 13:52:43 +08:00
|
|
|
expect(GroupMention.count).to eq(1)
|
2015-11-30 14:03:47 +08:00
|
|
|
|
2017-08-29 00:32:08 +08:00
|
|
|
Fabricate(:group, name: 'group-alt', mentionable_level: Group::ALIAS_LEVELS[:everyone])
|
2015-11-30 14:03:47 +08:00
|
|
|
|
|
|
|
expect {
|
2016-02-24 03:57:54 +08:00
|
|
|
create_post_with_alerts(raw: "Hello, @group-alt should not trigger a notification?")
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2015-12-01 13:52:43 +08:00
|
|
|
|
|
|
|
expect(GroupMention.count).to eq(2)
|
2016-02-24 03:57:54 +08:00
|
|
|
|
2017-08-29 00:32:08 +08:00
|
|
|
group.update_columns(mentionable_level: Group::ALIAS_LEVELS[:members_mods_and_admins])
|
2016-02-24 03:57:54 +08:00
|
|
|
expect {
|
|
|
|
create_post_with_alerts(raw: "Hello @group you are not mentionable")
|
2022-07-19 22:03:03 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2016-02-24 03:57:54 +08:00
|
|
|
|
|
|
|
expect(GroupMention.count).to eq(3)
|
2019-07-09 05:12:09 +08:00
|
|
|
|
|
|
|
group.update_columns(mentionable_level: Group::ALIAS_LEVELS[:owners_mods_and_admins])
|
|
|
|
group.add_owner(user)
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(raw: "Hello @group the owner can mention you", user: user)
|
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
|
|
|
|
expect(GroupMention.count).to eq(4)
|
2015-11-30 14:03:47 +08:00
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
2021-03-17 05:20:41 +08:00
|
|
|
it 'takes private mention as precedence' do
|
|
|
|
expect {
|
|
|
|
create_post_with_alerts(raw: "Hello @group and @eviltrout, nice to meet you")
|
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
|
|
|
expect(evil_trout.notifications.last.notification_type).to eq(Notification.types[:mentioned])
|
|
|
|
end
|
|
|
|
|
2017-07-20 04:51:32 +08:00
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
post
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[evil_trout], post])
|
|
|
|
end
|
2015-11-30 14:03:47 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context 'with @mentions' do
|
2014-03-18 12:22:39 +08:00
|
|
|
|
|
|
|
let(:mention_post) { create_post_with_alerts(user: user, raw: 'Hello @eviltrout') }
|
|
|
|
let(:topic) { mention_post.topic }
|
|
|
|
|
2018-05-31 15:53:49 +08:00
|
|
|
before do
|
2019-03-14 22:47:38 +08:00
|
|
|
Jobs.run_immediately!
|
2018-05-31 15:53:49 +08:00
|
|
|
end
|
|
|
|
|
2014-03-18 12:22:39 +08:00
|
|
|
it 'notifies a user' do
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2014-03-18 12:22:39 +08:00
|
|
|
mention_post
|
2015-04-25 23:18:35 +08:00
|
|
|
}.to change(evil_trout.notifications, :count).by(1)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "won't notify the user a second time on revision" do
|
|
|
|
mention_post
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2014-10-28 05:06:43 +08:00
|
|
|
mention_post.revise(mention_post.user, raw: "New raw content that still mentions @eviltrout")
|
2015-04-25 23:18:35 +08:00
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't notify the user who created the topic in regular mode" do
|
|
|
|
topic.notify_regular!(user)
|
|
|
|
mention_post
|
2015-04-25 23:18:35 +08:00
|
|
|
expect {
|
2014-03-18 12:22:39 +08:00
|
|
|
create_post_with_alerts(user: user, raw: 'second post', topic: topic)
|
2015-04-25 23:18:35 +08:00
|
|
|
}.not_to change(user.notifications, :count)
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
|
|
|
|
2017-07-20 04:51:32 +08:00
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
mention_post
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[evil_trout], mention_post])
|
|
|
|
end
|
|
|
|
|
2018-03-08 18:40:48 +08:00
|
|
|
it "notification comes from editor if mention is added later" do
|
2021-12-16 01:41:14 +08:00
|
|
|
post = create_post_with_alerts(user: user, raw: 'No mention here.')
|
|
|
|
expect {
|
|
|
|
post.revise(admin, raw: "Mention @eviltrout in this edit.")
|
|
|
|
}.to change(evil_trout.notifications, :count)
|
|
|
|
n = evil_trout.notifications.last
|
|
|
|
expect(n.data_hash["original_username"]).to eq(admin.username)
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
|
|
|
|
2021-05-21 09:43:47 +08:00
|
|
|
it "doesn't notify the last post editor if they mention themselves" do
|
2018-04-16 17:48:06 +08:00
|
|
|
post = create_post_with_alerts(user: user, raw: 'Post without a mention.')
|
|
|
|
expect {
|
|
|
|
post.revise(evil_trout, raw: "O hai, @eviltrout!")
|
|
|
|
}.not_to change(evil_trout.notifications, :count)
|
|
|
|
end
|
|
|
|
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:alice) { Fabricate(:user, username: 'alice') }
|
|
|
|
fab!(:bob) { Fabricate(:user, username: 'bob') }
|
|
|
|
fab!(:carol) { Fabricate(:admin, username: 'carol') }
|
|
|
|
fab!(:dave) { Fabricate(:user, username: 'dave') }
|
|
|
|
fab!(:eve) { Fabricate(:user, username: 'eve') }
|
|
|
|
fab!(:group) { Fabricate(:group, name: 'group', mentionable_level: Group::ALIAS_LEVELS[:everyone]) }
|
2018-04-12 22:19:44 +08:00
|
|
|
|
|
|
|
before do
|
2018-11-24 01:25:40 +08:00
|
|
|
group.bulk_add([alice.id, eve.id])
|
2018-04-12 22:19:44 +08:00
|
|
|
end
|
2018-03-08 18:40:48 +08:00
|
|
|
|
|
|
|
def create_post_with_alerts(args = {})
|
|
|
|
post = Fabricate(:post, args)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
end
|
|
|
|
|
|
|
|
def set_topic_notification_level(user, topic, level_name)
|
|
|
|
TopicUser.change(user.id, topic.id, notification_level: TopicUser.notification_levels[level_name])
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with topic" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:topic) { Fabricate(:topic, user: alice) }
|
2018-03-08 18:40:48 +08:00
|
|
|
|
|
|
|
[:watching, :tracking, :regular].each do |notification_level|
|
|
|
|
context "when notification level is '#{notification_level}'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, topic, notification_level)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies about @username mention" do
|
|
|
|
args = { user: bob, topic: topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :mentioned)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when notification level is 'muted'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, topic, :muted)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify about @username mention" do
|
|
|
|
args = { user: bob, topic: topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(alice, :mentioned)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with message to users" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:pm_topic) do
|
2018-11-24 01:25:40 +08:00
|
|
|
Fabricate(:private_message_topic,
|
|
|
|
user: alice,
|
|
|
|
topic_allowed_users: [
|
|
|
|
Fabricate.build(:topic_allowed_user, user: alice),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: bob),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: Discourse.system_user)
|
|
|
|
]
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when user is part of conversation" do
|
2018-03-08 18:40:48 +08:00
|
|
|
[:watching, :tracking, :regular].each do |notification_level|
|
|
|
|
context "when notification level is '#{notification_level}'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, pm_topic, notification_level)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies about @username mention" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :mentioned)
|
|
|
|
end
|
2018-04-12 22:19:44 +08:00
|
|
|
|
|
|
|
it "notifies about @username mentions by non-human users" do
|
|
|
|
args = { user: Discourse.system_user, topic: pm_topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :mentioned)
|
|
|
|
end
|
|
|
|
|
2018-11-24 01:25:40 +08:00
|
|
|
it "notifies about @group mention when allowed user is part of group" do
|
2018-04-12 22:19:44 +08:00
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :group_mentioned)
|
|
|
|
end
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when notification level is 'muted'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, pm_topic, :muted)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify about @username mention" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(alice, :mentioned)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-24 01:25:40 +08:00
|
|
|
context "when user is not part of conversation" do
|
|
|
|
it "does not notify about @username mention even though mentioned user is an admin" do
|
2018-03-08 18:40:48 +08:00
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @carol' }
|
2018-11-24 01:25:40 +08:00
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(carol, :mentioned)
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
|
|
|
|
2018-11-24 01:25:40 +08:00
|
|
|
it "does not notify about @username mention by non-human user even though mentioned user is an admin" do
|
2018-04-12 22:19:44 +08:00
|
|
|
args = { user: Discourse.system_user, topic: pm_topic, raw: 'Hello @carol' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(carol, :mentioned)
|
|
|
|
end
|
|
|
|
|
2018-03-08 18:40:48 +08:00
|
|
|
it "does not notify about @username mention when mentioned user is not allowed to see message" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @dave' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(dave, :mentioned)
|
|
|
|
end
|
2018-04-12 22:19:44 +08:00
|
|
|
|
2018-11-24 01:25:40 +08:00
|
|
|
it "does not notify about @group mention when user is not an allowed user" do
|
2018-04-12 22:19:44 +08:00
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @group' }
|
2018-11-24 01:25:40 +08:00
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(eve, :group_mentioned)
|
2018-04-12 22:19:44 +08:00
|
|
|
end
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with message to group" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:some_group) { Fabricate(:group, name: 'some_group', mentionable_level: Group::ALIAS_LEVELS[:everyone]) }
|
|
|
|
fab!(:pm_topic) do
|
2018-11-24 01:25:40 +08:00
|
|
|
Fabricate(:private_message_topic,
|
|
|
|
user: alice,
|
|
|
|
topic_allowed_groups: [
|
|
|
|
Fabricate.build(:topic_allowed_group, group: group)
|
|
|
|
],
|
|
|
|
topic_allowed_users: [
|
|
|
|
Fabricate.build(:topic_allowed_user, user: Discourse.system_user)
|
|
|
|
]
|
|
|
|
)
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
|
|
|
|
2018-04-12 22:19:44 +08:00
|
|
|
before do
|
2018-11-24 01:25:40 +08:00
|
|
|
some_group.bulk_add([alice.id, carol.id])
|
2018-04-12 22:19:44 +08:00
|
|
|
end
|
|
|
|
|
2018-11-24 01:25:40 +08:00
|
|
|
context "when group is part of conversation" do
|
|
|
|
[:watching, :tracking, :regular].each do |notification_level|
|
|
|
|
context "when notification level is '#{notification_level}'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, pm_topic, notification_level)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies about @group mention" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :group_mentioned)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies about @group mentions by non-human users" do
|
|
|
|
args = { user: Discourse.system_user, topic: pm_topic, raw: 'Hello @group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :group_mentioned)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies about @username mention when user belongs to allowed group" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @alice' }
|
|
|
|
expect { create_post_with_alerts(args) }.to add_notification(alice, :mentioned)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when notification level is 'muted'" do
|
|
|
|
before do
|
|
|
|
set_topic_notification_level(alice, pm_topic, :muted)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify about @group mention" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(alice, :group_mentioned)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when group is not part of conversation" do
|
|
|
|
it "does not notify about @group mention even though mentioned user is an admin" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @some_group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(carol, :group_mentioned)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify about @group mention by non-human user even though mentioned user is an admin" do
|
|
|
|
args = { user: Discourse.system_user, topic: pm_topic, raw: 'Hello @some_group' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(carol, :group_mentioned)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify about @username mention when user doesn't belong to allowed group" do
|
|
|
|
args = { user: bob, topic: pm_topic, raw: 'Hello @dave' }
|
|
|
|
expect { create_post_with_alerts(args) }.to_not add_notification(dave, :mentioned)
|
|
|
|
end
|
|
|
|
end
|
2018-03-08 18:40:48 +08:00
|
|
|
end
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|
2016-02-23 08:34:16 +08:00
|
|
|
|
|
|
|
describe ".create_notification" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:topic) { Fabricate(:private_message_topic, user: user, created_at: 1.hour.ago) }
|
|
|
|
fab!(:post) { Fabricate(:post, topic: topic, created_at: 1.hour.ago) }
|
2019-05-16 00:47:36 +08:00
|
|
|
let(:type) { Notification.types[:private_message] }
|
2016-02-23 08:34:16 +08:00
|
|
|
|
2016-02-24 22:34:40 +08:00
|
|
|
it "creates a notification for PMs" do
|
|
|
|
post.revise(user, { raw: 'This is the revised post' }, revised_at: Time.zone.now)
|
|
|
|
|
|
|
|
expect {
|
2019-05-16 00:47:36 +08:00
|
|
|
PostAlerter.new.create_notification(user, type, post)
|
2016-02-24 22:34:40 +08:00
|
|
|
}.to change { user.notifications.count }.by(1)
|
2016-02-23 08:34:16 +08:00
|
|
|
|
2016-02-24 22:34:40 +08:00
|
|
|
expect(user.notifications.last.data_hash["topic_title"]).to eq(topic.title)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "keeps the original title for PMs" do
|
2016-02-23 08:34:16 +08:00
|
|
|
original_title = topic.title
|
|
|
|
|
|
|
|
post.revise(user, { title: "This is the revised title" }, revised_at: Time.now)
|
|
|
|
|
|
|
|
expect {
|
2019-05-16 00:47:36 +08:00
|
|
|
PostAlerter.new.create_notification(user, type, post)
|
2016-02-24 22:34:40 +08:00
|
|
|
}.to change { user.notifications.count }.by(1)
|
2016-02-23 08:34:16 +08:00
|
|
|
|
|
|
|
expect(user.notifications.last.data_hash["topic_title"]).to eq(original_title)
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
2019-05-16 00:47:36 +08:00
|
|
|
it "triggers :pre_notification_alert" do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.new.create_notification(user, type, post)
|
|
|
|
end
|
|
|
|
|
|
|
|
payload = {
|
|
|
|
notification_type: type,
|
|
|
|
post_number: post.post_number,
|
|
|
|
topic_title: post.topic.title,
|
|
|
|
topic_id: post.topic.id,
|
|
|
|
excerpt: post.excerpt(400, text_entities: true, strip_links: true, remap_emoji: true),
|
|
|
|
username: post.username,
|
|
|
|
post_url: post.url
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(events).to include(event_name: :pre_notification_alert, params: [user, payload])
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not alert when revising and changing notification type" do
|
|
|
|
PostAlerter.new.create_notification(user, type, post)
|
|
|
|
|
|
|
|
post.revise(user, { raw: "Editing post to fake include a mention of @eviltrout" }, revised_at: Time.now)
|
|
|
|
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.new.create_notification(user, Notification.types[:mentioned], post)
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
2019-05-16 00:47:36 +08:00
|
|
|
payload = {
|
|
|
|
notification_type: type,
|
|
|
|
post_number: post.post_number,
|
|
|
|
topic_title: post.topic.title,
|
|
|
|
topic_id: post.topic.id,
|
|
|
|
excerpt: post.excerpt(400, text_entities: true, strip_links: true, remap_emoji: true),
|
|
|
|
username: post.username,
|
|
|
|
post_url: post.url
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(events).not_to include(event_name: :pre_notification_alert, params: [user, payload])
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "triggers :before_create_notification" do
|
|
|
|
type = Notification.types[:private_message]
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.new.create_notification(user, type, post, {})
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notification, params: [user, type, post, {}])
|
|
|
|
end
|
2016-02-23 08:34:16 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
describe ".push_notification" do
|
2016-10-11 10:03:21 +08:00
|
|
|
let(:mention_post) { create_post_with_alerts(user: user, raw: 'Hello @eviltrout :heart:') }
|
2016-08-26 10:47:10 +08:00
|
|
|
let(:topic) { mention_post.topic }
|
2022-07-28 00:14:14 +08:00
|
|
|
|
2021-11-04 01:21:33 +08:00
|
|
|
before do
|
2017-04-05 20:28:24 +08:00
|
|
|
SiteSetting.allowed_user_api_push_urls = "https://site.com/push|https://site2.com/push"
|
|
|
|
2.times do |i|
|
|
|
|
UserApiKey.create!(user_id: evil_trout.id,
|
|
|
|
client_id: "xxx#{i}",
|
|
|
|
application_name: "iPhone#{i}",
|
2020-09-29 17:57:48 +08:00
|
|
|
scopes: ['notifications'].map { |name| UserApiKeyScope.new(name: name) },
|
2017-04-05 20:28:24 +08:00
|
|
|
push_url: "https://site2.com/push")
|
|
|
|
end
|
2021-11-04 01:21:33 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "DiscoursePluginRegistry#push_notification_filters" do
|
|
|
|
it "sends push notifications when all filters pass" do
|
|
|
|
Plugin::Instance.new.register_push_notification_filter do |user, payload|
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
expect { mention_post }.to change { Jobs::PushNotification.jobs.count }.by(1)
|
|
|
|
DiscoursePluginRegistry.reset!
|
|
|
|
end
|
2017-04-05 20:28:24 +08:00
|
|
|
|
2021-11-04 01:21:33 +08:00
|
|
|
it "does not send push notifications when a filters returns false" do
|
|
|
|
Plugin::Instance.new.register_push_notification_filter do |user, payload|
|
|
|
|
false
|
|
|
|
end
|
|
|
|
expect { mention_post }.not_to change { Jobs::PushNotification.jobs.count }
|
|
|
|
DiscoursePluginRegistry.reset!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it "pushes nothing to suspended users" do
|
|
|
|
evil_trout.update_columns(suspended_till: 1.year.from_now)
|
2017-06-16 08:08:15 +08:00
|
|
|
expect { mention_post }.to_not change { Jobs::PushNotification.jobs.count }
|
2017-04-05 20:28:24 +08:00
|
|
|
end
|
|
|
|
|
2020-12-18 23:03:51 +08:00
|
|
|
it "pushes nothing when the user is in 'do not disturb'" do
|
|
|
|
Fabricate(:do_not_disturb_timing, user: evil_trout, starts_at: Time.zone.now, ends_at: 1.day.from_now)
|
|
|
|
|
|
|
|
expect { mention_post }.to_not change { Jobs::PushNotification.jobs.count }
|
|
|
|
end
|
|
|
|
|
2016-08-26 10:47:10 +08:00
|
|
|
it "correctly pushes notifications if configured correctly" do
|
2019-03-14 22:47:38 +08:00
|
|
|
Jobs.run_immediately!
|
2016-09-04 13:50:53 +08:00
|
|
|
body = nil
|
|
|
|
headers = nil
|
2016-08-26 10:47:10 +08:00
|
|
|
|
2019-04-08 22:58:21 +08:00
|
|
|
stub_request(:post, "https://site2.com/push")
|
|
|
|
.to_return do |request|
|
|
|
|
body = request.body
|
|
|
|
headers = request.headers
|
|
|
|
{ status: 200, body: "OK" }
|
|
|
|
end
|
2016-08-26 10:47:10 +08:00
|
|
|
|
2021-03-04 22:07:37 +08:00
|
|
|
set_subfolder "/subpath"
|
2016-09-04 13:50:53 +08:00
|
|
|
payload = {
|
|
|
|
"secret_key" => SiteSetting.push_api_secret_key,
|
|
|
|
"url" => Discourse.base_url,
|
|
|
|
"title" => SiteSetting.title,
|
|
|
|
"description" => SiteSetting.site_description,
|
|
|
|
"notifications" => [
|
|
|
|
{
|
|
|
|
'notification_type' => 1,
|
|
|
|
'post_number' => 1,
|
|
|
|
'topic_title' => topic.title,
|
|
|
|
'topic_id' => topic.id,
|
2016-10-11 10:03:21 +08:00
|
|
|
'excerpt' => 'Hello @eviltrout ❤',
|
2016-09-04 13:50:53 +08:00
|
|
|
'username' => user.username,
|
2021-03-04 22:07:37 +08:00
|
|
|
'url' => UrlHelper.absolute(Discourse.base_path + mention_post.url),
|
2016-09-04 13:50:53 +08:00
|
|
|
'client_id' => 'xxx0'
|
|
|
|
},
|
|
|
|
{
|
|
|
|
'notification_type' => 1,
|
|
|
|
'post_number' => 1,
|
|
|
|
'topic_title' => topic.title,
|
|
|
|
'topic_id' => topic.id,
|
2016-10-11 10:03:21 +08:00
|
|
|
'excerpt' => 'Hello @eviltrout ❤',
|
2016-09-04 13:50:53 +08:00
|
|
|
'username' => user.username,
|
2021-03-04 22:07:37 +08:00
|
|
|
'url' => UrlHelper.absolute(Discourse.base_path + mention_post.url),
|
2016-09-04 13:50:53 +08:00
|
|
|
'client_id' => 'xxx1'
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
|
2018-12-05 13:39:17 +08:00
|
|
|
post = mention_post
|
2017-06-16 08:08:15 +08:00
|
|
|
|
2016-09-04 13:50:53 +08:00
|
|
|
expect(JSON.parse(body)).to eq(payload)
|
2017-06-16 08:08:15 +08:00
|
|
|
expect(headers["Content-Type"]).to eq('application/json')
|
2018-12-05 13:39:17 +08:00
|
|
|
|
|
|
|
TopicUser.change(evil_trout.id, topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: post.topic, user_id: evil_trout.id)
|
|
|
|
user2 = Fabricate(:user)
|
|
|
|
|
|
|
|
# if we collapse a reply notification we should get notified on the correct post
|
|
|
|
new_post = create_post_with_alerts(topic: post.topic, user_id: user.id, reply_to_post_number: post.post_number, raw: 'this is my first reply')
|
|
|
|
|
|
|
|
changes = {
|
|
|
|
"notification_type" => Notification.types[:posted],
|
|
|
|
"post_number" => new_post.post_number,
|
|
|
|
"username" => new_post.user.username,
|
|
|
|
"excerpt" => new_post.raw,
|
2021-03-04 22:07:37 +08:00
|
|
|
"url" => UrlHelper.absolute(Discourse.base_path + new_post.url)
|
2018-12-05 13:39:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
payload["notifications"][0].merge! changes
|
|
|
|
payload["notifications"][1].merge! changes
|
|
|
|
|
|
|
|
expect(JSON.parse(body)).to eq(payload)
|
|
|
|
|
|
|
|
new_post = create_post_with_alerts(topic: post.topic, user_id: user2.id, reply_to_post_number: post.post_number, raw: 'this is my second reply')
|
|
|
|
|
|
|
|
changes = {
|
|
|
|
"post_number" => new_post.post_number,
|
|
|
|
"username" => new_post.user.username,
|
|
|
|
"excerpt" => new_post.raw,
|
2021-03-04 22:07:37 +08:00
|
|
|
"url" => UrlHelper.absolute(Discourse.base_path + new_post.url)
|
2018-12-05 13:39:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
payload["notifications"][0].merge! changes
|
|
|
|
payload["notifications"][1].merge! changes
|
|
|
|
|
|
|
|
expect(JSON.parse(body)).to eq(payload)
|
|
|
|
|
2016-08-26 10:47:10 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
describe ".create_notification_alert" do
|
2021-11-22 11:38:49 +08:00
|
|
|
it "does nothing for suspended users" do
|
2021-10-12 01:55:18 +08:00
|
|
|
evil_trout.update_columns(suspended_till: 1.year.from_now)
|
|
|
|
|
|
|
|
events = nil
|
|
|
|
messages = MessageBus.track_publish do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.create_notification_alert(
|
|
|
|
user: evil_trout,
|
|
|
|
post: post,
|
|
|
|
notification_type: Notification.types[:custom],
|
|
|
|
excerpt: "excerpt",
|
|
|
|
username: "username"
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(events.size).to eq(0)
|
|
|
|
expect(messages.size).to eq(0)
|
|
|
|
expect(Jobs::PushNotification.jobs.size).to eq(0)
|
|
|
|
end
|
2021-11-22 11:38:49 +08:00
|
|
|
|
|
|
|
it "does not publish to MessageBus /notification-alert if the user has not been seen for > 30 days, but still sends a push notification" do
|
|
|
|
evil_trout.update_columns(last_seen_at: 31.days.ago)
|
|
|
|
|
|
|
|
SiteSetting.allowed_user_api_push_urls = "https://site2.com/push"
|
|
|
|
UserApiKey.create!(user_id: evil_trout.id,
|
|
|
|
client_id: "xxx#1",
|
|
|
|
application_name: "iPhone1",
|
|
|
|
scopes: ['notifications'].map { |name| UserApiKeyScope.new(name: name) },
|
|
|
|
push_url: "https://site2.com/push")
|
|
|
|
|
|
|
|
events = nil
|
|
|
|
messages = MessageBus.track_publish do
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.create_notification_alert(
|
|
|
|
user: evil_trout,
|
|
|
|
post: post,
|
|
|
|
notification_type: Notification.types[:custom],
|
|
|
|
excerpt: "excerpt",
|
|
|
|
username: "username"
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(events.size).to eq(2)
|
|
|
|
expect(messages.size).to eq(0)
|
|
|
|
expect(Jobs::PushNotification.jobs.size).to eq(1)
|
|
|
|
end
|
2021-10-12 01:55:18 +08:00
|
|
|
end
|
|
|
|
|
2016-07-07 03:56:40 +08:00
|
|
|
describe "watching_first_post" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:user) { Fabricate(:user) }
|
|
|
|
fab!(:category) { Fabricate(:category) }
|
|
|
|
fab!(:tag) { Fabricate(:tag) }
|
|
|
|
fab!(:topic) { Fabricate(:topic, category: category, tags: [tag]) }
|
|
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
2016-07-07 03:56:40 +08:00
|
|
|
|
|
|
|
it "doesn't notify people who aren't watching" do
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies the user who is following the first post category" do
|
|
|
|
level = CategoryUser.notification_levels[:watching_first_post]
|
|
|
|
CategoryUser.set_notification_level_for_category(user, level, category.id)
|
2016-07-20 03:57:05 +08:00
|
|
|
PostAlerter.new.after_save_post(post, true)
|
2016-07-07 03:56:40 +08:00
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(1)
|
|
|
|
end
|
|
|
|
|
2016-07-20 03:57:05 +08:00
|
|
|
it "doesn't notify when the record is not new" do
|
|
|
|
level = CategoryUser.notification_levels[:watching_first_post]
|
|
|
|
CategoryUser.set_notification_level_for_category(user, level, category.id)
|
|
|
|
PostAlerter.new.after_save_post(post, false)
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(0)
|
|
|
|
end
|
|
|
|
|
2016-07-07 03:56:40 +08:00
|
|
|
it "notifies the user who is following the first post tag" do
|
|
|
|
level = TagUser.notification_levels[:watching_first_post]
|
|
|
|
TagUser.change(user.id, tag.id, level)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies the user who is following the first post group" do
|
|
|
|
GroupUser.create(group_id: group.id, user_id: user.id)
|
|
|
|
GroupUser.create(group_id: group.id, user_id: post.user.id)
|
2016-07-22 03:05:10 +08:00
|
|
|
topic.topic_allowed_groups.create(group_id: group.id)
|
2016-07-07 03:56:40 +08:00
|
|
|
|
|
|
|
level = GroupUser.notification_levels[:watching_first_post]
|
|
|
|
GroupUser.where(user_id: user.id, group_id: group.id).update_all(notification_level: level)
|
|
|
|
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(1)
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
|
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
level = CategoryUser.notification_levels[:watching_first_post]
|
|
|
|
CategoryUser.set_notification_level_for_category(user, level, category.id)
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.new.after_save_post(post, true)
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user], post])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with replies" do
|
2017-07-20 04:51:32 +08:00
|
|
|
it "triggers :before_create_notifications_for_users" do
|
2018-12-04 14:54:27 +08:00
|
|
|
_post = Fabricate(:post, user: user, topic: topic)
|
2017-07-20 04:51:32 +08:00
|
|
|
reply = Fabricate(:post, topic: topic, reply_to_post_number: 1)
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.post_created(reply)
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user], reply])
|
|
|
|
end
|
2017-09-19 21:51:10 +08:00
|
|
|
|
|
|
|
it "notifies about regular reply" do
|
2018-12-04 14:54:27 +08:00
|
|
|
_post = Fabricate(:post, user: user, topic: topic)
|
2017-09-19 21:51:10 +08:00
|
|
|
|
|
|
|
reply = Fabricate(:post, topic: topic, reply_to_post_number: 1)
|
|
|
|
PostAlerter.post_created(reply)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:replied]).count).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't notify regular user about whispered reply" do
|
2018-12-04 14:54:27 +08:00
|
|
|
_post = Fabricate(:post, user: user, topic: topic)
|
2017-09-19 21:51:10 +08:00
|
|
|
|
|
|
|
whispered_reply = Fabricate(:post, user: admin, topic: topic, post_type: Post.types[:whisper], reply_to_post_number: 1)
|
|
|
|
PostAlerter.post_created(whispered_reply)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:replied]).count).to eq(0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies staff user about whispered reply" do
|
|
|
|
admin1 = Fabricate(:admin)
|
|
|
|
admin2 = Fabricate(:admin)
|
|
|
|
|
2018-12-04 14:54:27 +08:00
|
|
|
_post = Fabricate(:post, user: user, topic: topic)
|
2017-09-19 21:51:10 +08:00
|
|
|
|
|
|
|
whispered_reply1 = Fabricate(:post, user: admin1, topic: topic, post_type: Post.types[:whisper], reply_to_post_number: 1)
|
|
|
|
whispered_reply2 = Fabricate(:post, user: admin2, topic: topic, post_type: Post.types[:whisper], reply_to_post_number: 2)
|
|
|
|
PostAlerter.post_created(whispered_reply1)
|
|
|
|
PostAlerter.post_created(whispered_reply2)
|
|
|
|
|
|
|
|
expect(admin1.notifications.where(notification_type: Notification.types[:replied]).count).to eq(1)
|
2018-12-04 14:54:27 +08:00
|
|
|
|
|
|
|
TopicUser.change(admin1.id, topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
# this should change nothing cause the moderator post has an action code
|
|
|
|
# if we have an action code then we should never have notifications, this is rare but
|
|
|
|
# assign whispers are like this
|
|
|
|
whispered_reply3 = topic.add_moderator_post(admin2, "i am a reply", post_type: Post.types[:whisper], action_code: 'moderator_thing')
|
|
|
|
PostAlerter.post_created(whispered_reply3)
|
|
|
|
|
|
|
|
# if this whisper is not ignored like it should we would see a posted notification and no replied notifications
|
|
|
|
notifications = admin1.notifications.where(topic_id: topic.id).to_a
|
|
|
|
|
|
|
|
expect(notifications.first.notification_type).to eq(Notification.types[:replied])
|
|
|
|
expect(notifications.length).to eq(1)
|
|
|
|
expect(notifications.first.post_number).to eq(whispered_reply2.post_number)
|
2017-09-19 21:51:10 +08:00
|
|
|
end
|
2017-11-10 23:10:25 +08:00
|
|
|
|
|
|
|
it "sends email notifications only to users not on CC list of incoming email" do
|
|
|
|
alice = Fabricate(:user, username: "alice", email: "alice@example.com")
|
|
|
|
bob = Fabricate(:user, username: "bob", email: "bob@example.com")
|
2017-11-11 00:56:18 +08:00
|
|
|
carol = Fabricate(:user, username: "carol", email: "carol@example.com", staged: true)
|
2017-11-10 23:10:25 +08:00
|
|
|
dave = Fabricate(:user, username: "dave", email: "dave@example.com", staged: true)
|
|
|
|
erin = Fabricate(:user, username: "erin", email: "erin@example.com")
|
|
|
|
|
|
|
|
topic = Fabricate(:private_message_topic, topic_allowed_users: [
|
|
|
|
Fabricate.build(:topic_allowed_user, user: alice),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: bob),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: carol),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: dave),
|
|
|
|
Fabricate.build(:topic_allowed_user, user: erin)
|
|
|
|
])
|
2018-12-05 13:39:17 +08:00
|
|
|
_post = Fabricate(:post, user: alice, topic: topic)
|
2017-11-10 23:10:25 +08:00
|
|
|
|
|
|
|
TopicUser.change(alice.id, topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
TopicUser.change(bob.id, topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
TopicUser.change(erin.id, topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
email = Fabricate(:incoming_email,
|
|
|
|
raw: <<~RAW,
|
|
|
|
Return-Path: <bob@example.com>
|
|
|
|
From: Bob <bob@example.com>
|
|
|
|
To: meta+1234@discoursemail.com, dave@example.com
|
|
|
|
CC: carol@example.com, erin@example.com
|
|
|
|
Subject: Hello world
|
|
|
|
Date: Fri, 15 Jan 2016 00:12:43 +0100
|
|
|
|
Message-ID: <12345@example.com>
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain; charset=UTF-8
|
|
|
|
Content-Transfer-Encoding: quoted-printable
|
|
|
|
|
|
|
|
This post was created by email.
|
|
|
|
RAW
|
|
|
|
from_address: "bob@example.com",
|
|
|
|
to_addresses: "meta+1234@discoursemail.com;dave@example.com",
|
|
|
|
cc_addresses: "carol@example.com;erin@example.com")
|
|
|
|
reply = Fabricate(:post_via_email, user: bob, topic: topic, incoming_email: email, reply_to_post_number: 1)
|
|
|
|
|
|
|
|
NotificationEmailer.expects(:process_notification).with { |n| n.user_id == alice.id }.once
|
|
|
|
NotificationEmailer.expects(:process_notification).with { |n| n.user_id == bob.id }.never
|
|
|
|
NotificationEmailer.expects(:process_notification).with { |n| n.user_id == carol.id }.never
|
|
|
|
NotificationEmailer.expects(:process_notification).with { |n| n.user_id == dave.id }.never
|
|
|
|
NotificationEmailer.expects(:process_notification).with { |n| n.user_id == erin.id }.never
|
|
|
|
|
|
|
|
PostAlerter.post_created(reply)
|
|
|
|
|
|
|
|
expect(alice.notifications.count).to eq(1)
|
|
|
|
expect(bob.notifications.count).to eq(0)
|
|
|
|
expect(carol.notifications.count).to eq(1)
|
|
|
|
expect(dave.notifications.count).to eq(1)
|
|
|
|
expect(erin.notifications.count).to eq(1)
|
|
|
|
end
|
2017-11-17 21:50:35 +08:00
|
|
|
|
|
|
|
it "does not send email notifications to staged users when notification originates in mailinglist mirror category" do
|
|
|
|
category = Fabricate(:mailinglist_mirror_category)
|
|
|
|
topic = Fabricate(:topic, category: category)
|
|
|
|
user = Fabricate(:staged)
|
2018-12-05 13:39:17 +08:00
|
|
|
_post = Fabricate(:post, user: user, topic: topic)
|
2017-11-17 21:50:35 +08:00
|
|
|
reply = Fabricate(:post, topic: topic, reply_to_post_number: 1)
|
|
|
|
|
|
|
|
NotificationEmailer.expects(:process_notification).never
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostAlerter.post_created(reply) }.not_to change(user.notifications, :count)
|
2017-11-17 21:50:35 +08:00
|
|
|
|
|
|
|
category.mailinglist_mirror = false
|
|
|
|
NotificationEmailer.expects(:process_notification).once
|
|
|
|
expect { PostAlerter.post_created(reply) }.to change(user.notifications, :count).by(1)
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with category" do
|
|
|
|
context "with watching" do
|
2018-07-21 17:20:21 +08:00
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
topic = Fabricate(:topic, category: category)
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
level = CategoryUser.notification_levels[:watching]
|
|
|
|
CategoryUser.set_notification_level_for_category(user, level, category.id)
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user], post])
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies staff about whispered post" do
|
|
|
|
topic = Fabricate(:topic, category: category)
|
|
|
|
level = CategoryUser.notification_levels[:watching]
|
|
|
|
CategoryUser.set_notification_level_for_category(admin, level, category.id)
|
|
|
|
CategoryUser.set_notification_level_for_category(user, level, category.id)
|
|
|
|
whispered_post = Fabricate(:post, user: Fabricate(:admin), topic: topic, post_type: Post.types[:whisper])
|
|
|
|
expect {
|
|
|
|
PostAlerter.post_created(whispered_post)
|
|
|
|
}.to add_notification(admin, :posted)
|
|
|
|
expect {
|
|
|
|
PostAlerter.post_created(whispered_post)
|
|
|
|
}.not_to add_notification(user, :posted)
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
2020-01-23 03:33:25 +08:00
|
|
|
|
|
|
|
it "notifies a staged user about a private post, but only if the user has access" do
|
|
|
|
staged_member = Fabricate(:staged)
|
|
|
|
staged_non_member = Fabricate(:staged)
|
|
|
|
group_member = Fabricate(:user)
|
|
|
|
|
|
|
|
group.add(group_member)
|
|
|
|
group.add(staged_member)
|
|
|
|
|
|
|
|
private_category = Fabricate(
|
|
|
|
:private_category, group: group,
|
|
|
|
email_in: 'test@test.com', email_in_allow_strangers: false
|
|
|
|
)
|
|
|
|
|
|
|
|
level = CategoryUser.notification_levels[:watching]
|
|
|
|
CategoryUser.set_notification_level_for_category(group_member, level, private_category.id)
|
|
|
|
CategoryUser.set_notification_level_for_category(staged_member, level, private_category.id)
|
|
|
|
CategoryUser.set_notification_level_for_category(staged_non_member, level, private_category.id)
|
|
|
|
|
|
|
|
topic = Fabricate(:topic, category: private_category, user: group_member)
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
|
|
|
|
expect {
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
}.to add_notification(staged_member, :posted)
|
|
|
|
.and not_add_notification(staged_non_member, :posted)
|
|
|
|
end
|
2021-05-04 11:03:00 +08:00
|
|
|
|
|
|
|
it "does not update existing unread notification" do
|
|
|
|
CategoryUser.set_notification_level_for_category(user, CategoryUser.notification_levels[:watching], category.id)
|
|
|
|
topic = Fabricate(:topic, category: category)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
notification = Notification.last
|
|
|
|
expect(notification.topic_id).to eq(topic.id)
|
|
|
|
expect(notification.post_number).to eq(1)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
notification = Notification.last
|
|
|
|
expect(notification.topic_id).to eq(topic.id)
|
|
|
|
expect(notification.post_number).to eq(1)
|
|
|
|
notification_data = JSON.parse(notification.data)
|
|
|
|
expect(notification_data["display_username"]).to eq(I18n.t("embed.replies", count: 2))
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with tags" do
|
|
|
|
context "with watching" do
|
2017-07-20 04:51:32 +08:00
|
|
|
it "triggers :before_create_notifications_for_users" do
|
|
|
|
tag = Fabricate(:tag)
|
|
|
|
topic = Fabricate(:topic, tags: [tag])
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
level = TagUser.notification_levels[:watching]
|
|
|
|
TagUser.change(user.id, tag.id, level)
|
|
|
|
events = DiscourseEvent.track_events do
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
end
|
|
|
|
expect(events).to include(event_name: :before_create_notifications_for_users, params: [[user], post])
|
|
|
|
end
|
2021-05-04 11:03:00 +08:00
|
|
|
|
|
|
|
it "does not update existing unread notification" do
|
|
|
|
tag = Fabricate(:tag)
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[:watching])
|
|
|
|
topic = Fabricate(:topic, tags: [tag])
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
notification = Notification.last
|
|
|
|
expect(notification.topic_id).to eq(topic.id)
|
|
|
|
expect(notification.post_number).to eq(1)
|
|
|
|
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
notification = Notification.last
|
|
|
|
expect(notification.topic_id).to eq(topic.id)
|
|
|
|
expect(notification.post_number).to eq(1)
|
|
|
|
notification_data = JSON.parse(notification.data)
|
|
|
|
expect(notification_data["display_username"]).to eq(I18n.t("embed.replies", count: 2))
|
|
|
|
end
|
2021-12-01 10:26:56 +08:00
|
|
|
|
|
|
|
it "does not add notification if user does not belong to tag group with permissions" do
|
|
|
|
tag = Fabricate(:tag)
|
|
|
|
topic = Fabricate(:topic, tags: [tag])
|
|
|
|
post = Fabricate(:post, topic: topic)
|
2022-04-06 09:43:57 +08:00
|
|
|
|
|
|
|
tag_group = TagGroup.new(name: 'Only visible to group', tag_names: [tag.name])
|
|
|
|
tag_group.permissions = [[group.id, TagGroupPermission.permission_types[:full]]]
|
|
|
|
tag_group.save!
|
2021-12-01 10:26:56 +08:00
|
|
|
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
expect { PostAlerter.post_created(post) }.not_to change { Notification.count }
|
|
|
|
end
|
|
|
|
|
|
|
|
it "adds notification if user belongs to tag group with permissions" do
|
|
|
|
tag = Fabricate(:tag)
|
|
|
|
topic = Fabricate(:topic, tags: [tag])
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
tag_group = Fabricate(:tag_group, tags: [tag])
|
|
|
|
Fabricate(:group_user, group: group, user: user)
|
|
|
|
Fabricate(:tag_group_permission, tag_group: tag_group, group: group)
|
|
|
|
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[:watching])
|
|
|
|
|
|
|
|
expect { PostAlerter.post_created(post) }.to change { Notification.count }.by(1)
|
|
|
|
end
|
2017-07-20 04:51:32 +08:00
|
|
|
end
|
2019-03-13 01:09:34 +08:00
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with on change" do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:user) { Fabricate(:user) }
|
|
|
|
fab!(:other_tag) { Fabricate(:tag) }
|
|
|
|
fab!(:watched_tag) { Fabricate(:tag) }
|
2019-03-13 01:09:34 +08:00
|
|
|
|
|
|
|
before do
|
|
|
|
SiteSetting.tagging_enabled = true
|
2019-03-14 22:47:38 +08:00
|
|
|
Jobs.run_immediately!
|
2019-04-05 21:06:38 +08:00
|
|
|
TagUser.change(user.id, watched_tag.id, TagUser.notification_levels[:watching_first_post])
|
2019-06-11 23:06:54 +08:00
|
|
|
TopicUser.change(Fabricate(:user).id, post.topic.id, notification_level: TopicUser.notification_levels[:watching])
|
2019-03-13 01:09:34 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "triggers a notification" do
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(0)
|
|
|
|
|
2019-11-07 05:20:15 +08:00
|
|
|
expect { PostRevisor.new(post).revise!(Fabricate(:user), tags: [other_tag.name, watched_tag.name]) }.to change { Notification.where(user_id: user.id).count }.by(1)
|
2019-03-13 01:09:34 +08:00
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(1)
|
|
|
|
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostRevisor.new(post).revise!(Fabricate(:user), tags: [watched_tag.name, other_tag.name]) }.not_to change { Notification.count }
|
2019-03-13 01:09:34 +08:00
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(1)
|
|
|
|
end
|
2019-04-05 21:06:38 +08:00
|
|
|
|
|
|
|
it "doesn't trigger a notification if topic is unlisted" do
|
|
|
|
post.topic.update_column(:visible, false)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(0)
|
|
|
|
|
|
|
|
PostRevisor.new(post).revise!(Fabricate(:user), tags: [other_tag.name, watched_tag.name])
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[:watching_first_post]).count).to eq(0)
|
|
|
|
end
|
2019-03-13 01:09:34 +08:00
|
|
|
end
|
2020-08-13 15:22:34 +08:00
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with private message" do
|
2020-08-13 15:22:34 +08:00
|
|
|
fab!(:post) { Fabricate(:private_message_post) }
|
|
|
|
fab!(:other_tag) { Fabricate(:tag) }
|
|
|
|
fab!(:other_tag2) { Fabricate(:tag) }
|
|
|
|
fab!(:other_tag3) { Fabricate(:tag) }
|
|
|
|
fab!(:user) { Fabricate(:user) }
|
|
|
|
fab!(:staged) { Fabricate(:staged) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
SiteSetting.tagging_enabled = true
|
2022-05-10 23:02:28 +08:00
|
|
|
SiteSetting.pm_tags_allowed_for_groups = "1|2|3"
|
2020-08-13 15:22:34 +08:00
|
|
|
Jobs.run_immediately!
|
|
|
|
TopicUser.change(user.id, post.topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
TopicUser.change(staged.id, post.topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
TopicUser.change(admin.id, post.topic.id, notification_level: TopicUser.notification_levels[:watching])
|
|
|
|
TagUser.change(staged.id, other_tag.id, TagUser.notification_levels[:watching])
|
|
|
|
TagUser.change(admin.id, other_tag3.id, TagUser.notification_levels[:watching])
|
|
|
|
post.topic.allowed_users << user
|
|
|
|
post.topic.allowed_users << staged
|
|
|
|
end
|
|
|
|
|
2021-05-21 09:43:47 +08:00
|
|
|
it "only notifies staff watching added tag" do
|
2020-08-13 15:22:34 +08:00
|
|
|
expect(PostRevisor.new(post).revise!(Fabricate(:admin), tags: [other_tag.name])).to be true
|
|
|
|
expect(Notification.where(user_id: staged.id).count).to eq(0)
|
|
|
|
expect(PostRevisor.new(post).revise!(Fabricate(:admin), tags: [other_tag2.name])).to be true
|
|
|
|
expect(Notification.where(user_id: admin.id).count).to eq(0)
|
|
|
|
expect(PostRevisor.new(post).revise!(Fabricate(:admin), tags: [other_tag3.name])).to be true
|
|
|
|
expect(Notification.where(user_id: admin.id).count).to eq(1)
|
|
|
|
end
|
|
|
|
end
|
2021-12-01 10:26:56 +08:00
|
|
|
|
|
|
|
context "with tag groups" do
|
|
|
|
fab!(:tag) { Fabricate(:tag) }
|
|
|
|
fab!(:user) { Fabricate(:user) }
|
|
|
|
fab!(:topic) { Fabricate(:topic, tags: [tag]) }
|
|
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
|
|
|
|
|
|
|
shared_examples "tag user with notification level" do |notification_level, notification_type|
|
|
|
|
it "notifies a user who is watching a tag that does not belong to a tag group" do
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[notification_level])
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[notification_type]).count).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not notify a user watching a tag with tag group permissions that he does not belong to" do
|
2022-01-19 06:02:29 +08:00
|
|
|
tag_group = Fabricate(:tag_group, tags: [tag], permissions: { group.name => 1 })
|
2021-12-01 10:26:56 +08:00
|
|
|
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[notification_level])
|
|
|
|
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[notification_type]).count).to eq(0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies a user watching a tag with tag group permissions that he belongs to" do
|
|
|
|
Fabricate(:group_user, group: group, user: user)
|
|
|
|
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[notification_level])
|
|
|
|
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[notification_type]).count).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "notifies a staff watching a tag with tag group permissions that he does not belong to" do
|
|
|
|
tag_group = Fabricate(:tag_group, tags: [tag])
|
|
|
|
Fabricate(:tag_group_permission, tag_group: tag_group, group: group)
|
|
|
|
staff_group = Group.find(Group::AUTO_GROUPS[:staff])
|
|
|
|
Fabricate(:group_user, group: staff_group, user: user)
|
|
|
|
|
|
|
|
TagUser.change(user.id, tag.id, TagUser.notification_levels[notification_level])
|
|
|
|
|
|
|
|
PostAlerter.post_created(post)
|
|
|
|
|
|
|
|
expect(user.notifications.where(notification_type: Notification.types[notification_type]).count).to eq(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with :watching notification level" do
|
|
|
|
include_examples "tag user with notification level", :watching, :posted
|
|
|
|
end
|
|
|
|
|
|
|
|
context "with :watching_first_post notification level" do
|
|
|
|
include_examples "tag user with notification level", :watching_first_post, :watching_first_post
|
|
|
|
end
|
|
|
|
end
|
2016-07-07 03:56:40 +08:00
|
|
|
end
|
2017-09-25 16:16:37 +08:00
|
|
|
|
|
|
|
describe '#extract_linked_users' do
|
2019-05-07 11:12:20 +08:00
|
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
|
|
|
fab!(:post2) { Fabricate(:post) }
|
2017-09-25 16:16:37 +08:00
|
|
|
|
|
|
|
describe 'when linked post has been deleted' do
|
|
|
|
let(:topic_link) do
|
|
|
|
TopicLink.create!(
|
|
|
|
url: "/t/#{topic.id}",
|
|
|
|
topic_id: topic.id,
|
|
|
|
link_topic_id: post2.topic.id,
|
|
|
|
link_post_id: nil,
|
|
|
|
post_id: post.id,
|
|
|
|
user: user,
|
|
|
|
domain: 'test.com'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should use the first post of the topic' do
|
|
|
|
topic_link
|
|
|
|
expect(PostAlerter.new.extract_linked_users(post.reload)).to eq([post2.user])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-02-03 08:27:19 +08:00
|
|
|
|
|
|
|
describe '#notify_post_users' do
|
|
|
|
fab!(:post) { Fabricate(:post, topic: topic) }
|
2020-05-07 05:52:21 +08:00
|
|
|
fab!(:last_editor) { Fabricate(:user) }
|
|
|
|
fab!(:tag) { Fabricate(:tag) }
|
2020-06-08 21:23:33 +08:00
|
|
|
fab!(:category) { Fabricate(:category) }
|
2020-02-03 08:27:19 +08:00
|
|
|
|
|
|
|
it 'creates single edit notification when post is modified' do
|
2021-07-05 14:17:31 +08:00
|
|
|
TopicUser.create!(
|
|
|
|
user_id: user.id,
|
|
|
|
topic_id: topic.id,
|
|
|
|
notification_level: TopicUser.notification_levels[:watching],
|
|
|
|
last_read_post_number: post.post_number
|
|
|
|
)
|
|
|
|
|
2020-05-07 05:52:21 +08:00
|
|
|
PostRevisor.new(post).revise!(last_editor, tags: [tag.name])
|
2020-02-03 08:27:19 +08:00
|
|
|
PostAlerter.new.notify_post_users(post, [])
|
|
|
|
expect(Notification.count).to eq(1)
|
|
|
|
expect(Notification.last.notification_type).to eq(Notification.types[:edited])
|
2020-05-07 05:52:21 +08:00
|
|
|
expect(JSON.parse(Notification.last.data)["display_username"]).to eq(last_editor.username)
|
2020-02-03 08:27:19 +08:00
|
|
|
|
|
|
|
PostAlerter.new.notify_post_users(post, [])
|
|
|
|
expect(Notification.count).to eq(1)
|
|
|
|
end
|
2020-06-08 21:23:33 +08:00
|
|
|
|
|
|
|
it 'creates posted notification when Sidekiq is slow' do
|
|
|
|
CategoryUser.set_notification_level_for_category(user, CategoryUser.notification_levels[:watching], category.id)
|
|
|
|
|
|
|
|
post = PostCreator.create!(
|
|
|
|
Fabricate(:user),
|
|
|
|
title: "one of my first topics",
|
|
|
|
raw: "one of my first posts",
|
|
|
|
category: category.id
|
|
|
|
)
|
|
|
|
|
2021-07-05 14:17:31 +08:00
|
|
|
TopicUser.change(user, post.topic_id, last_read_post_number: post.post_number)
|
2020-06-08 21:23:33 +08:00
|
|
|
|
|
|
|
# Manually run job after the user read the topic to simulate a slow
|
|
|
|
# Sidekiq.
|
|
|
|
job_args = Jobs::PostAlert.jobs[0]['args'][0]
|
|
|
|
expect { Jobs::PostAlert.new.execute(job_args.with_indifferent_access) }
|
|
|
|
.to change { Notification.count }.by(1)
|
|
|
|
|
|
|
|
expect(Notification.last.notification_type).to eq(Notification.types[:posted])
|
|
|
|
end
|
2020-02-03 08:27:19 +08:00
|
|
|
end
|
2020-07-10 17:05:55 +08:00
|
|
|
|
2022-07-28 00:14:14 +08:00
|
|
|
context "with SMTP (group_smtp_email)" do
|
2020-07-10 17:05:55 +08:00
|
|
|
before do
|
|
|
|
SiteSetting.enable_smtp = true
|
2021-06-28 06:55:13 +08:00
|
|
|
SiteSetting.email_in = true
|
2020-07-10 17:05:55 +08:00
|
|
|
Jobs.run_immediately!
|
|
|
|
end
|
|
|
|
|
|
|
|
fab!(:group) do
|
|
|
|
Fabricate(
|
|
|
|
:group,
|
2021-06-07 12:17:35 +08:00
|
|
|
smtp_server: "smtp.gmail.com",
|
2020-07-10 17:05:55 +08:00
|
|
|
smtp_port: 587,
|
2021-06-07 12:17:35 +08:00
|
|
|
smtp_ssl: true,
|
|
|
|
imap_server: "imap.gmail.com",
|
|
|
|
imap_port: 993,
|
|
|
|
imap_ssl: true,
|
2020-07-10 17:05:55 +08:00
|
|
|
email_username: "discourse@example.com",
|
2021-06-07 12:17:35 +08:00
|
|
|
email_password: "password",
|
|
|
|
smtp_enabled: true,
|
|
|
|
imap_enabled: true
|
2020-07-10 17:05:55 +08:00
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2021-01-20 08:53:08 +08:00
|
|
|
def create_post_with_incoming
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
raw_mail = <<~EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
From: Foo <foo@discourse.org>
|
|
|
|
To: discourse@example.com
|
|
|
|
Cc: bar@discourse.org, jim@othersite.com
|
|
|
|
Subject: Full email group username flow
|
|
|
|
Date: Fri, 15 Jan 2021 00:12:43 +0100
|
|
|
|
Message-ID: <u4w8c9r4y984yh98r3h69873@example.com.mail>
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
|
|
|
This is the first email.
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
Email::Receiver.new(raw_mail, {}).process!
|
|
|
|
end
|
|
|
|
|
2021-11-17 07:24:17 +08:00
|
|
|
it "does not error if SMTP is enabled and the topic has no incoming email or allowed groups" do
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not error if SMTP is enabled and the topic has no incoming email but does have an allowed group" do
|
2021-12-16 01:41:14 +08:00
|
|
|
TopicAllowedGroup.create(topic: private_message_topic, group: group)
|
2021-11-17 07:24:17 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not error if SMTP is enabled and the topic has no incoming email but has multiple allowed groups" do
|
2021-12-16 01:41:14 +08:00
|
|
|
TopicAllowedGroup.create(topic: private_message_topic, group: group)
|
|
|
|
TopicAllowedGroup.create(topic: private_message_topic, group: Fabricate(:group))
|
2021-11-17 07:24:17 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
2021-06-28 06:55:13 +08:00
|
|
|
it "sends a group smtp email because SMTP is enabled for the site and the group" do
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
2020-07-10 17:05:55 +08:00
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change { ActionMailer::Base.deliveries.size }.by(1)
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
expect(email.from).to include(group.email_username)
|
2021-06-28 06:55:13 +08:00
|
|
|
expect(email.to).to contain_exactly(topic.reload.topic_allowed_users.order(:created_at).first.user.email)
|
|
|
|
expect(email.cc).to match_array(["bar@discourse.org", "jim@othersite.com"])
|
2021-11-16 08:21:49 +08:00
|
|
|
expect(email.subject).to eq("Re: #{topic.title}")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "sends a group smtp email when the original group has had SMTP disabled and there is an additional topic allowed group" do
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
other_allowed_group = Fabricate(:smtp_group)
|
|
|
|
TopicAllowedGroup.create(group: other_allowed_group, topic: topic)
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
group.update!(smtp_enabled: false)
|
|
|
|
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change { ActionMailer::Base.deliveries.size }.by(1)
|
|
|
|
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
expect(email.from).to include(other_allowed_group.email_username)
|
|
|
|
expect(email.to).to contain_exactly(topic.reload.topic_allowed_users.order(:created_at).first.user.email)
|
|
|
|
expect(email.cc).to match_array(["bar@discourse.org", "jim@othersite.com"])
|
2020-07-10 17:05:55 +08:00
|
|
|
expect(email.subject).to eq("Re: #{topic.title}")
|
2021-01-20 08:53:08 +08:00
|
|
|
end
|
2020-07-10 17:05:55 +08:00
|
|
|
|
2021-06-28 06:55:13 +08:00
|
|
|
it "does not send a group smtp email if smtp is not enabled for the group" do
|
|
|
|
group.update!(smtp_enabled: false)
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
2021-06-07 12:17:35 +08:00
|
|
|
post = Fabricate(:post, topic: topic)
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to change { ActionMailer::Base.deliveries.size }
|
2021-06-07 12:17:35 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does not send a group smtp email if SiteSetting.enable_smtp is false" do
|
|
|
|
SiteSetting.enable_smtp = false
|
2021-06-28 06:55:13 +08:00
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
2021-06-07 12:17:35 +08:00
|
|
|
post = Fabricate(:post, topic: topic)
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to change { ActionMailer::Base.deliveries.size }
|
2021-06-07 12:17:35 +08:00
|
|
|
end
|
|
|
|
|
2021-01-20 08:53:08 +08:00
|
|
|
it "does not send group smtp emails for a whisper" do
|
2021-06-28 06:55:13 +08:00
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
2021-01-20 08:53:08 +08:00
|
|
|
post = Fabricate(:post, topic: topic, post_type: Post.types[:whisper])
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to change { ActionMailer::Base.deliveries.size }
|
2021-01-20 08:53:08 +08:00
|
|
|
end
|
|
|
|
|
2021-07-05 08:09:16 +08:00
|
|
|
it "sends the group smtp email job with a delay of personal_email_time_window_seconds" do
|
|
|
|
freeze_time
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
PostAlerter.new.after_save_post(post, true)
|
|
|
|
job_enqueued?(
|
|
|
|
job: :group_smtp_email,
|
|
|
|
args: {
|
|
|
|
group_id: group.id,
|
|
|
|
post_id: post.id,
|
|
|
|
email: topic.reload.topic_allowed_users.order(:created_at).first.user.email,
|
|
|
|
cc_emails: ["bar@discourse.org", "jim@othersite.com"]
|
|
|
|
},
|
|
|
|
at: Time.zone.now + SiteSetting.personal_email_time_window_seconds.seconds
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2022-04-05 11:18:49 +08:00
|
|
|
it "does not send a group smtp email for anyone if the reply post originates from an incoming email that is auto generated" do
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
post = Fabricate(:post, topic: topic)
|
|
|
|
Fabricate(:incoming_email, post: post, topic: topic, is_auto_generated: true)
|
|
|
|
expect_not_enqueued_with(job: :group_smtp_email) do
|
2022-07-19 22:03:03 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.not_to change { ActionMailer::Base.deliveries.size }
|
2022-04-05 11:18:49 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-06-28 06:55:13 +08:00
|
|
|
it "skips sending a notification email to the group and all other email addresses that are _not_ members of the group,
|
|
|
|
sends a group_smtp_email instead" do
|
|
|
|
NotificationEmailer.enable
|
|
|
|
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
|
|
|
|
group_user1 = Fabricate(:group_user, group: group)
|
|
|
|
group_user2 = Fabricate(:group_user, group: group)
|
|
|
|
TopicUser.create(user: group_user1.user, notification_level: TopicUser.notification_levels[:watching], topic: topic)
|
|
|
|
post = Fabricate(:post, topic: topic.reload)
|
|
|
|
|
|
|
|
# Sends an email for:
|
|
|
|
#
|
|
|
|
# 1. the group user that is watching the post (but does not send this email with group SMTO)
|
|
|
|
# 2. the group smtp email to notify all topic_users not in the group
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change {
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(2).and change { Notification.count }.by(2)
|
|
|
|
|
|
|
|
# The group smtp email
|
|
|
|
email = ActionMailer::Base.deliveries.first
|
|
|
|
expect(email.from).to eq([group.email_username])
|
|
|
|
expect(email.to).to contain_exactly("foo@discourse.org")
|
|
|
|
expect(email.cc).to match_array(["bar@discourse.org", "jim@othersite.com"])
|
|
|
|
expect(email.subject).to eq("Re: #{topic.title}")
|
|
|
|
|
|
|
|
# The watching group user notification email
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
expect(email.from).to eq([SiteSetting.notification_email])
|
|
|
|
expect(email.to).to contain_exactly(group_user1.user.email)
|
|
|
|
expect(email.cc).to eq(nil)
|
|
|
|
expect(email.subject).to eq("[Discourse] [PM] #{topic.title}")
|
2021-01-20 08:53:08 +08:00
|
|
|
end
|
|
|
|
|
2021-06-28 06:55:13 +08:00
|
|
|
it "skips sending a notification email to the cc address that was added on the same post with an incoming email" do
|
|
|
|
NotificationEmailer.enable
|
2020-07-10 17:05:55 +08:00
|
|
|
|
2021-06-28 06:55:13 +08:00
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
2021-01-15 12:31:59 +08:00
|
|
|
|
2020-07-10 17:05:55 +08:00
|
|
|
post = Fabricate(:post, topic: topic.reload)
|
2021-06-28 06:55:13 +08:00
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change {
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(1).and change { Notification.count }.by(1)
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
|
|
|
|
# the reply post from someone who was emailed
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
reply_raw_mail = <<~EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
From: Bar <bar@discourse.org>
|
|
|
|
To: discourse@example.com
|
|
|
|
Cc: someothernewcc@baz.com, finalnewcc@doom.com
|
|
|
|
Subject: #{email.subject}
|
|
|
|
Date: Fri, 16 Jan 2021 00:12:43 +0100
|
|
|
|
Message-ID: <sdugj3o4iyu4832x3487@discourse.org.mail>
|
|
|
|
In-Reply-To: #{email.message_id}
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
|
|
|
Hey here is my reply!
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
reply_post_from_email = nil
|
|
|
|
expect {
|
|
|
|
reply_post_from_email = Email::Receiver.new(reply_raw_mail, {}).process!
|
|
|
|
}.to change {
|
|
|
|
User.count # the two new cc addresses have users created
|
|
|
|
}.by(2).and change {
|
|
|
|
TopicAllowedUser.where(topic: topic).count # and they are added as topic allowed users
|
|
|
|
}.by(2).and change {
|
|
|
|
# but they are not sent emails because they were cc'd on an email, only jim@othersite.com
|
|
|
|
# is emailed because he is a topic allowed user cc'd on the _original_ email and he is not
|
|
|
|
# the one creating the post, and foo@discourse.org, who is the OP of the topic
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(1).and change {
|
|
|
|
Notification.count # and they are still sent their normal discourse notification
|
|
|
|
}.by(2)
|
2021-01-20 08:53:08 +08:00
|
|
|
|
2020-07-10 17:05:55 +08:00
|
|
|
email = ActionMailer::Base.deliveries.last
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
expect(email.to).to eq(["foo@discourse.org"])
|
|
|
|
expect(email.cc).to eq(["jim@othersite.com"])
|
2020-07-10 17:05:55 +08:00
|
|
|
expect(email.from).to eq([group.email_username])
|
|
|
|
expect(email.subject).to eq("Re: #{topic.title}")
|
|
|
|
end
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
it "handles the OP of the topic replying by email and sends a group email to the other topic allowed users successfully" do
|
|
|
|
NotificationEmailer.enable
|
|
|
|
|
|
|
|
incoming_email_post = create_post_with_incoming
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
post = Fabricate(:post, topic: topic.reload)
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change {
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(1).and change { Notification.count }.by(1)
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
|
|
|
|
# the reply post from someone who was emailed
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
reply_raw_mail = <<~EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
From: Foo <foo@discourse.org>
|
|
|
|
To: discourse@example.com
|
|
|
|
Cc: someothernewcc@baz.com, finalnewcc@doom.com
|
|
|
|
Subject: #{email.subject}
|
|
|
|
Date: Fri, 16 Jan 2021 00:12:43 +0100
|
|
|
|
Message-ID: <sgk094238uc0348c334483@discourse.org.mail>
|
|
|
|
In-Reply-To: #{email.message_id}
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
|
|
|
I am ~~Commander Shepherd~~ the OP and I approve of this message.
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
reply_post_from_email = nil
|
|
|
|
expect {
|
|
|
|
reply_post_from_email = Email::Receiver.new(reply_raw_mail, {}).process!
|
|
|
|
}.to change {
|
|
|
|
User.count # the two new cc addresses have users created
|
|
|
|
}.by(2).and change {
|
|
|
|
TopicAllowedUser.where(topic: topic).count # and they are added as topic allowed users
|
|
|
|
}.by(2).and change {
|
|
|
|
# but they are not sent emails because they were cc'd on an email, only jim@othersite.com
|
|
|
|
# is emailed because he is a topic allowed user cc'd on the _original_ email and he is not
|
|
|
|
# the one creating the post
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(1).and change {
|
|
|
|
Notification.count # and they are still sent their normal discourse notification
|
|
|
|
}.by(2)
|
|
|
|
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
|
|
|
|
expect(email.to).to eq(["bar@discourse.org"])
|
|
|
|
expect(email.cc).to eq(["jim@othersite.com"])
|
|
|
|
expect(email.from).to eq([group.email_username])
|
|
|
|
expect(email.subject).to eq("Re: #{topic.title}")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "handles the OP of the topic replying by email and cc'ing new people, and does not send a group SMTP email to those newly cc'd users" do
|
|
|
|
NotificationEmailer.enable
|
|
|
|
|
|
|
|
# this is a special case where we are not CC'ing on the original email,
|
|
|
|
# only on the follow up email
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
raw_mail = <<~EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
From: Foo <foo@discourse.org>
|
|
|
|
To: discourse@example.com
|
|
|
|
Subject: Full email group username flow
|
|
|
|
Date: Fri, 14 Jan 2021 00:12:43 +0100
|
|
|
|
Message-ID: <f4832ujfc3498u398i3@example.com.mail>
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
|
|
|
This is the first email.
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
incoming_email_post = Email::Receiver.new(raw_mail, {}).process!
|
|
|
|
topic = incoming_email_post.topic
|
|
|
|
post = Fabricate(:post, topic: topic.reload)
|
|
|
|
expect { PostAlerter.new.after_save_post(post, true) }.to change {
|
|
|
|
ActionMailer::Base.deliveries.size
|
|
|
|
}.by(1).and change { Notification.count }.by(1)
|
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
|
|
|
|
# the reply post from the OP, cc'ing new people in
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
reply_raw_mail = <<~EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
From: Foo <foo@discourse.org>
|
|
|
|
To: discourse@example.com
|
|
|
|
Cc: someothernewcc@baz.com, finalnewcc@doom.com
|
|
|
|
Subject: #{email.subject}
|
|
|
|
Date: Fri, 16 Jan 2021 00:12:43 +0100
|
|
|
|
Message-ID: <3849cu9843yncr9834yr9348x934@discourse.org.mail>
|
|
|
|
In-Reply-To: #{email.message_id}
|
|
|
|
Mime-Version: 1.0
|
|
|
|
Content-Type: text/plain
|
|
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
|
|
|
|
I am inviting my mates to this email party.
|
DEV: Correctly tag heredocs (#16061)
This allows text editors to use correct syntax coloring for the heredoc sections.
Heredoc tag names we use:
languages: SQL, JS, RUBY, LUA, HTML, CSS, SCSS, SH, HBS, XML, YAML/YML, MF, ICS
other: MD, TEXT/TXT, RAW, EMAIL
2022-03-01 03:50:55 +08:00
|
|
|
EMAIL
|
2021-06-28 06:55:13 +08:00
|
|
|
|
|
|
|
reply_post_from_email = nil
|
|
|
|
expect {
|
|
|
|
reply_post_from_email = Email::Receiver.new(reply_raw_mail, {}).process!
|
|
|
|
}.to change {
|
|
|
|
User.count # the two new cc addresses have users created
|
|
|
|
}.by(2).and change {
|
|
|
|
TopicAllowedUser.where(topic: topic).count # and they are added as topic allowed users
|
2022-07-19 22:03:03 +08:00
|
|
|
}.by(2).and not_change {
|
2021-06-28 06:55:13 +08:00
|
|
|
# but they are not sent emails because they were cc'd on an email.
|
|
|
|
# no group smtp message is sent because the OP is not sent an email,
|
|
|
|
# they made this post.
|
|
|
|
ActionMailer::Base.deliveries.size
|
2022-07-19 22:03:03 +08:00
|
|
|
}.and change {
|
2021-06-28 06:55:13 +08:00
|
|
|
Notification.count # and they are still sent their normal discourse notification
|
|
|
|
}.by(2)
|
|
|
|
|
|
|
|
last_email = ActionMailer::Base.deliveries.last
|
|
|
|
expect(email).to eq(last_email)
|
|
|
|
end
|
2020-07-10 17:05:55 +08:00
|
|
|
end
|
2021-12-27 22:25:37 +08:00
|
|
|
|
|
|
|
describe 'storing custom data' do
|
|
|
|
let(:custom_data) { 'custom_string' }
|
|
|
|
|
|
|
|
it 'stores custom data inside a notification' do
|
|
|
|
PostAlerter.new.create_notification(
|
|
|
|
admin,
|
|
|
|
Notification.types[:liked],
|
|
|
|
post,
|
|
|
|
custom_data: { custom_key: custom_data }
|
|
|
|
)
|
|
|
|
|
|
|
|
liked_notification = Notification.where(notification_type: Notification.types[:liked]).last
|
|
|
|
|
|
|
|
expect(liked_notification.data_hash[:custom_key]).to eq(custom_data)
|
|
|
|
end
|
|
|
|
end
|
2014-03-18 12:22:39 +08:00
|
|
|
end
|