2019-04-30 08:27:42 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-07-28 10:27:38 +08:00
|
|
|
RSpec.describe PermalinksController do
|
2023-11-10 06:47:59 +08:00
|
|
|
fab!(:topic)
|
2021-05-21 09:43:47 +08:00
|
|
|
fab!(:permalink) { Fabricate(:permalink, url: "deadroute/topic/546") }
|
2018-06-07 13:08:13 +08:00
|
|
|
|
2014-08-29 03:09:36 +08:00
|
|
|
describe "show" do
|
2014-08-29 23:28:16 +08:00
|
|
|
it "should redirect to a permalink's target_url with status 301" do
|
2024-11-14 07:03:58 +08:00
|
|
|
permalink.update!(permalink_type_value: topic.id, permalink_type: "topic")
|
2018-06-07 13:08:13 +08:00
|
|
|
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
2015-01-10 01:04:02 +08:00
|
|
|
expect(response.status).to eq(301)
|
2014-08-29 03:09:36 +08:00
|
|
|
end
|
|
|
|
|
2015-10-13 04:48:32 +08:00
|
|
|
it "should work for subfolder installs too" do
|
2024-11-14 07:03:58 +08:00
|
|
|
permalink.update!(permalink_type_value: topic.id, permalink_type: "topic")
|
2019-11-15 13:48:24 +08:00
|
|
|
set_subfolder "/forum"
|
2018-06-07 13:08:13 +08:00
|
|
|
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
2015-10-13 04:48:32 +08:00
|
|
|
expect(response.status).to eq(301)
|
|
|
|
end
|
|
|
|
|
2015-07-15 13:32:35 +08:00
|
|
|
it "should apply normalizations" do
|
2024-11-14 07:03:58 +08:00
|
|
|
permalink.update!(permalink_type_value: "/topic/100", permalink_type: "external_url")
|
2015-07-15 13:32:35 +08:00
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
|
2018-06-07 13:08:13 +08:00
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
2015-07-15 13:32:35 +08:00
|
|
|
|
|
|
|
expect(response).to redirect_to("/topic/100")
|
|
|
|
expect(response.status).to eq(301)
|
2015-07-22 11:40:45 +08:00
|
|
|
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
|
2018-06-07 13:08:13 +08:00
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
2015-07-22 11:40:45 +08:00
|
|
|
|
|
|
|
expect(response.status).to eq(404)
|
2015-07-15 13:32:35 +08:00
|
|
|
end
|
|
|
|
|
2014-08-29 23:28:16 +08:00
|
|
|
it "return 404 if permalink record does not exist" do
|
2018-06-07 13:08:13 +08:00
|
|
|
get "/not/a/valid/url"
|
2015-01-10 01:04:02 +08:00
|
|
|
expect(response.status).to eq(404)
|
2014-08-29 03:09:36 +08:00
|
|
|
end
|
2024-06-27 21:09:16 +08:00
|
|
|
|
|
|
|
context "when permalink's target_url is an external URL" do
|
2024-11-14 07:03:58 +08:00
|
|
|
before do
|
|
|
|
permalink.update!(
|
|
|
|
permalink_type_value: "https://github.com/discourse/discourse",
|
|
|
|
permalink_type: "external_url",
|
|
|
|
)
|
|
|
|
end
|
2024-06-27 21:09:16 +08:00
|
|
|
|
|
|
|
it "redirects to it properly" do
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(permalink.external_url)
|
|
|
|
end
|
|
|
|
end
|
2014-08-29 03:09:36 +08:00
|
|
|
end
|
|
|
|
end
|