2016-03-08 02:45:33 +08:00
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
describe UsersEmailController do
|
|
|
|
|
2016-03-08 03:40:11 +08:00
|
|
|
describe '.confirm' do
|
|
|
|
it 'errors out for invalid tokens' do
|
2017-08-31 12:06:56 +08:00
|
|
|
get "/u/authorize-email/asdfasdf"
|
|
|
|
|
2016-03-08 03:40:11 +08:00
|
|
|
expect(response).to be_success
|
2017-10-21 00:04:56 +08:00
|
|
|
expect(response.body).to include(I18n.t('change_email.already_done'))
|
2016-03-08 03:40:11 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'valid old address token' do
|
|
|
|
let(:user) { Fabricate(:moderator) }
|
|
|
|
let(:updater) { EmailUpdater.new(user.guardian, user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
updater.change_to('new.n.cool@example.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'confirms with a correct token' do
|
2017-08-31 12:06:56 +08:00
|
|
|
get "/u/authorize-email/#{user.email_tokens.last.token}"
|
|
|
|
|
2016-03-08 03:40:11 +08:00
|
|
|
expect(response).to be_success
|
2017-08-31 12:06:56 +08:00
|
|
|
|
|
|
|
body = CGI.unescapeHTML(response.body)
|
|
|
|
|
|
|
|
expect(body)
|
|
|
|
.to include(I18n.t('change_email.authorizing_old.title'))
|
|
|
|
|
|
|
|
expect(body)
|
|
|
|
.to include(I18n.t('change_email.authorizing_old.description'))
|
2016-03-08 03:40:11 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'valid new address token' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
let(:updater) { EmailUpdater.new(user.guardian, user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
updater.change_to('new.n.cool@example.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'confirms with a correct token' do
|
2017-02-20 17:37:01 +08:00
|
|
|
user.user_stat.update_columns(bounce_score: 42, reset_bounce_score_after: 1.week.from_now)
|
|
|
|
|
2017-06-01 16:19:42 +08:00
|
|
|
events = DiscourseEvent.track_events do
|
2017-08-31 12:06:56 +08:00
|
|
|
get "/u/authorize-email/#{user.email_tokens.last.token}"
|
2017-06-01 16:19:42 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
expect(events.map { |event| event[:event_name] }).to include(
|
|
|
|
:user_logged_in, :user_first_logged_in
|
|
|
|
)
|
2017-02-20 17:37:01 +08:00
|
|
|
|
2016-03-08 03:40:11 +08:00
|
|
|
expect(response).to be_success
|
2017-08-31 12:06:56 +08:00
|
|
|
expect(response.body).to include(I18n.t('change_email.confirmed'))
|
2017-02-20 17:37:01 +08:00
|
|
|
|
|
|
|
user.reload
|
|
|
|
|
|
|
|
expect(user.user_stat.bounce_score).to eq(0)
|
|
|
|
expect(user.user_stat.reset_bounce_score_after).to eq(nil)
|
2016-03-08 03:40:11 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-08 02:45:33 +08:00
|
|
|
describe '.update' do
|
|
|
|
let(:new_email) { 'bubblegum@adventuretime.ooo' }
|
|
|
|
|
|
|
|
it "requires you to be logged in" do
|
2017-08-31 12:06:56 +08:00
|
|
|
expect do
|
|
|
|
put "/u/asdf/preferences/email.json"
|
|
|
|
end.to raise_error(Discourse::NotLoggedIn)
|
2016-03-08 02:45:33 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when logged in' do
|
2017-08-31 12:06:56 +08:00
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-03-08 02:45:33 +08:00
|
|
|
|
|
|
|
it 'raises an error without an email parameter' do
|
2017-08-31 12:06:56 +08:00
|
|
|
expect do
|
|
|
|
put "/u/#{user.username}/preferences/email.json"
|
|
|
|
end.to raise_error(ActionController::ParameterMissing)
|
2016-03-08 02:45:33 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
it "raises an error if you can't edit the user's email" do
|
|
|
|
Guardian.any_instance.expects(:can_edit_email?).with(user).returns(false)
|
2017-08-31 12:06:56 +08:00
|
|
|
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: { email: new_email }
|
|
|
|
|
2016-03-08 02:45:33 +08:00
|
|
|
expect(response).to be_forbidden
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the new email address is taken' do
|
|
|
|
let!(:other_user) { Fabricate(:coding_horror) }
|
2017-08-31 12:06:56 +08:00
|
|
|
|
2017-10-04 23:41:08 +08:00
|
|
|
context 'hide_email_address_taken is disabled' do
|
|
|
|
before do
|
|
|
|
SiteSetting.hide_email_address_taken = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises an error' do
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: other_user.email
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(response).to_not be_success
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises an error if there is whitespace too' do
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: "#{other_user.email} "
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(response).to_not be_success
|
|
|
|
end
|
2016-03-08 02:45:33 +08:00
|
|
|
end
|
|
|
|
|
2017-10-04 23:41:08 +08:00
|
|
|
context 'hide_email_address_taken is enabled' do
|
|
|
|
before do
|
|
|
|
SiteSetting.hide_email_address_taken = true
|
|
|
|
end
|
2017-08-31 12:06:56 +08:00
|
|
|
|
2017-10-04 23:41:08 +08:00
|
|
|
it 'responds with success' do
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: other_user.email
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(response).to be_success
|
|
|
|
end
|
2016-03-08 02:45:33 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when new email is different case of existing email' do
|
2017-07-28 09:20:09 +08:00
|
|
|
let!(:other_user) { Fabricate(:user, email: 'case.insensitive@gmail.com') }
|
2016-03-08 02:45:33 +08:00
|
|
|
|
|
|
|
it 'raises an error' do
|
2017-08-31 12:06:56 +08:00
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: other_user.email.upcase
|
|
|
|
}
|
|
|
|
|
2016-03-08 02:45:33 +08:00
|
|
|
expect(response).to_not be_success
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises an error when new email domain is present in email_domains_blacklist site setting' do
|
|
|
|
SiteSetting.email_domains_blacklist = "mailinator.com"
|
2017-08-31 12:06:56 +08:00
|
|
|
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: "not_good@mailinator.com"
|
|
|
|
}
|
|
|
|
|
2016-03-08 02:45:33 +08:00
|
|
|
expect(response).to_not be_success
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises an error when new email domain is not present in email_domains_whitelist site setting' do
|
|
|
|
SiteSetting.email_domains_whitelist = "discourse.org"
|
2017-08-31 12:06:56 +08:00
|
|
|
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: new_email
|
|
|
|
}
|
|
|
|
|
2016-03-08 02:45:33 +08:00
|
|
|
expect(response).to_not be_success
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'success' do
|
|
|
|
it 'has an email token' do
|
2017-08-31 12:06:56 +08:00
|
|
|
expect do
|
|
|
|
put "/u/#{user.username}/preferences/email.json", params: {
|
|
|
|
email: new_email
|
|
|
|
}
|
|
|
|
end.to change(EmailChangeRequest, :count)
|
2016-03-08 02:45:33 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
end
|