discourse/.eslintignore

app/assets/javascripts/ember-addons/
lib/javascripts/locale/
lib/javascripts/messageformat.js
lib/javascripts/messageformat-lookup.js
lib/pretty_text/
plugins/**/lib/javascripts/locale
public/
vendor/
app/assets/javascripts/discourse/tests/fixtures
node_modules/
spec/
dist/
tmp/
documentation/
Add ember-addons to eslintignore 2015-09-16 04:14:50 +08:00			`app/assets/javascripts/ember-addons/`
Add jshintignore for failing files 2014-03-08 14:31:02 +08:00			`lib/javascripts/locale/`
			`lib/javascripts/messageformat.js`
DEV: Upgrade "lefthook" and skip hooks during merge/rebase (#18910) The old lefthook package was deprecated a long time ago and skipping hooks during merge/rebase makes those git commands a lot faster. 2022-11-08 00:13:21 +08:00			`lib/javascripts/messageformat-lookup.js`
DEV: Improve lefthook config and remove some slow hooks (#16626) They were slowing down checkout, merge and rewrite. This also cleans up the "lints" section which was running into problems with `{all_files}` being too much for some tools to handle. And it makes sure that eslint and prettier runs for core plugins as well. 2022-05-04 23:37:01 +08:00			`lib/pretty_text/`
FEATURE: Allow plugins to register a new locale 2018-01-25 19:09:18 +08:00			`plugins/**/lib/javascripts/locale`
DEV: Don't lint core files when target == plugins (#10259) * DEV: Don't lint core files when target == plugins * Prettier the plugin/.js files Update eslintignore/prettierignore * Add eslint-plugin-ember and eslint-plugin-node * Properly lint all js files in all plugins * LINT: run prettier on test/.js files DEV: Run prettier checks on test/.js files ESLint plugins' assets/javascripts and test/javascripts directories only 2020-08-25 17:40:40 +08:00			`public/`
Add jshintignore for failing files 2014-03-08 14:31:02 +08:00			`vendor/`
Ember 1.12 support 2015-08-12 05:34:02 +08:00			`app/assets/javascripts/discourse/tests/fixtures`
DEV: Remove global Handlebars 2020-05-02 02:11:45 +08:00			`node_modules/`
DEV: Improve lefthook config and remove some slow hooks (#16626) They were slowing down checkout, merge and rewrite. This also cleans up the "lints" section which was running into problems with `{all_files}` being too much for some tools to handle. And it makes sure that eslint and prettier runs for core plugins as well. 2022-05-04 23:37:01 +08:00			`spec/`
DEV: Remove global Handlebars 2020-05-02 02:11:45 +08:00			`dist/`
DEV: Minor linting fixes (#16359) 1. `test/run-qunit.js` wasn't eslinted (I'm not adding it to the CI workflow for now, just fixed the issues) 2. "…" utf character isn't rendered correctly in Jenkins, replaced with three dots 3. Don't try to lint `tmp` when doing `eslint .` in the root dir 2022-04-03 03:15:38 +08:00			`tmp/`
DEV: Chat service object initial implementation (#19814) This is a combined work of Martin Brennan, Loïc Guitaut, and Joffrey Jaffeux. --- This commit implements a base service object when working in chat. The documentation is available at https://discourse.github.io/discourse/chat/backend/Chat/Service.html Generating documentation has been made as part of this commit with a bigger goal in mind of generally making it easier to dive into the chat project. Working with services generally involves 3 parts: - The service object itself, which is a series of steps where few of them are specialized (model, transaction, policy) ```ruby class UpdateAge include Chat::Service::Base model :user, :fetch_user policy :can_see_user contract step :update_age class Contract attribute :age, :integer end def fetch_user(user_id:, ) User.find_by(id: user_id) end def can_see_user(guardian:, ) guardian.can_see_user(user) end def update_age(age:, **) user.update!(age: age) end end ``` - The `with_service` controller helper, handling success and failure of the service within a service and making easy to return proper response to it from the controller ```ruby def update with_service(UpdateAge) do on_success { render_serialized(result.user, BasicUserSerializer, root: "user") } end end ``` - Rspec matchers and steps inspector, improving the dev experience while creating specs for a service ```ruby RSpec.describe(UpdateAge) do subject(:result) do described_class.call(guardian: guardian, user_id: user.id, age: age) end fab!(:user) { Fabricate(:user) } fab!(:current_user) { Fabricate(:admin) } let(:guardian) { Guardian.new(current_user) } let(:age) { 1 } it { expect(user.reload.age).to eq(age) } end ``` Note in case of unexpected failure in your spec, the output will give all the relevant information: ``` 1) UpdateAge when no channel_id is given is expected to fail to find a model named 'user' Failure/Error: it { is_expected.to fail_to_find_a_model(:user) } Expected model 'foo' (key: 'result.model.user') was not found in the result object. [1/4] [model] 'user' ❌ [2/4] [policy] 'can_see_user' [3/4] [contract] 'default' [4/4] [step] 'update_age' /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/update_age.rb:32:in `fetch_user': missing keyword: :user_id (ArgumentError) from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:202:in `instance_exec' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:202:in `call' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:219:in `call' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:417:in `block in run!' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:417:in `each' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:417:in `run!' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:411:in `run' from <internal:kernel>:90:in `tap' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/app/services/base.rb:302:in `call' from /Users/joffreyjaffeux/Code/pr-discourse/plugins/chat/spec/services/update_age_spec.rb:15:in `block (3 levels) in <main>' ``` 2023-02-13 20:09:57 +08:00			`documentation/`