discourse/spec/lib/onebox/open_graph_spec.rb

# frozen_string_literal: true

require "onebox/open_graph"

RSpec.describe Onebox::OpenGraph do
  it "excludes html tags in title" do
    doc =
      Nokogiri.HTML(
        '<html><title>Did&#8217; you &lt;b&gt;miss me&lt;/b&gt;? - Album on Imgur</title><meta name="og:description" content="Post with 7 votes and 151 views. Shared by vinothkannans. Did you &lt;b&gt;miss me&lt;/b&gt;?" /><meta property="og:image" content="https://i.imgur.com/j1CNCZY.gif?noredirect" /></html>',
      )
    og = described_class.new(doc)
    expect(og.title).to eq("Did’ you miss me? - Album on Imgur")
    expect(og.description).to eq(
      "Post with 7 votes and 151 views. Shared by vinothkannans. Did you miss me?",
    )
    expect(og.image).to eq("https://i.imgur.com/j1CNCZY.gif?noredirect")
  end

  it "correctly normalizes the url properties" do
    doc =
      Nokogiri.HTML(
        "<html><meta property=\"og:image\" content=\"http://test.com/test'ing.mp3\" /></html>",
      )
    og = described_class.new(doc)
    expect(og.image).to eq("http://test.com/test&apos;ing.mp3")
  end

  describe "Collections" do
    subject(:graph) { described_class.new(doc) }

    let(:doc) { Nokogiri.HTML(<<-HTML) }
      <html>
        <title>test</title>
        <meta property="og:article:tag" content="&lt;b&gt;tag1&lt;/b&gt;" />
        <meta property="og:article:tag" content="tag2" />
        <meta property="og:article:section" content="category1" />
        <meta property="og:article:section" content="category2" />
        <meta property="og:article:section:color" content="ff0000" />
        <meta property="og:article:section:color" content="0000ff" />
      </html>
      HTML

    it "handles multiple article:tag tags" do
      expect(graph.article_tags).to eq %w[tag1 tag2]
    end

    it "handles multiple article:section tags" do
      expect(graph.article_sections).to eq %w[category1 category2]
    end

    it "handles multiple article:section:color tags" do
      expect(graph.article_section_colors).to eq %w[ff0000 0000ff]
    end
  end
end
-												DEV: Absorb onebox gem into core (#12979)

* Move onebox gem in core library

* Update template file path

* Remove warning for onebox gem caching

* Remove onebox version file

* Remove onebox gem

* Add sanitize gem

* Require onebox library in lazy-yt plugin

* Remove onebox web specific code

This code was used in standalone onebox Sinatra application

* Merge Discourse specific AllowlistedGenericOnebox engine in core

* Fix onebox engine filenames to match class name casing

* Move onebox specs from gem into core

* DEV: Rename `response` helper to `onebox_response`

Fixes a naming collision.

* Require rails_helper

* Don't use `before/after(:all)`

* Whitespace

* Remove fakeweb

* Remove poor unit tests

* DEV: Re-add fakeweb, plugins are using it

* Move onebox helpers

* Stub Instagram API

* FIX: Follow additional redirect status codes (#476)

Don’t throw errors if we encounter 303, 307 or 308 HTTP status codes in responses

* Remove an empty file

* DEV: Update the license file

Using the copy from https://choosealicense.com/licenses/gpl-2.0/#

Hopefully this will enable GitHub to show the license UI?

* DEV: Update embedded copyrights

* DEV: Add Onebox copyright notice

* DEV: Add MIT license, convert COPYRIGHT.txt to md

* DEV: Remove an incorrect copyright claim

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: jbrw <jamie@goatforce5.org>
											
										
										
											2021-05-26 17:41:35 +08:00
+								# frozen_string_literal: true
 								require "onebox/open_graph"
-												Add RSpec 4 compatibility (#17652)

* Remove outdated option

https://github.com/rspec/rspec-core/commit/04078317ba6577699d06cf4dccf014254dcde7a6

* Use the non-globally exposed RSpec syntax

https://github.com/rspec/rspec-core/pull/2803

* Use the non-globally exposed RSpec syntax, cont

https://github.com/rspec/rspec-core/pull/2803

* Comply to strict predicate matchers

See:
 - https://github.com/rspec/rspec-expectations/pull/1195
 - https://github.com/rspec/rspec-expectations/pull/1196
 - https://github.com/rspec/rspec-expectations/pull/1277

											
										
										
											2022-07-28 10:27:38 +08:00
+								RSpec.describe Onebox::OpenGraph do
-												DEV: Absorb onebox gem into core (#12979)

* Move onebox gem in core library

* Update template file path

* Remove warning for onebox gem caching

* Remove onebox version file

* Remove onebox gem

* Add sanitize gem

* Require onebox library in lazy-yt plugin

* Remove onebox web specific code

This code was used in standalone onebox Sinatra application

* Merge Discourse specific AllowlistedGenericOnebox engine in core

* Fix onebox engine filenames to match class name casing

* Move onebox specs from gem into core

* DEV: Rename `response` helper to `onebox_response`

Fixes a naming collision.

* Require rails_helper

* Don't use `before/after(:all)`

* Whitespace

* Remove fakeweb

* Remove poor unit tests

* DEV: Re-add fakeweb, plugins are using it

* Move onebox helpers

* Stub Instagram API

* FIX: Follow additional redirect status codes (#476)

Don’t throw errors if we encounter 303, 307 or 308 HTTP status codes in responses

* Remove an empty file

* DEV: Update the license file

Using the copy from https://choosealicense.com/licenses/gpl-2.0/#

Hopefully this will enable GitHub to show the license UI?

* DEV: Update embedded copyrights

* DEV: Add Onebox copyright notice

* DEV: Add MIT license, convert COPYRIGHT.txt to md

* DEV: Remove an incorrect copyright claim

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: jbrw <jamie@goatforce5.org>
											
										
										
											2021-05-26 17:41:35 +08:00
+								  it "excludes html tags in title" do
 								    doc =
 								      Nokogiri.HTML(
 								        '<html><title>Did&#8217; you &lt;b&gt;miss me&lt;/b&gt;? - Album on Imgur</title><meta name="og:description" content="Post with 7 votes and 151 views. Shared by vinothkannans. Did you &lt;b&gt;miss me&lt;/b&gt;?" /><meta property="og:image" content="https://i.imgur.com/j1CNCZY.gif?noredirect" /></html>',
 								      )
 								    og = described_class.new(doc)
 								    expect(og.title).to eq("Did’ you miss me? - Album on Imgur")
 								    expect(og.description).to eq(
 								      "Post with 7 votes and 151 views. Shared by vinothkannans. Did you miss me?",
 								    )
 								    expect(og.image).to eq("https://i.imgur.com/j1CNCZY.gif?noredirect")
 								  end
 								  it "correctly normalizes the url properties" do
 								    doc =
 								      Nokogiri.HTML(
 								        "<html><meta property=\"og:image\" content=\"http://test.com/test'ing.mp3\" /></html>",
 								      )
 								    og = described_class.new(doc)
 								    expect(og.image).to eq("http://test.com/test&apos;ing.mp3")
 								  end
-												FEATURE: Show more context in Discourse topic oneboxes

Currently when generating a onebox for Discourse topics, some important
context is missing such as categories and tags.

This patch addresses this issue by introducing a new onebox engine
dedicated to display this information when available. Indeed to get this
new information, categories and tags are exposed in the topic metadata
as opengraph tags.

											
										
										
											2022-11-24 23:28:21 +08:00
 								  describe "Collections" do
 								    subject(:graph) { described_class.new(doc) }
 								    let(:doc) { Nokogiri.HTML(<<-HTML) }
 								      <html>
 								        <title>test</title>
 								        <meta property="og:article:tag" content="&lt;b&gt;tag1&lt;/b&gt;" />
 								        <meta property="og:article:tag" content="tag2" />
 								        <meta property="og:article:section" content="category1" />
 								        <meta property="og:article:section" content="category2" />
 								        <meta property="og:article:section:color" content="ff0000" />
 								        <meta property="og:article:section:color" content="0000ff" />
 								      </html>
 								      HTML
 								    it "handles multiple article:tag tags" do
 								      expect(graph.article_tags).to eq %w[tag1 tag2]
 								    end
 								    it "handles multiple article:section tags" do
 								      expect(graph.article_sections).to eq %w[category1 category2]
 								    end
 								    it "handles multiple article:section:color tags" do
 								      expect(graph.article_section_colors).to eq %w[ff0000 0000ff]
 								    end
 								  end
-												DEV: Absorb onebox gem into core (#12979)

* Move onebox gem in core library

* Update template file path

* Remove warning for onebox gem caching

* Remove onebox version file

* Remove onebox gem

* Add sanitize gem

* Require onebox library in lazy-yt plugin

* Remove onebox web specific code

This code was used in standalone onebox Sinatra application

* Merge Discourse specific AllowlistedGenericOnebox engine in core

* Fix onebox engine filenames to match class name casing

* Move onebox specs from gem into core

* DEV: Rename `response` helper to `onebox_response`

Fixes a naming collision.

* Require rails_helper

* Don't use `before/after(:all)`

* Whitespace

* Remove fakeweb

* Remove poor unit tests

* DEV: Re-add fakeweb, plugins are using it

* Move onebox helpers

* Stub Instagram API

* FIX: Follow additional redirect status codes (#476)

Don’t throw errors if we encounter 303, 307 or 308 HTTP status codes in responses

* Remove an empty file

* DEV: Update the license file

Using the copy from https://choosealicense.com/licenses/gpl-2.0/#

Hopefully this will enable GitHub to show the license UI?

* DEV: Update embedded copyrights

* DEV: Add Onebox copyright notice

* DEV: Add MIT license, convert COPYRIGHT.txt to md

* DEV: Remove an incorrect copyright claim

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: jbrw <jamie@goatforce5.org>
											
										
										
											2021-05-26 17:41:35 +08:00
+								end