github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 05:40:42 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
79763a6b97
discourse/spec/controllers/omniauth_callbacks_controller_spec.rb

27 lines
731 B
Ruby
Raw Normal View History

Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
2015-10-11 17:41:23 +08:00
require 'rails_helper'
Check when logging in whether a auth provider is enabled, including specs
2013-03-05 02:44:41 +08:00
describe Users::OmniauthCallbacksController do
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
context ".find_authenticator" do
it "fails if a provider is disabled" do
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
SiteSetting.enable_twitter_logins = false
expect {
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
Users::OmniauthCallbacksController.find_authenticator("twitter")
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
}.to raise_error(Discourse::InvalidAccess)
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
end
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes. * Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay! * Return "casuser", instead of "casuser@" when no cas_domainname is configured. * If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname. Now it just returns the username instead of adding an "@" if cas_domainname is not configured. This especially makes sense on CAS setups where the username equals the users email adress. The old behaviour, if cas_domainname is configured, was not changed. * Fetch the email from CAS attributes if provided If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that. If not, behave as before (username or username@cas_domainname). * Fetch the (full) name from CAS attributes if provided If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 14:30:13 +08:00
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
it "fails for unknown" do
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
expect {
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
Users::OmniauthCallbacksController.find_authenticator("twitter1")
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
}.to raise_error(Discourse::InvalidAccess)
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
end
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes. * Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay! * Return "casuser", instead of "casuser@" when no cas_domainname is configured. * If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname. Now it just returns the username instead of adding an "@" if cas_domainname is not configured. This especially makes sense on CAS setups where the username equals the users email adress. The old behaviour, if cas_domainname is configured, was not changed. * Fetch the email from CAS attributes if provided If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that. If not, behave as before (username or username@cas_domainname). * Fetch the (full) name from CAS attributes if provided If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 14:30:13 +08:00
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
it "finds an authenticator when enabled" do
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
SiteSetting.enable_twitter_logins = true
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
expect(Users::OmniauthCallbacksController.find_authenticator("twitter")).not_to eq(nil)
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes. * Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay! * Return "casuser", instead of "casuser@" when no cas_domainname is configured. * If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname. Now it just returns the username instead of adding an "@" if cas_domainname is not configured. This especially makes sense on CAS setups where the username equals the users email adress. The old behaviour, if cas_domainname is configured, was not changed. * Fetch the email from CAS attributes if provided If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that. If not, behave as before (username or username@cas_domainname). * Fetch the (full) name from CAS attributes if provided If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 14:30:13 +08:00
end
work in progress, get specs to work.
2013-08-23 15:00:18 +08:00
end
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes. * Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay! * Return "casuser", instead of "casuser@" when no cas_domainname is configured. * If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname. Now it just returns the username instead of adding an "@" if cas_domainname is not configured. This especially makes sense on CAS setups where the username equals the users email adress. The old behaviour, if cas_domainname is configured, was not changed. * Fetch the email from CAS attributes if provided If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that. If not, behave as before (username or username@cas_domainname). * Fetch the (full) name from CAS attributes if provided If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 14:30:13 +08:00
Check when logging in whether a auth provider is enabled, including specs
2013-03-05 02:44:41 +08:00
end
Reference in New Issue Copy Permalink