discourse/app/serializers/sidebar_url_serializer.rb

# frozen_string_literal: true

class SidebarUrlSerializer < ApplicationSerializer
  attributes :id, :name, :value, :icon, :external, :full_reload, :segment

  def external
    object.external?
  end

  def full_reload
    object.full_reload?
  end
end
FIX: my links in sidebar section (#20754) Links like `/my/preferences` were invalid in custom section. The reason is that `/my` links are just redirects from backend, and they are not recognized as valid Ember paths. https://github.com/discourse/discourse/blob/main/config/routes.rb#L433 Therefore, regex match allowlist was added - similar to backend check: https://github.com/discourse/discourse/blob/main/app/controllers/users_controller.rb#L471 /safe-mode is same case 2023-03-21 12:58:42 +08:00			`# frozen_string_literal: true`

			`class SidebarUrlSerializer < ApplicationSerializer`
FIX: consistent sidebar section external links (#22343) Before this change, links which required full reload because they are not in ember routes like `/my/preferences` or links to docs like `/pub/*` were treated as real external links. Therefore, they were opening in self window or new tab based on user `external_links_in_new_tab` setting. To be consistent with behavior when full reload links are in the post, they are treated as internal and always open in the same window. 2023-06-30 10:25:43 +08:00			`attributes :id, :name, :value, :icon, :external, :full_reload, :segment`
FIX: my links in sidebar section (#20754) Links like `/my/preferences` were invalid in custom section. The reason is that `/my` links are just redirects from backend, and they are not recognized as valid Ember paths. https://github.com/discourse/discourse/blob/main/config/routes.rb#L433 Therefore, regex match allowlist was added - similar to backend check: https://github.com/discourse/discourse/blob/main/app/controllers/users_controller.rb#L471 /safe-mode is same case 2023-03-21 12:58:42 +08:00
			`def external`
FIX: consistent sidebar section external links (#22343) Before this change, links which required full reload because they are not in ember routes like `/my/preferences` or links to docs like `/pub/*` were treated as real external links. Therefore, they were opening in self window or new tab based on user `external_links_in_new_tab` setting. To be consistent with behavior when full reload links are in the post, they are treated as internal and always open in the same window. 2023-06-30 10:25:43 +08:00			`object.external?`
			`end`

			`def full_reload`
			`object.full_reload?`
FIX: my links in sidebar section (#20754) Links like `/my/preferences` were invalid in custom section. The reason is that `/my` links are just redirects from backend, and they are not recognized as valid Ember paths. https://github.com/discourse/discourse/blob/main/config/routes.rb#L433 Therefore, regex match allowlist was added - similar to backend check: https://github.com/discourse/discourse/blob/main/app/controllers/users_controller.rb#L471 /safe-mode is same case 2023-03-21 12:58:42 +08:00			`end`
			`end`