2019-10-24 00:30:52 +08:00
|
|
|
import Component from "@ember/component";
|
DEV: Remove usage of {{action}} modifiers - Take 2 (#18476)
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core.
In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`.
In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance:
```
<a href {{on "click" (prevent-default (action "x"))}}>Do X</a>
```
Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR.
Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform.
This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier.
Commits:
* Enable `no-action-modifiers` template lint rule
* Replace {{action "x"}} with {{on "click" (action "x")}}
* Remove unnecessary action helper usage
* Remove ctl+click tests for user-menu
These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed.
* Prevent default event handlers to avoid unwanted side effects
Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary.
* Restore UserCardContents#showUser action to avoid regression
By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed.
* Revert EditCategoryTab#selectTab -> EditCategoryTab#select
Avoid potential breaking change in themes / plugins
* Restore GroupCardContents#showGroup action to avoid regression
By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed.
* Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression
By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller.
* Refactor away from `actions` hash in ChooseMessage component
* Modernize EmojiPicker#onCategorySelection usage
* Modernize SearchResultEntry#logClick usage
* Modernize Discovery::Categories#showInserted usage
* Modernize Preferences::Account#resendConfirmationEmail usage
* Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage
* Favor fn over action in SelectedChoice component
* Modernize WizardStep event handlers
* Favor fn over action usage in buttons
* Restore Login#forgotPassword action to avoid possible regression
* Introduce modKeysPressed utility
Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`.
* Don't interfere with click events on links with `href` values when modifier keys are pressed
2022-10-05 20:08:54 +08:00
|
|
|
import EmberObject, { action } from "@ember/object";
|
2023-10-11 02:38:59 +08:00
|
|
|
import { inject as service } from "@ember/service";
|
|
|
|
|
import { classNames } from "@ember-decorators/component";
|
2023-10-17 20:56:59 +08:00
|
|
|
import $ from "jquery";
|
2016-07-01 01:55:44 +08:00
|
|
|
import { ajax } from "discourse/lib/ajax";
|
2023-10-11 02:38:59 +08:00
|
|
|
import { popupAjaxError } from "discourse/lib/ajax-error";
|
2018-08-20 23:29:20 +08:00
|
|
|
import copyText from "discourse/lib/copy-text";
|
2022-07-17 06:50:49 +08:00
|
|
|
import discourseLater from "discourse-common/lib/later";
|
2023-10-11 02:38:59 +08:00
|
|
|
import discourseComputed from "discourse-common/utils/decorators";
|
2023-10-18 18:07:09 +08:00
|
|
|
import I18n from "discourse-i18n";
|
2023-10-11 02:38:59 +08:00
|
|
|
import AdminUser from "admin/models/admin-user";
|
2015-11-21 09:27:06 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
@classNames("ip-lookup")
|
|
|
|
|
export default class IpLookup extends Component {
|
|
|
|
|
@service dialog;
|
2014-07-08 04:18:18 +08:00
|
|
|
|
2019-11-08 05:38:28 +08:00
|
|
|
@discourseComputed("other_accounts.length", "totalOthersWithSameIP")
|
2019-01-22 22:09:04 +08:00
|
|
|
otherAccountsToDelete(otherAccountsLength, totalOthersWithSameIP) {
|
2014-11-25 02:34:04 +08:00
|
|
|
// can only delete up to 50 accounts at a time
|
2019-01-22 22:09:04 +08:00
|
|
|
const total = Math.min(50, totalOthersWithSameIP || 0);
|
|
|
|
|
const visible = Math.min(50, otherAccountsLength || 0);
|
2014-11-25 02:34:04 +08:00
|
|
|
return Math.max(visible, total);
|
2023-02-23 23:32:53 +08:00
|
|
|
}
|
2014-11-25 02:34:04 +08:00
|
|
|
|
DEV: Remove usage of {{action}} modifiers - Take 2 (#18476)
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core.
In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`.
In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance:
```
<a href {{on "click" (prevent-default (action "x"))}}>Do X</a>
```
Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR.
Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform.
This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier.
Commits:
* Enable `no-action-modifiers` template lint rule
* Replace {{action "x"}} with {{on "click" (action "x")}}
* Remove unnecessary action helper usage
* Remove ctl+click tests for user-menu
These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed.
* Prevent default event handlers to avoid unwanted side effects
Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary.
* Restore UserCardContents#showUser action to avoid regression
By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed.
* Revert EditCategoryTab#selectTab -> EditCategoryTab#select
Avoid potential breaking change in themes / plugins
* Restore GroupCardContents#showGroup action to avoid regression
By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed.
* Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression
By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller.
* Refactor away from `actions` hash in ChooseMessage component
* Modernize EmojiPicker#onCategorySelection usage
* Modernize SearchResultEntry#logClick usage
* Modernize Discovery::Categories#showInserted usage
* Modernize Preferences::Account#resendConfirmationEmail usage
* Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage
* Favor fn over action in SelectedChoice component
* Modernize WizardStep event handlers
* Favor fn over action usage in buttons
* Restore Login#forgotPassword action to avoid possible regression
* Introduce modKeysPressed utility
Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`.
* Don't interfere with click events on links with `href` values when modifier keys are pressed
2022-10-05 20:08:54 +08:00
|
|
|
@action
|
|
|
|
|
hide(event) {
|
|
|
|
|
event?.preventDefault();
|
|
|
|
|
this.set("show", false);
|
2023-02-23 23:32:53 +08:00
|
|
|
}
|
DEV: Remove usage of {{action}} modifiers - Take 2 (#18476)
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core.
In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`.
In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance:
```
<a href {{on "click" (prevent-default (action "x"))}}>Do X</a>
```
Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR.
Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform.
This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier.
Commits:
* Enable `no-action-modifiers` template lint rule
* Replace {{action "x"}} with {{on "click" (action "x")}}
* Remove unnecessary action helper usage
* Remove ctl+click tests for user-menu
These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed.
* Prevent default event handlers to avoid unwanted side effects
Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary.
* Restore UserCardContents#showUser action to avoid regression
By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed.
* Revert EditCategoryTab#selectTab -> EditCategoryTab#select
Avoid potential breaking change in themes / plugins
* Restore GroupCardContents#showGroup action to avoid regression
By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed.
* Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression
By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller.
* Refactor away from `actions` hash in ChooseMessage component
* Modernize EmojiPicker#onCategorySelection usage
* Modernize SearchResultEntry#logClick usage
* Modernize Discovery::Categories#showInserted usage
* Modernize Preferences::Account#resendConfirmationEmail usage
* Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage
* Favor fn over action in SelectedChoice component
* Modernize WizardStep event handlers
* Favor fn over action usage in buttons
* Restore Login#forgotPassword action to avoid possible regression
* Introduce modKeysPressed utility
Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`.
* Don't interfere with click events on links with `href` values when modifier keys are pressed
2022-10-05 20:08:54 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
@action
|
|
|
|
|
lookup() {
|
|
|
|
|
this.set("show", true);
|
2014-07-08 04:18:18 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
if (!this.location) {
|
|
|
|
|
ajax("/admin/users/ip-info", {
|
|
|
|
|
data: { ip: this.ip },
|
|
|
|
|
}).then((location) => this.set("location", EmberObject.create(location)));
|
|
|
|
|
}
|
2014-07-08 04:18:18 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
if (!this.other_accounts) {
|
|
|
|
|
this.set("otherAccountsLoading", true);
|
2014-11-25 02:34:04 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
const data = {
|
|
|
|
|
ip: this.ip,
|
|
|
|
|
exclude: this.userId,
|
|
|
|
|
order: "trust_level DESC",
|
|
|
|
|
};
|
2014-11-25 02:34:04 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
ajax("/admin/users/total-others-with-same-ip", {
|
|
|
|
|
data,
|
|
|
|
|
}).then((result) => this.set("totalOthersWithSameIP", result.total));
|
2014-11-25 02:34:04 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
AdminUser.findAll("active", data).then((users) => {
|
|
|
|
|
this.setProperties({
|
|
|
|
|
other_accounts: users,
|
|
|
|
|
otherAccountsLoading: false,
|
2014-07-08 04:18:18 +08:00
|
|
|
});
|
2023-02-23 23:32:53 +08:00
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-08-20 23:29:20 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
@action
|
|
|
|
|
copy() {
|
|
|
|
|
let text = `IP: ${this.ip}\n`;
|
|
|
|
|
const location = this.location;
|
|
|
|
|
if (location) {
|
|
|
|
|
if (location.hostname) {
|
|
|
|
|
text += `${I18n.t("ip_lookup.hostname")}: ${location.hostname}\n`;
|
|
|
|
|
}
|
2018-08-20 23:29:20 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
text += I18n.t("ip_lookup.location");
|
|
|
|
|
if (location.location) {
|
|
|
|
|
text += `: ${location.location}\n`;
|
|
|
|
|
} else {
|
|
|
|
|
text += `: ${I18n.t("ip_lookup.location_not_found")}\n`;
|
2018-08-20 23:29:20 +08:00
|
|
|
}
|
2019-01-22 22:09:04 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
if (location.organization) {
|
|
|
|
|
text += I18n.t("ip_lookup.organisation");
|
|
|
|
|
text += `: ${location.organization}\n`;
|
2018-08-24 04:27:08 +08:00
|
|
|
}
|
2023-02-23 23:32:53 +08:00
|
|
|
}
|
2018-08-20 23:29:20 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
const $copyRange = $('<p id="copy-range"></p>');
|
|
|
|
|
$copyRange.html(text.trim().replace(/\n/g, "<br>"));
|
|
|
|
|
$(document.body).append($copyRange);
|
|
|
|
|
if (copyText(text, $copyRange[0])) {
|
|
|
|
|
this.set("copied", true);
|
|
|
|
|
discourseLater(() => this.set("copied", false), 2000);
|
|
|
|
|
}
|
|
|
|
|
$copyRange.remove();
|
|
|
|
|
}
|
2014-11-25 02:34:04 +08:00
|
|
|
|
2023-02-23 23:32:53 +08:00
|
|
|
@action
|
|
|
|
|
deleteOtherAccounts() {
|
|
|
|
|
this.dialog.yesNoConfirm({
|
|
|
|
|
message: I18n.t("ip_lookup.confirm_delete_other_accounts"),
|
|
|
|
|
didConfirm: () => {
|
|
|
|
|
this.setProperties({
|
|
|
|
|
other_accounts: null,
|
|
|
|
|
otherAccountsLoading: true,
|
|
|
|
|
totalOthersWithSameIP: null,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
ajax("/admin/users/delete-others-with-same-ip.json", {
|
|
|
|
|
type: "DELETE",
|
|
|
|
|
data: {
|
|
|
|
|
ip: this.ip,
|
|
|
|
|
exclude: this.userId,
|
|
|
|
|
order: "trust_level DESC",
|
|
|
|
|
},
|
|
|
|
|
})
|
|
|
|
|
.catch(popupAjaxError)
|
|
|
|
|
.finally(this.send("lookup"));
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
}
|