discourse/app/jobs/regular/update_gravatar.rb

# frozen_string_literal: true

module Jobs
  class UpdateGravatar < ::Jobs::Base
    sidekiq_options queue: "low"

    def execute(args)
      user = User.find_by(id: args[:user_id])
      avatar = UserAvatar.find_by(id: args[:avatar_id])

      if user && avatar && avatar.user&.id == user.id && user.primary_email.present?
        avatar.update_gravatar!
        if !user.uploaded_avatar_id && avatar.gravatar_upload_id
          user.update_column(:uploaded_avatar_id, avatar.gravatar_upload_id)
        end
      end
    end
  end
end
DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging 2019-05-03 06:17:27 +08:00			`# frozen_string_literal: true`

FIX: registration fails with timeout on gravatar 2014-12-16 05:10:27 +08:00			`module Jobs`
DEV: Upgrading Discourse to Zeitwerk (#8098) Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains. We no longer need to use Rails "require_dependency" anywhere and instead can just use standard Ruby patterns to require files. This is a far reaching change and we expect some followups here. 2019-10-02 12:01:53 +08:00			`class UpdateGravatar < ::Jobs::Base`
FEATURE: prioritize sidekiq jobs This commit introduces 3 queues for sidekiq "critical" for urgent jobs (weighted at 4x weight) "default" for standard jobs(weighted at 2x weight) "low" for less important jobs "critical jobs" Reset Password emails has been seperated to its own job Heartbeat which is required to keep sidekiq running Test email which needs to return real quick "low priority jobs" Notify mailing list Pull hotlinked images Update gravatar "default" All the rest Note: for people running sidekiq from command line use bin/sidekiq -q critical,4 -q default,2 -q low 2016-04-07 10:56:43 +08:00			`sidekiq_options queue: "low"`

FIX: registration fails with timeout on gravatar 2014-12-16 05:10:27 +08:00			`def execute(args)`
			`user = User.find_by(id: args[:user_id])`
			`avatar = UserAvatar.find_by(id: args[:avatar_id])`

FIX: Gravatar download attempt if user is missing their email It is possible that a user could exist without an email, if so we should not enqueue a job to download their gravatar. This commit resolves this error that can occur: ``` Job exception: undefined method `email' for nil:NilClass /var/www/discourse/app/models/user.rb:1204:in `email' /var/www/discourse/app/jobs/regular/update_gravatar.rb:12:in `execute' ``` This commit also fixes the original spec which actually was wrong. The job never enqueued in the original spec and so the gravatar was never actually updated and the test was checking if the two values were the same, but they were both null and never updated, so of course they were the same! A new test has also been added to make sure the gravatar job isn't enqueued when a user's email is missing. 2020-09-03 10:12:24 +08:00			`if user && avatar && avatar.user&.id == user.id && user.primary_email.present?`
FIX: registration fails with timeout on gravatar 2014-12-16 05:10:27 +08:00			`avatar.update_gravatar!`
			`if !user.uploaded_avatar_id && avatar.gravatar_upload_id`
			`user.update_column(:uploaded_avatar_id, avatar.gravatar_upload_id)`
			`end`
			`end`
			`end`
			`end`
			`end`