github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 00:23:40 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
b7327d2c34
discourse/spec/components/inline_oneboxer_spec.rb

134 lines
4.0 KiB
Ruby
Raw Normal View History

DEV: use #frozen_string_literal: true on all spec This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
2019-04-30 08:27:42 +08:00
# frozen_string_literal: true
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
require 'rails_helper'
describe InlineOneboxer do
it "should return nothing with empty input" do
expect(InlineOneboxer.new([]).process).to be_blank
end
it "can onebox a topic" do
topic = Fabricate(:topic)
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
results = InlineOneboxer.new([topic.url], skip_cache: true).process
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
expect(results).to be_present
expect(results[0][:url]).to eq(topic.url)
expect(results[0][:title]).to eq(topic.title)
end
it "doesn't onebox private messages" do
topic = Fabricate(:private_message_topic)
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
results = InlineOneboxer.new([topic.url], skip_cache: true).process
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
expect(results).to be_blank
end
context "caching" do
DEV: Prefabrication (test optimization) (#7414) * Introduced fab!, a helper that creates database state for a group It's almost identical to let_it_be, except: 1. It creates a new object for each test by default, 2. You can disable it using PREFABRICATION=0
2019-05-07 11:12:20 +08:00
fab!(:topic) { Fabricate(:topic) }
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
before do
InlineOneboxer.purge(topic.url)
end
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
it "puts an entry in the cache" do
expect(InlineOneboxer.cache_lookup(topic.url)).to be_blank
result = InlineOneboxer.lookup(topic.url)
expect(result).to be_present
cached = InlineOneboxer.cache_lookup(topic.url)
expect(cached[:url]).to eq(topic.url)
expect(cached[:title]).to eq(topic.title)
end
FIX: Cache url data for failed inline oneboxes
2018-11-13 04:14:20 +08:00
it "puts an entry in the cache for failed onebox" do
SiteSetting.enable_inline_onebox_on_all_domains = true
url = "https://example.com/random-url"
Use hijack in inline onebox controller
2018-11-13 05:09:20 +08:00
InlineOneboxer.purge(url)
FIX: Cache url data for failed inline oneboxes
2018-11-13 04:14:20 +08:00
expect(InlineOneboxer.cache_lookup(url)).to be_blank
result = InlineOneboxer.lookup(url)
expect(result).to be_present
cached = InlineOneboxer.cache_lookup(url)
expect(cached[:url]).to eq(url)
expect(cached[:title]).to be_nil
end
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
end
context ".lookup" do
it "can lookup one link at a time" do
topic = Fabricate(:topic)
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
onebox = InlineOneboxer.lookup(topic.url, skip_cache: true)
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
expect(onebox).to be_present
expect(onebox[:url]).to eq(topic.url)
expect(onebox[:title]).to eq(topic.title)
end
Test failures for Inline Onebox
2017-07-21 04:01:16 +08:00
it "returns nothing for unknown links" do
expect(InlineOneboxer.lookup(nil)).to be_nil
expect(InlineOneboxer.lookup("/test")).to be_nil
end
FIX: Show emoji in inline oneboxes
2017-07-22 02:24:28 +08:00
it "will return the fancy title" do
topic = Fabricate(:topic, title: "Hello :pizza: with an emoji")
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
onebox = InlineOneboxer.lookup(topic.url, skip_cache: true)
FIX: Show emoji in inline oneboxes
2017-07-22 02:24:28 +08:00
expect(onebox).to be_present
expect(onebox[:url]).to eq(topic.url)
expect(onebox[:title]).to eq("Hello 🍕 with an emoji")
end
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
it "will not crawl domains that aren't whitelisted" do
onebox = InlineOneboxer.lookup("https://eviltrout.com", skip_cache: true)
expect(onebox).to be_blank
end
FEATURE: option to enable inline oneboxes for all domains Also, change to prefer title over open graph which is often way too sparse
2017-08-03 02:27:21 +08:00
it "will crawl anything if allowed to" do
SiteSetting.enable_inline_onebox_on_all_domains = true
stub_request(:get, "https://eviltrout.com/some-path").
FIX: don't double request when downloading a file
2018-02-24 19:35:57 +08:00
to_return(status: 200, body: "<html><head><title>a blog</title></head></html>")
FEATURE: option to enable inline oneboxes for all domains Also, change to prefer title over open graph which is often way too sparse
2017-08-03 02:27:21 +08:00
onebox = InlineOneboxer.lookup(
"https://eviltrout.com/some-path",
skip_cache: true
)
expect(onebox).to be_present
expect(onebox[:url]).to eq("https://eviltrout.com/some-path")
expect(onebox[:title]).to eq("a blog")
end
FIX: inline oneboxer min title length of 2 also: cache mini onebox misses as well to cut down traffic
2018-01-30 05:39:41 +08:00
it "will not return a onebox if it does not meet minimal length" do
SiteSetting.enable_inline_onebox_on_all_domains = true
stub_request(:get, "https://eviltrout.com/some-path").
FIX: don't double request when downloading a file
2018-02-24 19:35:57 +08:00
to_return(status: 200, body: "<html><head><title>a</title></head></html>")
FIX: inline oneboxer min title length of 2 also: cache mini onebox misses as well to cut down traffic
2018-01-30 05:39:41 +08:00
onebox = InlineOneboxer.lookup(
"https://eviltrout.com/some-path",
skip_cache: true
)
expect(onebox).to be_present
expect(onebox[:url]).to eq("https://eviltrout.com/some-path")
expect(onebox[:title]).to eq(nil)
end
FEATURE: Whitelists for inline oneboxing
2017-07-22 03:29:04 +08:00
it "will lookup whitelisted domains" do
SiteSetting.inline_onebox_domains_whitelist = "eviltrout.com"
RetrieveTitle.stubs(:crawl).returns("Evil Trout's Blog")
onebox = InlineOneboxer.lookup(
"https://eviltrout.com/some-path",
skip_cache: true
)
expect(onebox).to be_present
expect(onebox[:url]).to eq("https://eviltrout.com/some-path")
expect(onebox[:title]).to eq("Evil Trout's Blog")
end
FEATURE: Inline (Mini) Oneboxing see: https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 03:08:54 +08:00
end
end
Reference in New Issue Copy Permalink