discourse/spec/controllers/admin/plugins_controller_spec.rb

require 'rails_helper'

describe Admin::PluginsController do

  it "is a subclass of AdminController" do
    expect(Admin::PluginsController < Admin::AdminController).to eq(true)
  end

  context "while logged in as an admin" do
    let!(:admin) { log_in(:admin) }

    it 'should return JSON' do
      get :index, format: :json
      expect(response.status).to eq(200)
      expect(::JSON.parse(response.body).has_key?('plugins')).to eq(true)
    end
  end

end
Prepare for separation of RSpec helper files Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails. 2015-10-11 17:41:23 +08:00			`require 'rails_helper'`
Add a spec for the new plugins controller 2015-02-11 00:18:16 +08:00
			`describe Admin::PluginsController do`

			`it "is a subclass of AdminController" do`
			`expect(Admin::PluginsController < Admin::AdminController).to eq(true)`
			`end`

			`context "while logged in as an admin" do`
			`let!(:admin) { log_in(:admin) }`

			`it 'should return JSON' do`
Fix all the errors to get our tests green on Rails 5.1. 2017-08-31 12:06:56 +08:00			`get :index, format: :json`
DEV: Assert for 200 response code to avoid changing magic helper in the future. 2018-06-07 16:11:09 +08:00			`expect(response.status).to eq(200)`
Convert specs to RSpec 2.99.2 syntax with Transpec This conversion is done by Transpec 3.1.0 with the following command: transpec * 424 conversions from: obj.should to: expect(obj).to * 325 conversions from: == expected to: eq(expected) * 38 conversions from: obj.should_not to: expect(obj).not_to * 15 conversions from: =~ /pattern/ to: match(/pattern/) * 9 conversions from: it { should ... } to: it { is_expected.to ... } * 5 conversions from: lambda { }.should_not to: expect { }.not_to * 4 conversions from: lambda { }.should to: expect { }.to * 2 conversions from: -> { }.should to: expect { }.to * 2 conversions from: -> { }.should_not to: expect { }.not_to * 1 conversion from: === expected to: be === expected * 1 conversion from: =~ [1, 2] to: match_array([1, 2]) For more details: https://github.com/yujinakayama/transpec#supported-conversions 2015-04-25 23:18:35 +08:00			`expect(::JSON.parse(response.body).has_key?('plugins')).to eq(true)`
Add a spec for the new plugins controller 2015-02-11 00:18:16 +08:00			`end`
			`end`

			`end`