2019-05-03 06:17:27 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2013-02-06 03:16:51 +08:00
|
|
|
class CurrentUserSerializer < BasicUserSerializer
|
|
|
|
|
2013-02-26 00:42:20 +08:00
|
|
|
attributes :name,
|
|
|
|
:unread_notifications,
|
|
|
|
:unread_private_messages,
|
2020-04-01 07:09:20 +08:00
|
|
|
:unread_high_priority_notifications,
|
2016-11-08 16:12:40 +08:00
|
|
|
:read_first_notification?,
|
2013-02-26 00:42:20 +08:00
|
|
|
:admin?,
|
|
|
|
:notification_channel_position,
|
2013-02-15 01:10:53 +08:00
|
|
|
:moderator?,
|
2013-05-02 15:22:27 +08:00
|
|
|
:staff?,
|
2015-01-22 04:58:04 +08:00
|
|
|
:title,
|
2020-05-15 06:42:00 +08:00
|
|
|
:any_posts,
|
2013-04-28 08:37:53 +08:00
|
|
|
:enable_quoting,
|
2019-05-31 13:43:17 +08:00
|
|
|
:enable_defer,
|
2013-04-28 08:37:53 +08:00
|
|
|
:external_links_in_new_tab,
|
2013-06-15 14:58:24 +08:00
|
|
|
:dynamic_favicon,
|
2013-06-12 00:30:38 +08:00
|
|
|
:trust_level,
|
2017-08-29 00:07:30 +08:00
|
|
|
:can_send_private_email_messages,
|
2021-04-01 08:22:40 +08:00
|
|
|
:can_send_private_messages,
|
2013-11-07 01:56:26 +08:00
|
|
|
:can_edit,
|
2014-01-22 01:42:20 +08:00
|
|
|
:can_invite_to_forum,
|
2014-02-14 00:42:35 +08:00
|
|
|
:no_password,
|
2014-03-08 01:58:53 +08:00
|
|
|
:can_delete_account,
|
|
|
|
:should_be_redirected_to_top,
|
2015-09-22 02:28:20 +08:00
|
|
|
:redirected_to_top,
|
2014-06-18 09:21:40 +08:00
|
|
|
:custom_fields,
|
2014-06-19 02:04:10 +08:00
|
|
|
:muted_category_ids,
|
2021-05-06 07:14:07 +08:00
|
|
|
:regular_category_ids,
|
|
|
|
:tracked_category_ids,
|
|
|
|
:watched_first_post_category_ids,
|
|
|
|
:watched_category_ids,
|
2019-12-10 06:50:05 +08:00
|
|
|
:muted_tag_ids,
|
2021-05-06 07:14:07 +08:00
|
|
|
:watched_tags,
|
|
|
|
:watching_first_post_tags,
|
|
|
|
:tracked_tags,
|
|
|
|
:muted_tags,
|
|
|
|
:regular_tags,
|
2015-04-07 16:02:10 +08:00
|
|
|
:dismissed_banner_key,
|
2015-04-11 04:29:13 +08:00
|
|
|
:is_anonymous,
|
2019-01-04 01:03:01 +08:00
|
|
|
:reviewable_count,
|
2016-02-17 12:46:19 +08:00
|
|
|
:read_faq,
|
2016-06-02 04:47:42 +08:00
|
|
|
:automatically_unpin_topics,
|
2016-08-19 09:58:20 +08:00
|
|
|
:mailing_list_mode,
|
DEV: Topic tracking state improvements (#13218)
I merged this PR in yesterday, finally thinking this was done https://github.com/discourse/discourse/pull/12958 but then a wild performance regression occurred. These are the problem methods:
https://github.com/discourse/discourse/blob/1aa20bd681e634f7fff22953ed62d90c2573b331/app/serializers/topic_tracking_state_serializer.rb#L13-L21
Turns out date comparison is super expensive on the backend _as well as_ the frontend.
The fix was to just move the `treat_as_new_topic_start_date` into the SQL query rather than using the slower `UserOption#treat_as_new_topic_start_date` method in ruby. After this change, 1% of the total time is spent with the `created_in_new_period` comparison instead of ~20%.
----
History:
Original PR which had to be reverted **https://github.com/discourse/discourse/pull/12555**. See the description there for what this PR is achieving, plus below.
The issue with the original PR is addressed in https://github.com/discourse/discourse/pull/12958/commits/92ef54f4020111ffacb0f2a27da5d5c2855f9d5d
If you went to the `x unread` link for a tag Chrome would freeze up and possibly crash, or eventually unfreeze after nearly 10 mins. Other routes for unread/new were similarly slow. From profiling the issue was the `sync` function of `topic-tracking-state.js`, which calls down to `isNew` which in turn calls `moment`, a change I had made in the PR above. The time it takes locally with ~1400 topics in the tracking state is 2.3 seconds.
To solve this issue, I have moved these calculations for "created in new period" and "unread not too old" into the tracking state serializer.
When I was looking at the profiler I also noticed this issue which was just compounding the problem. Every time we modify topic tracking state we recalculate the sidebar tracking/everything/tag counts. However this calls `forEachTracked` and `countTags` which can be quite expensive as they go through the whole tracking state (and were also calling the removed moment functions).
I added some logs and this was being called 30 times when navigating to a new /unread route because `sync` is being called from `build-topic-route` (one for each topic loaded due to pagination). So I just added a debounce here and it makes things even faster.
Finally, I changed topic tracking state to use a Map so our counts of the state keys is faster (Maps have .size whereas objects you have to do Object.keys(obj) which is O(n).)
<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
2021-06-02 07:06:29 +08:00
|
|
|
:treat_as_new_topic_start_date,
|
2016-09-18 12:30:15 +08:00
|
|
|
:previous_visit_at,
|
2017-08-12 10:05:16 +08:00
|
|
|
:seen_notification_id,
|
|
|
|
:primary_group_id,
|
2021-07-08 15:46:21 +08:00
|
|
|
:flair_group_id,
|
2018-02-09 01:56:10 +08:00
|
|
|
:can_create_topic,
|
2020-08-19 22:41:40 +08:00
|
|
|
:can_create_group,
|
2018-06-14 02:57:32 +08:00
|
|
|
:link_posting_access,
|
2018-07-27 14:41:07 +08:00
|
|
|
:external_id,
|
2018-10-11 01:00:08 +08:00
|
|
|
:top_category_ids,
|
2018-12-18 15:41:42 +08:00
|
|
|
:hide_profile_and_presence,
|
2019-03-20 12:40:25 +08:00
|
|
|
:groups,
|
2019-04-05 22:13:36 +08:00
|
|
|
:second_factor_enabled,
|
2019-04-12 07:02:18 +08:00
|
|
|
:ignored_users,
|
2019-12-03 15:31:16 +08:00
|
|
|
:title_count_mode,
|
2019-12-10 03:15:47 +08:00
|
|
|
:timezone,
|
2020-08-14 21:40:56 +08:00
|
|
|
:featured_topic,
|
2020-12-18 23:03:51 +08:00
|
|
|
:skip_new_user_tips,
|
|
|
|
:do_not_disturb_until,
|
2021-03-19 21:19:15 +08:00
|
|
|
:has_topic_draft,
|
2021-05-06 07:14:07 +08:00
|
|
|
:can_review,
|
2021-07-27 19:05:33 +08:00
|
|
|
:draft_count,
|
2018-02-09 01:56:10 +08:00
|
|
|
|
2018-12-18 15:41:42 +08:00
|
|
|
def groups
|
2021-05-12 18:06:39 +08:00
|
|
|
owned_group_ids = GroupUser.where(user_id: id, owner: true).pluck(:group_id).to_set
|
|
|
|
object.visible_groups.pluck(:id, :name).map do |id, name|
|
|
|
|
group = { id: id, name: name }
|
|
|
|
group[:owner] = true if owned_group_ids.include?(id)
|
|
|
|
group
|
|
|
|
end
|
2018-12-18 15:41:42 +08:00
|
|
|
end
|
2018-12-10 23:23:29 +08:00
|
|
|
|
2018-06-14 02:57:32 +08:00
|
|
|
def link_posting_access
|
|
|
|
scope.link_posting_access
|
2018-02-09 01:56:10 +08:00
|
|
|
end
|
2017-12-21 08:23:45 +08:00
|
|
|
|
|
|
|
def can_create_topic
|
|
|
|
scope.can_create_topic?(nil)
|
|
|
|
end
|
2013-02-06 03:16:51 +08:00
|
|
|
|
2020-08-19 22:41:40 +08:00
|
|
|
def can_create_group
|
|
|
|
scope.can_create_group?
|
|
|
|
end
|
|
|
|
|
|
|
|
def include_can_create_group?
|
|
|
|
scope.can_create_group?
|
|
|
|
end
|
|
|
|
|
2015-09-05 04:56:02 +08:00
|
|
|
def read_faq
|
|
|
|
object.user_stat.read_faq?
|
|
|
|
end
|
|
|
|
|
2020-05-15 06:42:00 +08:00
|
|
|
def any_posts
|
|
|
|
object.user_stat.any_posts
|
2013-02-15 01:10:53 +08:00
|
|
|
end
|
|
|
|
|
2018-10-11 01:00:08 +08:00
|
|
|
def hide_profile_and_presence
|
|
|
|
object.user_option.hide_profile_and_presence
|
|
|
|
end
|
|
|
|
|
2016-02-17 12:46:19 +08:00
|
|
|
def enable_quoting
|
|
|
|
object.user_option.enable_quoting
|
|
|
|
end
|
|
|
|
|
2019-05-31 13:43:17 +08:00
|
|
|
def enable_defer
|
|
|
|
object.user_option.enable_defer
|
|
|
|
end
|
|
|
|
|
2016-02-17 12:46:19 +08:00
|
|
|
def external_links_in_new_tab
|
|
|
|
object.user_option.external_links_in_new_tab
|
|
|
|
end
|
|
|
|
|
|
|
|
def dynamic_favicon
|
|
|
|
object.user_option.dynamic_favicon
|
|
|
|
end
|
|
|
|
|
2019-04-12 07:02:18 +08:00
|
|
|
def title_count_mode
|
|
|
|
object.user_option.title_count_mode
|
|
|
|
end
|
|
|
|
|
2016-02-17 12:46:19 +08:00
|
|
|
def automatically_unpin_topics
|
|
|
|
object.user_option.automatically_unpin_topics
|
|
|
|
end
|
|
|
|
|
2016-02-18 13:57:22 +08:00
|
|
|
def should_be_redirected_to_top
|
|
|
|
object.user_option.should_be_redirected_to_top
|
|
|
|
end
|
|
|
|
|
|
|
|
def redirected_to_top
|
|
|
|
object.user_option.redirected_to_top
|
|
|
|
end
|
|
|
|
|
2019-12-03 15:31:16 +08:00
|
|
|
def timezone
|
|
|
|
object.user_option.timezone
|
|
|
|
end
|
|
|
|
|
2017-08-29 00:07:30 +08:00
|
|
|
def can_send_private_email_messages
|
2018-08-27 09:38:11 +08:00
|
|
|
scope.can_send_private_messages_to_email?
|
2017-08-29 00:07:30 +08:00
|
|
|
end
|
|
|
|
|
2021-04-01 08:22:40 +08:00
|
|
|
def can_send_private_messages
|
|
|
|
scope.can_send_private_message?(Discourse.system_user)
|
|
|
|
end
|
|
|
|
|
2013-06-12 00:30:38 +08:00
|
|
|
def can_edit
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
2013-11-07 01:56:26 +08:00
|
|
|
def can_invite_to_forum
|
2020-05-07 04:57:26 +08:00
|
|
|
scope.can_invite_to_forum?
|
2013-11-07 01:56:26 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
def include_can_invite_to_forum?
|
|
|
|
scope.can_invite_to_forum?
|
|
|
|
end
|
|
|
|
|
2014-01-22 01:42:20 +08:00
|
|
|
def no_password
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
def include_no_password?
|
|
|
|
!object.has_password?
|
|
|
|
end
|
|
|
|
|
2014-02-14 00:42:35 +08:00
|
|
|
def include_can_delete_account?
|
2014-02-14 04:51:19 +08:00
|
|
|
scope.can_delete_user?(object)
|
2014-02-14 00:42:35 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
def can_delete_account
|
2014-02-14 04:51:19 +08:00
|
|
|
true
|
2014-02-14 00:42:35 +08:00
|
|
|
end
|
|
|
|
|
2015-09-22 02:28:20 +08:00
|
|
|
def include_redirected_to_top?
|
2016-02-18 13:57:22 +08:00
|
|
|
object.user_option.redirected_to_top.present?
|
2014-03-08 01:58:53 +08:00
|
|
|
end
|
|
|
|
|
2014-06-06 04:16:30 +08:00
|
|
|
def custom_fields
|
2014-06-11 09:57:22 +08:00
|
|
|
fields = nil
|
|
|
|
if SiteSetting.public_user_custom_fields.present?
|
|
|
|
fields = SiteSetting.public_user_custom_fields.split('|')
|
|
|
|
end
|
|
|
|
DiscoursePluginRegistry.serialized_current_user_fields.each do |f|
|
|
|
|
fields ||= []
|
|
|
|
fields << f
|
|
|
|
end
|
|
|
|
|
|
|
|
if fields.present?
|
2017-11-15 08:55:37 +08:00
|
|
|
User.custom_fields_for_ids([object.id], fields)[object.id] || {}
|
2014-06-11 09:57:22 +08:00
|
|
|
else
|
|
|
|
{}
|
|
|
|
end
|
2014-06-06 04:16:30 +08:00
|
|
|
end
|
|
|
|
|
2014-06-18 09:21:40 +08:00
|
|
|
def muted_category_ids
|
2021-05-06 07:14:07 +08:00
|
|
|
categories_with_notification_level(:muted)
|
2018-07-27 14:41:07 +08:00
|
|
|
end
|
|
|
|
|
2021-05-06 07:14:07 +08:00
|
|
|
def regular_category_ids
|
|
|
|
categories_with_notification_level(:regular)
|
|
|
|
end
|
|
|
|
|
|
|
|
def tracked_category_ids
|
|
|
|
categories_with_notification_level(:tracking)
|
|
|
|
end
|
|
|
|
|
|
|
|
def watched_category_ids
|
|
|
|
categories_with_notification_level(:watching)
|
|
|
|
end
|
|
|
|
|
|
|
|
def watched_first_post_category_ids
|
|
|
|
categories_with_notification_level(:watching_first_post)
|
|
|
|
end
|
|
|
|
|
|
|
|
# this is a weird outlier that is used for topic tracking state which
|
|
|
|
# needs the actual ids, which is why it is duplicated with muted_tags
|
2019-12-10 06:50:05 +08:00
|
|
|
def muted_tag_ids
|
|
|
|
TagUser.lookup(object, :muted).pluck(:tag_id)
|
|
|
|
end
|
|
|
|
|
2021-05-06 07:14:07 +08:00
|
|
|
def muted_tags
|
|
|
|
tags_with_notification_level(:muted)
|
|
|
|
end
|
|
|
|
|
|
|
|
def tracked_tags
|
2021-05-14 07:45:14 +08:00
|
|
|
tags_with_notification_level(:tracking)
|
2021-05-06 07:14:07 +08:00
|
|
|
end
|
|
|
|
|
|
|
|
def watching_first_post_tags
|
|
|
|
tags_with_notification_level(:watching_first_post)
|
|
|
|
end
|
|
|
|
|
|
|
|
def watched_tags
|
|
|
|
tags_with_notification_level(:watching)
|
|
|
|
end
|
|
|
|
|
|
|
|
def regular_tags
|
|
|
|
tags_with_notification_level(:regular)
|
|
|
|
end
|
|
|
|
|
2019-04-05 22:13:36 +08:00
|
|
|
def ignored_users
|
|
|
|
IgnoredUser.where(user: object.id).joins(:ignored_user).pluck(:username)
|
|
|
|
end
|
|
|
|
|
2018-07-27 14:41:07 +08:00
|
|
|
def top_category_ids
|
2018-07-30 18:36:36 +08:00
|
|
|
omitted_notification_levels = [CategoryUser.notification_levels[:muted], CategoryUser.notification_levels[:regular]]
|
2018-07-27 14:41:07 +08:00
|
|
|
CategoryUser.where(user_id: object.id)
|
2018-07-30 18:36:36 +08:00
|
|
|
.where.not(notification_level: omitted_notification_levels)
|
2018-07-27 14:41:07 +08:00
|
|
|
.order("
|
|
|
|
CASE
|
|
|
|
WHEN notification_level = 3 THEN 1
|
|
|
|
WHEN notification_level = 2 THEN 2
|
|
|
|
WHEN notification_level = 4 THEN 3
|
|
|
|
END")
|
2014-06-18 09:21:40 +08:00
|
|
|
.pluck(:category_id)
|
2018-07-31 11:42:30 +08:00
|
|
|
.slice(0, SiteSetting.header_dropdown_category_count)
|
2014-06-18 09:21:40 +08:00
|
|
|
end
|
|
|
|
|
2014-06-19 02:04:10 +08:00
|
|
|
def dismissed_banner_key
|
|
|
|
object.user_profile.dismissed_banner_key
|
|
|
|
end
|
|
|
|
|
2015-04-07 16:02:10 +08:00
|
|
|
def is_anonymous
|
2015-04-08 10:29:43 +08:00
|
|
|
object.anonymous?
|
2015-04-07 16:02:10 +08:00
|
|
|
end
|
|
|
|
|
2019-01-04 01:03:01 +08:00
|
|
|
def reviewable_count
|
|
|
|
Reviewable.list_for(object).count
|
2015-04-22 01:59:57 +08:00
|
|
|
end
|
|
|
|
|
2021-03-20 03:20:41 +08:00
|
|
|
def can_review
|
|
|
|
scope.can_see_review_queue?
|
|
|
|
end
|
|
|
|
|
2016-06-02 04:47:42 +08:00
|
|
|
def mailing_list_mode
|
|
|
|
object.user_option.mailing_list_mode
|
|
|
|
end
|
|
|
|
|
DEV: Topic tracking state improvements (#13218)
I merged this PR in yesterday, finally thinking this was done https://github.com/discourse/discourse/pull/12958 but then a wild performance regression occurred. These are the problem methods:
https://github.com/discourse/discourse/blob/1aa20bd681e634f7fff22953ed62d90c2573b331/app/serializers/topic_tracking_state_serializer.rb#L13-L21
Turns out date comparison is super expensive on the backend _as well as_ the frontend.
The fix was to just move the `treat_as_new_topic_start_date` into the SQL query rather than using the slower `UserOption#treat_as_new_topic_start_date` method in ruby. After this change, 1% of the total time is spent with the `created_in_new_period` comparison instead of ~20%.
----
History:
Original PR which had to be reverted **https://github.com/discourse/discourse/pull/12555**. See the description there for what this PR is achieving, plus below.
The issue with the original PR is addressed in https://github.com/discourse/discourse/pull/12958/commits/92ef54f4020111ffacb0f2a27da5d5c2855f9d5d
If you went to the `x unread` link for a tag Chrome would freeze up and possibly crash, or eventually unfreeze after nearly 10 mins. Other routes for unread/new were similarly slow. From profiling the issue was the `sync` function of `topic-tracking-state.js`, which calls down to `isNew` which in turn calls `moment`, a change I had made in the PR above. The time it takes locally with ~1400 topics in the tracking state is 2.3 seconds.
To solve this issue, I have moved these calculations for "created in new period" and "unread not too old" into the tracking state serializer.
When I was looking at the profiler I also noticed this issue which was just compounding the problem. Every time we modify topic tracking state we recalculate the sidebar tracking/everything/tag counts. However this calls `forEachTracked` and `countTags` which can be quite expensive as they go through the whole tracking state (and were also calling the removed moment functions).
I added some logs and this was being called 30 times when navigating to a new /unread route because `sync` is being called from `build-topic-route` (one for each topic loaded due to pagination). So I just added a debounce here and it makes things even faster.
Finally, I changed topic tracking state to use a Map so our counts of the state keys is faster (Maps have .size whereas objects you have to do Object.keys(obj) which is O(n).)
<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
2021-06-02 07:06:29 +08:00
|
|
|
def treat_as_new_topic_start_date
|
|
|
|
object.user_option.treat_as_new_topic_start_date
|
|
|
|
end
|
|
|
|
|
2020-08-14 21:40:56 +08:00
|
|
|
def skip_new_user_tips
|
|
|
|
object.user_option.skip_new_user_tips
|
|
|
|
end
|
|
|
|
|
2017-08-12 10:05:16 +08:00
|
|
|
def include_primary_group_id?
|
|
|
|
object.primary_group_id.present?
|
|
|
|
end
|
|
|
|
|
2018-03-08 11:54:31 +08:00
|
|
|
def external_id
|
|
|
|
object&.single_sign_on_record&.external_id
|
|
|
|
end
|
|
|
|
|
|
|
|
def include_external_id?
|
2021-02-08 18:04:33 +08:00
|
|
|
SiteSetting.enable_discourse_connect
|
2018-03-08 11:54:31 +08:00
|
|
|
end
|
2019-03-20 12:40:25 +08:00
|
|
|
|
|
|
|
def second_factor_enabled
|
2019-11-08 13:11:53 +08:00
|
|
|
object.totp_enabled? || object.security_keys_enabled?
|
2019-03-20 12:40:25 +08:00
|
|
|
end
|
2019-12-10 03:15:47 +08:00
|
|
|
|
|
|
|
def featured_topic
|
|
|
|
object.user_profile.featured_topic
|
|
|
|
end
|
2021-03-19 21:19:15 +08:00
|
|
|
|
|
|
|
def has_topic_draft
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
def include_has_topic_draft?
|
|
|
|
Draft.has_topic_draft(object)
|
|
|
|
end
|
2021-07-27 19:05:33 +08:00
|
|
|
|
|
|
|
def draft_count
|
|
|
|
object.user_stat.draft_count
|
|
|
|
end
|
2013-02-06 03:16:51 +08:00
|
|
|
end
|