2023-02-14 09:38:41 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2023-06-07 09:26:58 +08:00
|
|
|
describe "Single thread in side panel", type: :system do
|
2023-02-14 09:38:41 +08:00
|
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
|
|
|
|
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
let(:side_panel) { PageObjects::Pages::ChatSidePanel.new }
|
2023-04-27 02:37:58 +08:00
|
|
|
let(:thread_page) { PageObjects::Pages::ChatThread.new }
|
DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)
This commit is a major overhaul of how chat message actions work, to make it so they are reusable between the main chat channel and the chat thread panel, as well as many improvements and fixes for the thread panel.
There are now several new classes and concepts:
* ChatMessageInteractor - This is initialized from the ChatMessage, ChatMessageActionsDesktop, and ChatMessageActionsMobile components. This handles permissions about what actions can be done for each
message based on the context (thread or channel), handles the actions themselves (e.g. copyLink, delete, edit),
and interacts with the pane of the current context to modify the UI
* ChatChannelThreadPane and ChatChannelPane services - This represents the UI context which contains the
messages, and are mostly used for state management for things like message selection.
* ChatChannelThreadComposer and ChatChannelComposer - This handles interaction between the pane, the
message actions, and the composer, dealing with reply and edit message state.
* Scrolling logic for the messages has now been moved to a helper so it can be shared between the main channel pane and the thread pane
* Various improvements with the emoji picker on both mobile and desktop. The DOM node of each component is now located outside of the message which prevents a large range of issues.
The thread panel now also works in the chat drawer, and the thread messages have less
actions than the main panel, since some do not make sense there (e.g. moving messages to
a different channel). The thread panel title, excerpt, and message sender have also been removed
for now to save space.
This gives us a solid base to keep expanding on and fixing up threads. Subsequent PRs will
make the thread MessageBus subscriptions work and disable echo mode
for the initial release of threads.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2023-04-06 21:19:52 +08:00
|
|
|
let(:chat_drawer_page) { PageObjects::Pages::ChatDrawer.new }
|
2023-04-27 02:37:58 +08:00
|
|
|
let(:sidebar_page) { PageObjects::Pages::Sidebar.new }
|
2023-02-14 09:38:41 +08:00
|
|
|
|
|
|
|
before do
|
|
|
|
chat_system_bootstrap(current_user, [channel])
|
|
|
|
sign_in(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when enable_experimental_chat_threaded_discussions is disabled" do
|
|
|
|
fab!(:channel) { Fabricate(:chat_channel) }
|
|
|
|
before { SiteSetting.enable_experimental_chat_threaded_discussions = false }
|
|
|
|
|
|
|
|
it "does not open the side panel for a single thread" do
|
|
|
|
thread =
|
|
|
|
chat_thread_chain_bootstrap(channel: channel, users: [current_user, Fabricate(:user)])
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.hover_message(thread.original_message)
|
|
|
|
expect(page).not_to have_css(".chat-message-thread-btn")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when threading_enabled is false for the channel" do
|
|
|
|
fab!(:channel) { Fabricate(:chat_channel) }
|
|
|
|
before do
|
|
|
|
SiteSetting.enable_experimental_chat_threaded_discussions = true
|
|
|
|
channel.update!(threading_enabled: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not open the side panel for a single thread" do
|
|
|
|
thread =
|
|
|
|
chat_thread_chain_bootstrap(channel: channel, users: [current_user, Fabricate(:user)])
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.hover_message(thread.original_message)
|
|
|
|
expect(page).not_to have_css(".chat-message-thread-btn")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when enable_experimental_chat_threaded_discussions is true and threading is enabled for the channel" do
|
|
|
|
fab!(:user_2) { Fabricate(:user) }
|
|
|
|
fab!(:channel) { Fabricate(:chat_channel, threading_enabled: true) }
|
|
|
|
fab!(:thread) { chat_thread_chain_bootstrap(channel: channel, users: [current_user, user_2]) }
|
|
|
|
|
|
|
|
before { SiteSetting.enable_experimental_chat_threaded_discussions = true }
|
|
|
|
|
2023-04-27 02:37:58 +08:00
|
|
|
context "when in full page" do
|
|
|
|
context "when switching channel" do
|
|
|
|
fab!(:channel_2) { Fabricate(:chat_channel, threading_enabled: true) }
|
|
|
|
|
|
|
|
before { channel_2.add(current_user) }
|
|
|
|
|
|
|
|
it "closes the opened thread" do
|
|
|
|
chat_page.visit_thread(thread)
|
|
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
|
|
|
|
sidebar_page.open_channel(channel_2)
|
|
|
|
|
|
|
|
expect(side_panel).to have_no_open_thread
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when closing the thread" do
|
|
|
|
it "closes it" do
|
|
|
|
chat_page.visit_thread(thread)
|
|
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
|
|
|
|
thread_page.close
|
|
|
|
|
|
|
|
expect(side_panel).to have_no_open_thread
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-04-12 09:09:06 +08:00
|
|
|
it "opens the single thread in the drawer using the indicator" do
|
DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)
This commit is a major overhaul of how chat message actions work, to make it so they are reusable between the main chat channel and the chat thread panel, as well as many improvements and fixes for the thread panel.
There are now several new classes and concepts:
* ChatMessageInteractor - This is initialized from the ChatMessage, ChatMessageActionsDesktop, and ChatMessageActionsMobile components. This handles permissions about what actions can be done for each
message based on the context (thread or channel), handles the actions themselves (e.g. copyLink, delete, edit),
and interacts with the pane of the current context to modify the UI
* ChatChannelThreadPane and ChatChannelPane services - This represents the UI context which contains the
messages, and are mostly used for state management for things like message selection.
* ChatChannelThreadComposer and ChatChannelComposer - This handles interaction between the pane, the
message actions, and the composer, dealing with reply and edit message state.
* Scrolling logic for the messages has now been moved to a helper so it can be shared between the main channel pane and the thread pane
* Various improvements with the emoji picker on both mobile and desktop. The DOM node of each component is now located outside of the message which prevents a large range of issues.
The thread panel now also works in the chat drawer, and the thread messages have less
actions than the main panel, since some do not make sense there (e.g. moving messages to
a different channel). The thread panel title, excerpt, and message sender have also been removed
for now to save space.
This gives us a solid base to keep expanding on and fixing up threads. Subsequent PRs will
make the thread MessageBus subscriptions work and disable echo mode
for the initial release of threads.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2023-04-06 21:19:52 +08:00
|
|
|
visit("/latest")
|
|
|
|
chat_page.open_from_header
|
|
|
|
chat_drawer_page.open_channel(channel)
|
2023-04-12 09:09:06 +08:00
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
DEV: Refactoring chat message actions for ChatMessage component usage in thread panel (#20756)
This commit is a major overhaul of how chat message actions work, to make it so they are reusable between the main chat channel and the chat thread panel, as well as many improvements and fixes for the thread panel.
There are now several new classes and concepts:
* ChatMessageInteractor - This is initialized from the ChatMessage, ChatMessageActionsDesktop, and ChatMessageActionsMobile components. This handles permissions about what actions can be done for each
message based on the context (thread or channel), handles the actions themselves (e.g. copyLink, delete, edit),
and interacts with the pane of the current context to modify the UI
* ChatChannelThreadPane and ChatChannelPane services - This represents the UI context which contains the
messages, and are mostly used for state management for things like message selection.
* ChatChannelThreadComposer and ChatChannelComposer - This handles interaction between the pane, the
message actions, and the composer, dealing with reply and edit message state.
* Scrolling logic for the messages has now been moved to a helper so it can be shared between the main channel pane and the thread pane
* Various improvements with the emoji picker on both mobile and desktop. The DOM node of each component is now located outside of the message which prevents a large range of issues.
The thread panel now also works in the chat drawer, and the thread messages have less
actions than the main panel, since some do not make sense there (e.g. moving messages to
a different channel). The thread panel title, excerpt, and message sender have also been removed
for now to save space.
This gives us a solid base to keep expanding on and fixing up threads. Subsequent PRs will
make the thread MessageBus subscriptions work and disable echo mode
for the initial release of threads.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2023-04-06 21:19:52 +08:00
|
|
|
expect(chat_drawer_page).to have_open_thread(thread)
|
|
|
|
end
|
|
|
|
|
2023-04-13 16:08:12 +08:00
|
|
|
it "navigates back to the channel when clicking back button from a thread" do
|
|
|
|
visit("/latest")
|
|
|
|
chat_page.open_from_header
|
|
|
|
chat_drawer_page.open_channel(channel)
|
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
|
|
expect(chat_drawer_page).to have_open_thread(thread)
|
|
|
|
|
|
|
|
chat_drawer_page.back
|
|
|
|
|
|
|
|
expect(chat_drawer_page).to have_open_channel(channel)
|
|
|
|
end
|
|
|
|
|
2023-04-12 09:09:06 +08:00
|
|
|
it "opens the side panel for a single thread from the indicator" do
|
2023-02-14 09:38:41 +08:00
|
|
|
chat_page.visit_channel(channel)
|
2023-04-12 09:09:06 +08:00
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
2023-02-14 09:38:41 +08:00
|
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
end
|
|
|
|
|
2023-04-13 20:45:50 +08:00
|
|
|
describe "sending a message" do
|
|
|
|
it "shows the message in the thread pane and links it to the correct channel" do
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
|
|
expect(side_panel).to have_open_thread(thread)
|
2023-05-05 14:55:55 +08:00
|
|
|
thread_page.send_message("new thread message")
|
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
|
2023-06-16 10:08:26 +08:00
|
|
|
thread_message = thread.last_reply
|
2023-04-13 20:45:50 +08:00
|
|
|
expect(thread_message.chat_channel_id).to eq(channel.id)
|
|
|
|
expect(thread_message.thread.channel_id).to eq(channel.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not echo the message in the channel pane" do
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
|
|
expect(side_panel).to have_open_thread(thread)
|
2023-05-05 14:55:55 +08:00
|
|
|
thread_page.send_message("new thread message")
|
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
|
2023-04-13 20:45:50 +08:00
|
|
|
thread_message = thread.reload.replies.last
|
|
|
|
expect(channel_page).not_to have_css(channel_page.message_by_id_selector(thread_message.id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "handles updates from multiple users sending messages in the thread" do
|
|
|
|
using_session(:tab_1) do
|
|
|
|
sign_in(current_user)
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
|
|
end
|
|
|
|
|
|
|
|
other_user = Fabricate(:user)
|
|
|
|
chat_system_user_bootstrap(user: other_user, channel: channel)
|
|
|
|
using_session(:tab_2) do
|
|
|
|
sign_in(other_user)
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
|
|
end
|
|
|
|
|
|
|
|
using_session(:tab_2) do
|
|
|
|
expect(side_panel).to have_open_thread(thread)
|
2023-05-05 14:55:55 +08:00
|
|
|
thread_page.send_message("the other user message")
|
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
|
2023-04-13 20:45:50 +08:00
|
|
|
end
|
|
|
|
|
2023-05-17 23:49:52 +08:00
|
|
|
using_session(:tab_1) do |session|
|
2023-04-13 20:45:50 +08:00
|
|
|
expect(side_panel).to have_open_thread(thread)
|
2023-05-05 14:55:55 +08:00
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
|
|
|
|
thread_page.send_message("this is a test message")
|
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
|
2023-05-17 23:49:52 +08:00
|
|
|
session.quit
|
2023-04-13 20:45:50 +08:00
|
|
|
end
|
|
|
|
|
2023-05-17 23:49:52 +08:00
|
|
|
using_session(:tab_2) do |session|
|
2023-05-05 14:55:55 +08:00
|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
|
2023-05-17 23:49:52 +08:00
|
|
|
session.quit
|
2023-04-13 20:45:50 +08:00
|
|
|
end
|
|
|
|
end
|
2023-04-19 06:53:51 +08:00
|
|
|
|
|
|
|
it "does not mark the channel unread if another user sends a message in the thread" do
|
|
|
|
other_user = Fabricate(:user)
|
|
|
|
chat_system_user_bootstrap(user: other_user, channel: channel)
|
|
|
|
Chat::MessageCreator.create(
|
|
|
|
chat_channel: channel,
|
|
|
|
user: other_user,
|
|
|
|
content: "Hello world!",
|
|
|
|
thread_id: thread.id,
|
|
|
|
)
|
|
|
|
sign_in(current_user)
|
|
|
|
chat_page.visit_channel(channel)
|
|
|
|
expect(page).not_to have_css(
|
|
|
|
".sidebar-section-link.channel-#{channel.id} .sidebar-section-link-suffix.unread",
|
|
|
|
)
|
|
|
|
end
|
2023-04-13 20:45:50 +08:00
|
|
|
end
|
|
|
|
|
2023-02-14 09:38:41 +08:00
|
|
|
context "when using mobile" do
|
2023-04-12 09:09:06 +08:00
|
|
|
it "opens the side panel for a single thread using the indicator", mobile: true do
|
2023-02-14 09:38:41 +08:00
|
|
|
chat_page.visit_channel(channel)
|
2023-04-12 09:09:06 +08:00
|
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
2023-05-31 00:15:34 +08:00
|
|
|
|
2023-02-14 09:38:41 +08:00
|
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|