2024-07-03 06:45:37 +08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
RSpec.describe(Flags::UpdateFlag) do
|
2024-10-17 23:15:35 +08:00
|
|
|
describe described_class::Contract, type: :model do
|
|
|
|
it { is_expected.to validate_presence_of(:id) }
|
|
|
|
it { is_expected.to validate_presence_of(:name) }
|
|
|
|
it { is_expected.to validate_presence_of(:description) }
|
|
|
|
it { is_expected.to validate_length_of(:name).is_at_most(Flag::MAX_NAME_LENGTH) }
|
|
|
|
it { is_expected.to validate_length_of(:description).is_at_most(Flag::MAX_DESCRIPTION_LENGTH) }
|
|
|
|
it { is_expected.to validate_inclusion_of(:applies_to).in_array(Flag.valid_applies_to_types) }
|
2024-07-03 06:45:37 +08:00
|
|
|
end
|
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
describe ".call" do
|
|
|
|
subject(:result) { described_class.call(**params, **dependencies) }
|
2024-08-28 20:54:10 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
fab!(:flag)
|
2024-07-03 06:45:37 +08:00
|
|
|
fab!(:current_user) { Fabricate(:admin) }
|
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
let(:params) { { id: flag_id, name:, description:, applies_to:, require_message:, enabled: } }
|
|
|
|
let(:dependencies) { { guardian: current_user.guardian } }
|
|
|
|
let(:flag_id) { flag.id }
|
|
|
|
let(:name) { "edited custom flag name" }
|
|
|
|
let(:description) { "edited custom flag description" }
|
|
|
|
let(:applies_to) { ["Topic"] }
|
|
|
|
let(:require_message) { true }
|
|
|
|
let(:enabled) { false }
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when contract is invalid" do
|
|
|
|
let(:name) { nil }
|
2024-09-30 07:17:19 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_a_contract }
|
|
|
|
end
|
2024-09-30 07:17:19 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when model is not found" do
|
|
|
|
let(:flag_id) { 0 }
|
2024-09-30 07:17:19 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_to_find_a_model(:flag) }
|
|
|
|
end
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when the flag is a system one" do
|
|
|
|
let(:flag) { Flag.first }
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_a_policy(:not_system) }
|
|
|
|
end
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when the flag has been used" do
|
|
|
|
let!(:post_action) { Fabricate(:post_action, post_action_type_id: flag.id) }
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_a_policy(:not_used) }
|
|
|
|
end
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when user is not allowed to perform the action" do
|
|
|
|
fab!(:current_user) { Fabricate(:user) }
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_a_policy(:invalid_access) }
|
|
|
|
end
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when title is not unique" do
|
|
|
|
let!(:flag_2) { Fabricate(:flag, name:) }
|
2024-07-03 06:45:37 +08:00
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
it { is_expected.to fail_a_policy(:unique_name) }
|
2024-07-03 06:45:37 +08:00
|
|
|
end
|
|
|
|
|
2024-10-17 23:15:35 +08:00
|
|
|
context "when everything's ok" do
|
|
|
|
it { is_expected.to run_successfully }
|
|
|
|
|
|
|
|
it "updates the flag" do
|
|
|
|
result
|
|
|
|
expect(flag.reload).to have_attributes(
|
|
|
|
name: "edited custom flag name",
|
|
|
|
description: "edited custom flag description",
|
|
|
|
applies_to: ["Topic"],
|
|
|
|
require_message: true,
|
|
|
|
enabled: false,
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "logs the action" do
|
|
|
|
expect { result }.to change { UserHistory.count }.by(1)
|
|
|
|
expect(UserHistory.last).to have_attributes(
|
|
|
|
custom_type: "update_flag",
|
|
|
|
details:
|
|
|
|
"name: edited custom flag name\ndescription: edited custom flag description\napplies_to: [\"Topic\"]\nrequire_message: true\nenabled: false",
|
|
|
|
)
|
|
|
|
end
|
2024-07-03 06:45:37 +08:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|