From 0124209a96df4d72c0d64c8799ef92a9f2745533 Mon Sep 17 00:00:00 2001 From: OsamaSayegh <asooomaasoooma90@gmail.com> Date: Wed, 6 Jun 2018 06:32:03 +0300 Subject: [PATCH] REFACTOR: site controller specs to requests --- spec/{controllers => requests}/site_controller_spec.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) rename spec/{controllers => requests}/site_controller_spec.rb (95%) diff --git a/spec/controllers/site_controller_spec.rb b/spec/requests/site_controller_spec.rb similarity index 95% rename from spec/controllers/site_controller_spec.rb rename to spec/requests/site_controller_spec.rb index 78d2b8d4938..d57ca36da85 100644 --- a/spec/controllers/site_controller_spec.rb +++ b/spec/requests/site_controller_spec.rb @@ -2,7 +2,6 @@ require 'rails_helper' describe SiteController do describe '.basic_info' do - it 'is visible always even for sites requiring login' do SiteSetting.login_required = true @@ -13,7 +12,7 @@ describe SiteController do SiteSetting.apple_touch_icon_url = "https://boom.com/apple/logo.png" SiteSetting.mobile_logo_url = "https://a.a/a.png" - get :basic_info, format: :json + get "/site/basic-info.json" json = JSON.parse(response.body) expect(json["title"]).to eq("Hammer Time") @@ -26,12 +25,11 @@ describe SiteController do end describe '.statistics' do - it 'is visible for sites requiring login' do SiteSetting.login_required = true SiteSetting.share_anonymized_statistics = true - get :statistics, format: :json + get "/site/statistics.json" json = JSON.parse(response.body) expect(response).to be_successful @@ -54,7 +52,7 @@ describe SiteController do it 'is not visible if site setting share_anonymized_statistics is disabled' do SiteSetting.share_anonymized_statistics = false - get :statistics, format: :json + get "/site/statistics.json" expect(response).to redirect_to '/' end end