github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

DEV: Fix report flakys (#28838)

Browse Source 
The Report model spec was directly adding methods
to the Report class, which was causing errors in the
admin reports controller because it would look for
a translation of the report name (e.g. report_timeout_test)
like so `I18n.t("reports.#{type}.title")`, then get an
error because the translation did not exist.

This is fixed by using `Report.stubs` instead, which is
cleaned up after every test.
This commit is contained in:
Martin Brennan 2024-09-11 15:24:19 +10:00 committed by GitHub
parent 894f146b3a
commit 0323b366f3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
spec/models/report_spec.rb
View File

@ -975,13 +975,7 @@ RSpec.describe Report do
end
describe "exception report" do
before(:each) do
class Report
def self.report_exception_test(report)
report.data = x
end
end
end
before(:each) { Report.stubs(:report_exception_test).raises(Exception) }
it "returns a report with an exception error" do
report = Report.find("exception_test", wrap_exceptions_in_test: true)
@ -990,16 +984,7 @@ RSpec.describe Report do
end
describe "timeout report" do
before(:each) do
freeze_time
class Report
def self.report_timeout_test(report)
report.error =
wrap_slow_query(1) { ActiveRecord::Base.connection.execute("SELECT pg_sleep(5)") }
end
end
end
before(:each) { Report.stubs(:report_timeout_test).raises(ActiveRecord::QueryCanceled) }
it "returns a report with a timeout error" do
report = Report.find("timeout_test")
@ -1609,15 +1594,8 @@ RSpec.describe Report do
let(:valid_report) { Report.find("valid_test", wrap_exceptions_in_test: true) }
before(:each) do
class Report
def self.report_exception_test(report)
report.data = x
end
def self.report_valid_test(report)
report.data = "success!"
end
end
Report.stubs(:report_exception_test).raises(Exception)
Report.stubs(:report_valid_test)
end
it "caches exception reports for 1 minute" do