From 061d6fd7a70ece078b3fcfd1a1cca33dd3fd65b5 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Thu, 26 Dec 2024 09:54:09 +0800 Subject: [PATCH] DEV: Remove log messages that are redundant (#30466) I think the log messages were used for initial production trials but the log messages are actually not very useful in the grand scheme of things. If the timing of the job is important information, one can get it by enabling Sidekiq logging and obtain the information from there. There is no need for us to flood the logs with these messages. Also the messages will contain at most 100 ids so it is just alot of noise in general. --- app/jobs/regular/sync_acls_for_uploads.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/jobs/regular/sync_acls_for_uploads.rb b/app/jobs/regular/sync_acls_for_uploads.rb index 68b5123b1ac..1c9c3f2c48d 100644 --- a/app/jobs/regular/sync_acls_for_uploads.rb +++ b/app/jobs/regular/sync_acls_for_uploads.rb @@ -11,12 +11,8 @@ module Jobs return if !Discourse.store.external? return if !args.key?(:upload_ids) - # NOTE: These log messages are set to warn to ensure this is working - # as intended in initial production trials, this will need to be set to debug - # after an acl_stale column is added to uploads. time = Benchmark.measure do - Rails.logger.warn("Syncing ACL for upload ids: #{args[:upload_ids].join(", ")}") Upload .includes(:optimized_images) .where(id: args[:upload_ids]) @@ -36,9 +32,6 @@ module Jobs end end end - Rails.logger.warn( - "Completed syncing ACL for upload ids in #{time}. IDs: #{args[:upload_ids].join(", ")}", - ) end end end