github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 06:29:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Ensure service-worker sourcemap URLs do not duplicate extension (#16704)

Browse Source 
`script_asset_path('.../blah.js.map')` was appending `.js`, which would result in a filename like `.js.map.js`. It would also lose the `/assets` prefix, since the map files are not included in the sprockets manifest.

This commit updates the sourceMappingURL rewriting logic to calculate the service-worker's own JS url, and then append `.map`.
This commit is contained in:
David Taylor 2022-05-11 09:51:06 +01:00 committed by GitHub
parent 977da1da77
commit 0689338060
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/static_controller.rb
View File

@ -206,7 +206,7 @@ class StaticController < ApplicationController
content = Rails.application.assets_manifest.find_sources('service-worker.js').first
content = content.sub(
/^\/\/# sourceMappingURL=(service-worker-.+\.map)$/
) { "//# sourceMappingURL=#{helpers.script_asset_path(Regexp.last_match(1))}" }
) { "//# sourceMappingURL=#{helpers.script_asset_path('service-worker')}.map" }
render(
plain: content,
content_type: 'application/javascript'

2
spec/requests/static_controller_spec.rb
View File

@ -420,7 +420,7 @@ describe StaticController do
get "/service-worker.js"
expect(response.status).to eq(200)
expect(response.content_type).to start_with("application/javascript")
expect(response.body).to include("sourceMappingURL=/assets/service-worker-abcde.js.map")
expect(response.body).to include("sourceMappingURL=/assets/service-worker.js.map\n")
end
end
end