github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 01:33:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #340 from tms/post-scroll-peekaboo

Browse Source 
Position the selected post more reliably below the header
This commit is contained in:
Robin Ward 2013-03-04 11:40:00 -08:00
commit 09e9e34b8b
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/discourse/views/topic_view.js
View File

@ -494,14 +494,22 @@ window.Discourse.TopicView.reopenClass({
// Scroll to a given post, if in the DOM. Returns whether it was in the DOM or not. // Scroll to a given post, if in the DOM. Returns whether it was in the DOM or not.
scrollTo: function(topicId, postNumber, callback) { scrollTo: function(topicId, postNumber, callback) {
// Make sure we're looking at the topic we want to scroll to // Make sure we're looking at the topic we want to scroll to
var existing; var existing, header, title, expectedOffset;
if (parseInt(topicId, 10) !== parseInt($('#topic').data('topic-id'), 10)) return false; if (parseInt(topicId, 10) !== parseInt($('#topic').data('topic-id'), 10)) return false;
existing = $("#post_" + postNumber); existing = $("#post_" + postNumber);
if (existing.length) { if (existing.length) {
if (postNumber === 1) { if (postNumber === 1) {
$('html, body').scrollTop(0); $('html, body').scrollTop(0);
} else { } else {
$('html, body').scrollTop(existing.offset().top - 55); header = $('header');
title = $('#topic-title');
expectedOffset = title.height() - header.find('.contents').height();
if (expectedOffset < 0) {
expectedOffset = 0;
}
$('html, body').scrollTop(existing.offset().top - (header.outerHeight(true) + expectedOffset));
} }
return true; return true;
} }