mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 09:42:07 +08:00
DEV: Add admin warnings for plugin-outlet deprecations (#27679)
Adds warnings for: - `discourse.plugin-outlet-tag-name` - `discourse.plugin-outlet-parent-view` Also updates the ID list to be strings rather than regex (so that `.` is not treated as a wildcard).
This commit is contained in:
parent
53e150716e
commit
0a72b21e8f
|
@ -11,10 +11,12 @@ import I18n from "discourse-i18n";
|
|||
// To avoid 'crying wolf', we should only add values here when we're sure they're
|
||||
// not being triggered by core or official themes/plugins.
|
||||
export const CRITICAL_DEPRECATIONS = [
|
||||
/^discourse.modal-controllers$/,
|
||||
/^discourse.bootbox$/,
|
||||
/^discourse.add-header-panel$/,
|
||||
/^discourse.header-widget-overrides$/,
|
||||
"discourse.modal-controllers",
|
||||
"discourse.bootbox",
|
||||
"discourse.add-header-panel",
|
||||
"discourse.header-widget-overrides",
|
||||
"discourse.plugin-outlet-tag-name",
|
||||
"discourse.plugin-outlet-parent-view",
|
||||
/^(?!discourse\.)/, // All unsilenced ember deprecations
|
||||
];
|
||||
|
||||
|
@ -76,7 +78,15 @@ export default class DeprecationWarningHandler extends Service {
|
|||
return;
|
||||
}
|
||||
|
||||
if (CRITICAL_DEPRECATIONS.some((pattern) => pattern.test(opts.id))) {
|
||||
if (
|
||||
CRITICAL_DEPRECATIONS.some((pattern) => {
|
||||
if (typeof pattern === "string") {
|
||||
return pattern === opts.id;
|
||||
} else {
|
||||
return pattern.test(opts.id);
|
||||
}
|
||||
})
|
||||
) {
|
||||
this.notifyAdmin(opts, source);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue
Block a user