FIX: muted was not working in topic timeline (#9021)

This commit is contained in:
Joffrey JAFFEUX 2020-02-21 21:32:58 +01:00 committed by GitHub
parent 533495169e
commit 0b0290cddb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 33 additions and 12 deletions

View File

@ -382,21 +382,15 @@ createWidget("timeline-footer-controls", {
controls.push(
new ComponentConnector(
this,
"topic-notifications-options",
"topic-notifications-button",
{
value: notificationLevel,
notificationLevel,
topic,
options: {
showFullTitle: false,
placement: "bottom-end"
},
onChange: newNotificationLevel => {
if (newNotificationLevel !== notificationLevel) {
topic.details.updateNotifications(newNotificationLevel);
}
}
showFullTitle: false,
appendReason: false,
placement: "bottom-end"
},
["value"]
["notificationLevel"]
)
);
}

View File

@ -5,6 +5,7 @@ export default Component.extend({
classNames: ["topic-notifications-button"],
appendReason: true,
showFullTitle: true,
placement: "bottom-start",
didInsertElement() {
this._super(...arguments);

View File

@ -4,6 +4,7 @@
onChange=(action "changeTopicNotificationLevel")
options=(hash
showFullTitle=showFullTitle
placement=placement
)
}}

View File

@ -30,4 +30,29 @@ QUnit.test("Updating topic notification level", async assert => {
"Watching",
"it should display the right notification level"
);
const timelineNotificationOptions = selectKit(
".topic-timeline .widget-component-connector .topic-notifications-options"
);
assert.equal(
timelineNotificationOptions.header().value(),
"3",
"it should display the right notification level"
);
await timelineNotificationOptions.expand();
await timelineNotificationOptions.selectRowByValue("0");
assert.equal(
timelineNotificationOptions.header().value(),
"0",
"it should display the right notification level"
);
assert.equal(
notificationOptions.header().label(),
"Muted",
"it should display the right notification level"
);
});