github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 09:42:07 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

DEV: Make component-test afterEach async aware (#10099)

Browse Source 
Before this fix, if a test case was async, `afterEach` callback would be executed immediately, without waiting for the test to finish. 😬
This commit is contained in:
Jarek Radosz 2020-06-24 08:03:38 +02:00 committed by GitHub
parent 843bf0df75
commit 0e2f7ecfd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/javascripts/helpers/component-test.js
View File

@ -55,12 +55,12 @@ export default function(name, opts) {
});
andThen(() => {
try {
opts.test.call(this, assert);
} finally {
if (opts.afterEach) {
opts.afterEach.call(opts);
}
return opts.test.call(this, assert);
}).finally(() => {
if (opts.afterEach) {
andThen(() => {
return opts.afterEach.call(opts);
});
}
});
});