github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-31 02:49:29 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: User-tips regression in #25361 (#25367)

Browse Source 
It's a set of Tip objects, not ids
This commit is contained in:
Jarek Radosz 2024-01-22 14:45:47 +01:00 committed by GitHub
parent 62c30e0b5f
commit 108aff663e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/services/user-tips.js
View File

@ -13,11 +13,12 @@ export default class UserTips extends Service {
#shouldRenderSet = new TrackedSet(); #shouldRenderSet = new TrackedSet();
#updateRenderedId() { #updateRenderedId() {
if (this.#availableTips.has(this.#renderedId)) { const tipsArray = [...this.#availableTips];
if (tipsArray.find((tip) => tip.id === this.#renderedId)) {
return; return;
} }
const newId = [...this.#availableTips] const newId = tipsArray
.sortBy("priority") .sortBy("priority")
.reverse() .reverse()
.find((tip) => { .find((tip) => {