github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-09 01:00:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Prefers reads helper over alias (#15282)

Browse Source
This commit is contained in:
Penar Musaraj 2021-12-13 21:03:31 -05:00 committed by GitHub
parent b3e5421b25
commit 10caceec42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/components/popup-input-tip.js
View File

@ -1,4 +1,4 @@
import { alias, not, or } from "@ember/object/computed"; import { not, or, reads } from "@ember/object/computed";
import discourseComputed from "discourse-common/utils/decorators"; import discourseComputed from "discourse-common/utils/decorators";
import Component from "@ember/component"; import Component from "@ember/component";
import { getOwner } from "discourse-common/lib/get-owner"; import { getOwner } from "discourse-common/lib/get-owner";
@ -9,7 +9,7 @@ export default Component.extend({
rerenderTriggers: ["validation.reason"], rerenderTriggers: ["validation.reason"],
tipReason: null, tipReason: null,
lastShownAt: or("shownAt", "validation.lastShownAt"), lastShownAt: or("shownAt", "validation.lastShownAt"),
bad: alias("validation.failed"), bad: reads("validation.failed"),
good: not("bad"), good: not("bad"),
@discourseComputed("bad") @discourseComputed("bad")