From 13cedce0cf7679770a3af779c772fc262ff56863 Mon Sep 17 00:00:00 2001 From: lidlanca Date: Sat, 13 Sep 2014 04:05:03 -0400 Subject: [PATCH] Fix: Cancel link click if triggered as part of text selection Prevent a click if the user select content in a topic and release the mouse over a link. https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846 --- app/assets/javascripts/discourse/lib/click_track.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/javascripts/discourse/lib/click_track.js b/app/assets/javascripts/discourse/lib/click_track.js index b66b6d65e20..5ae8074320b 100644 --- a/app/assets/javascripts/discourse/lib/click_track.js +++ b/app/assets/javascripts/discourse/lib/click_track.js @@ -14,6 +14,7 @@ Discourse.ClickTrack = { @param {jQuery.Event} e The click event that occurred **/ trackClick: function(e) { + if (Discourse.Utilities.selectedText()!=="") return false; //cancle click if triggered as part of selection. var $link = $(e.currentTarget); if ($link.hasClass('lightbox')) return true;