DEV: Change admin emoji delete button from icon to text (#29931)

The Admin UI guidelines states that buttons should have text, not icons. This was an oversight on the admin emoji listing.

Part of this change is also opportunistically removing the CSS file for admin emojis, none of which is used any more since the conversion.
This commit is contained in:
Ted Johansson 2024-11-26 14:10:14 +08:00 committed by GitHub
parent e708c99e12
commit 15a61a0c1f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 4 additions and 42 deletions

View File

@ -77,8 +77,8 @@ export default class AdminConfigAreasEmojisList extends Component {
<td class="d-admin-row__controls action">
<DButton
@action={{fn this.adminEmojis.destroyEmoji emoji}}
@icon="trash-can"
class="btn-small"
@label="admin.emoji.delete"
class="btn-small d-admin-row__controls-delete"
/>
</td>
</tr>

View File

@ -1102,7 +1102,6 @@ a.inline-editable-field {
@import "common/admin/admin_section_landing_page";
@import "common/admin/admin_page_header";
@import "common/admin/admin_intro";
@import "common/admin/admin_emojis";
@import "common/admin/mini_profiler";
@import "common/admin/schema_theme_setting_editor";
@import "common/admin/customize_themes_show_schema";

View File

@ -1,38 +0,0 @@
.admin-contents.admin-emojis {
.select-kit {
max-width: 210px;
}
#custom_emoji td.action {
text-align: right;
}
#custom_emoji.highlighted {
background: var(--tertiary-very-low);
@media (prefers-reduced-motion: no-preference) {
animation: background-fade-highlight 2.5s ease-out;
}
}
.d-admin-table {
.d-admin-row__content td {
vertical-align: middle;
}
.d-admin-row__overview {
width: 20%;
@include breakpoint("tablet") {
width: auto;
}
}
}
}
.admin-emojis__header {
display: flex;
justify-content: space-between;
align-items: center;
a {
font-size: var(--font-up-1);
margin-bottom: 10px;
}
}

View File

@ -7261,6 +7261,7 @@ en:
description: "Add new emoji that will be available to everyone. Select multiple files to create emojis using their file names. The selected group will be used for all files that are added at the same time."
no_emoji: "You don't have any custom emoji yet."
add: "Add emoji"
delete: "Delete"
back: "Back to emoji"
choose_files: "Choose files"
uploading: "Uploading…"

View File

@ -36,7 +36,7 @@ module PageObjects
end
def delete_button_selector
".d-icon-trash-can"
".d-admin-row__controls-delete"
end
end
end