github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 14:33:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

BUGFIX: invalid referer would cause 500 errors

Browse Source
This commit is contained in:
Sam 2013-12-30 14:05:44 +11:00
parent 9738c4ff48
commit 1915f292ad
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/incoming_link.rb
View File

@ -18,8 +18,12 @@ class IncomingLink < ActiveRecord::Base
end end
if request.referer.present? if request.referer.present?
begin
host = URI.parse(request.referer).host host = URI.parse(request.referer).host
referer = request.referer[0..999] referer = request.referer[0..999]
rescue URI::InvalidURIError
# bad uri, skip
end
end end
if host != request.host && (user_id || referer) if host != request.host && (user_id || referer)

6
spec/models/incoming_link_spec.rb
View File

@ -62,6 +62,12 @@ describe IncomingLink do
IncomingLink.add(req('http://somesite.com', 'http://somesite.com')) IncomingLink.add(req('http://somesite.com', 'http://somesite.com'))
end end
it "tracks visits for invalid referers" do
IncomingLink.add(req('http://somesite.com', 'bang bang bang'))
# no current user, don't track
IncomingLink.count.should == 0
end
it "expects to be called with referer and user id" do it "expects to be called with referer and user id" do
IncomingLink.expects(:create).once.returns(true) IncomingLink.expects(:create).once.returns(true)
IncomingLink.add(req('http://somesite.com', 'http://some.other.site.com'), build(:user)) IncomingLink.add(req('http://somesite.com', 'http://some.other.site.com'), build(:user))