github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 21:09:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Ensure post_hotlinked_media index does not exceed size limit (#16609)

Browse Source 
On some installations, this would fail with 'index row size exceeds btree version 4 maximum'. This commit replaces the (post_id, url)` index with a `(post_id, md5(url))` index, which is much more space efficient.
This commit is contained in:
David Taylor 2022-05-03 15:47:58 +01:00 committed by GitHub
parent 51e29d3ca8
commit 19d2d55011
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/post_hotlinked_media.rb
View File

@ -25,5 +25,5 @@ end
#
# Indexes
#
# index_post_hotlinked_media_on_post_id_and_url (post_id,url) UNIQUE
# index_post_hotlinked_media_on_post_id_and_url_md5 (post_id, md5((url)::text)) UNIQUE
#

8
db/migrate/20220428094026_create_post_hotlinked_media.rb
View File

@ -22,9 +22,15 @@ class CreatePostHotlinkedMedia < ActiveRecord::Migration[6.1]
t.bigint :upload_id
t.timestamps
t.index [:post_id, :url], unique: true
# Failed on some installations due to index size. Repaired in 20220428094027
# t.index [:post_id, :url], unique: true
end
execute <<~SQL
CREATE UNIQUE INDEX index_post_hotlinked_media_on_post_id_and_url_md5
ON post_hotlinked_media (post_id, md5(url));
SQL
reversible do |dir|
dir.up do
execute <<~SQL

22
db/migrate/20220428094027_fix_post_hotlinked_media_index.rb Normal file
View File

@ -0,0 +1,22 @@
# frozen_string_literal: true
class FixPostHotlinkedMediaIndex < ActiveRecord::Migration[6.1]
disable_ddl_transaction!
def up
execute <<~SQL
CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS index_post_hotlinked_media_on_post_id_and_url_md5
ON post_hotlinked_media (post_id, md5(url));
SQL
# Failed index introduced in 20220428094026_create_post_hotlinked_media. On some installations it succeeded,
# so we need to clean it up.
execute <<~SQL
DROP INDEX CONCURRENTLY IF EXISTS index_post_hotlinked_media_on_post_id_and_url;
SQL
end
def down
raise ActiveRecord::IrreversibleMigration
end
end