github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-25 21:23:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Skip pulling hotlinked images for nil user bio (#16901)

Browse Source
This commit is contained in:
David Taylor 2022-05-24 11:52:13 +01:00 committed by GitHub
parent a5779a7d0b
commit 19f583c449
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/jobs/regular/pull_user_profile_hotlinked_images.rb
View File

@ -7,7 +7,7 @@ module Jobs
raise Discourse::InvalidParameters.new(:user_id) if @user_id.blank? raise Discourse::InvalidParameters.new(:user_id) if @user_id.blank?
user_profile = UserProfile.find_by(user_id: @user_id) user_profile = UserProfile.find_by(user_id: @user_id)
return if user_profile.blank? return if user_profile.blank? || user_profile.bio_cooked.nil?
large_image_urls = [] large_image_urls = []
broken_image_urls = [] broken_image_urls = []

5
spec/jobs/pull_user_profile_hotlinked_images_spec.rb
View File

@ -21,5 +21,10 @@ describe Jobs::PullUserProfileHotlinkedImages do
expect { Jobs::PullUserProfileHotlinkedImages.new.execute(user_id: user.id) }.to change { Upload.count }.by(1) expect { Jobs::PullUserProfileHotlinkedImages.new.execute(user_id: user.id) }.to change { Upload.count }.by(1)
expect(user.user_profile.reload.bio_cooked).to include(Upload.last.url) expect(user.user_profile.reload.bio_cooked).to include(Upload.last.url)
end end
it 'handles nil bio' do
expect { Jobs::PullUserProfileHotlinkedImages.new.execute(user_id: user.id) }.to change { Upload.count }.by(0)
expect(user.user_profile.reload.bio_cooked).to eq(nil)
end
end end
end end