github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-24 18:55:59 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Remove enable_quote_copy site setting (#31191)

Browse Source 
This setting was introduced a year ago for
51016e56dd99a9ad4bd82cdc6c0cf968754c70ed, which was
formerly a design experiment.

In practice on our hosting, noone has ever disabled this
setting, and it's for a useful feature. There is no
point keeping it.


![image](https://github.com/user-attachments/assets/97418e7e-2311-4ba0-bf18-41f3f55ab001)
This commit is contained in:
Martin Brennan 2025-02-06 10:31:10 +10:00 committed by GitHub
parent b9d4c57f07
commit 1ab5bc2bad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/components/post-text-selection.gjs
View File

@ -285,10 +285,7 @@ export default class PostTextSelection extends Component {
} }
get canCopyQuote() { get canCopyQuote() {
return ( return this.currentUser?.get("user_option.enable_quoting");
this.siteSettings.enable_quote_copy &&
this.currentUser?.get("user_option.enable_quoting")
);
} }
// on Desktop, shows the bar at the beginning of the selection // on Desktop, shows the bar at the beginning of the selection

2
config/locales/server.en.yml
View File

@ -2592,8 +2592,6 @@ en:
enable_diffhtml_preview: "Experimental feature which uses diffHTML to sync preview instead of full re-render" enable_diffhtml_preview: "Experimental feature which uses diffHTML to sync preview instead of full re-render"
enable_fast_edit: "Adds a button to the post selection menu to edit a small selection inline." enable_fast_edit: "Adds a button to the post selection menu to edit a small selection inline."
enable_quote_copy: "Adds a button to post selection menu to copy the selection to clipboard as a markdown quote."
old_post_notice_days: "The number of days after which a post notice is considered old. This visually differentiates it from newer notices on the site." old_post_notice_days: "The number of days after which a post notice is considered old. This visually differentiates it from newer notices on the site."
new_user_notice_tl: "Minimum trust level required to see new user post notices." new_user_notice_tl: "Minimum trust level required to see new user post notices."
returning_user_notice_tl: "Minimum trust level required to see returning user post notices." returning_user_notice_tl: "Minimum trust level required to see returning user post notices."

3
config/site_settings.yml
View File

@ -1308,9 +1308,6 @@ posting:
enable_fast_edit: enable_fast_edit:
default: true default: true
client: true client: true
enable_quote_copy:
default: true
client: true
old_post_notice_days: old_post_notice_days:
default: 14 default: 14
max: 36500 max: 36500

4
spec/system/post_selection_copy_quote_spec.rb
View File

@ -25,8 +25,8 @@ describe "Post selection | Copy quote", type: :system do
QUOTE QUOTE
end end
it "does not show the copy quote button if it has been disabled" do it "does not show the copy quote button if quoting has been disabled by the user" do
SiteSetting.enable_quote_copy = false current_user.user_option.update!(enable_quoting: false)
topic_page.visit_topic(topic) topic_page.visit_topic(topic)
select_text_range("#{topic_page.post_by_number_selector(1)} .cooked p", 0, 10) select_text_range("#{topic_page.post_by_number_selector(1)} .cooked p", 0, 10)