github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-18 13:02:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Poll tests were overwriting a couple of computed properties

Browse Source
This commit is contained in:
Robin Ward 2020-07-17 15:05:36 -04:00
parent 2a4a2a2ab7
commit 1c33f07e92
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
plugins/poll/test/javascripts/controllers/poll-ui-builder-test.js.es6
View File

@ -14,16 +14,16 @@ test("isMultiple", function(assert) {
controller.setProperties({ controller.setProperties({
pollType: controller.multiplePollType, pollType: controller.multiplePollType,
pollOptionsCount: 1 pollOptions: "a"
}); });
assert.equal(controller.isMultiple, true, "it should be true"); assert.equal(controller.isMultiple, true, "it should be true");
controller.set("pollOptionsCount", 0); controller.set("pollOptions", "");
assert.equal(controller.isMultiple, false, "it should be false"); assert.equal(controller.isMultiple, false, "it should be false");
controller.setProperties({ pollType: "random", pollOptionsCount: 1 }); controller.setProperties({ pollType: "random", pollOptions: "b" });
assert.equal(controller.isMultiple, false, "it should be false"); assert.equal(controller.isMultiple, false, "it should be false");
}); });
@ -70,7 +70,7 @@ test("pollMinOptions", function(assert) {
controller.setProperties({ controller.setProperties({
pollType: controller.multiplePollType, pollType: controller.multiplePollType,
pollOptionsCount: 1 pollOptions: "z"
}); });
assert.deepEqual( assert.deepEqual(
@ -79,7 +79,7 @@ test("pollMinOptions", function(assert) {
"it should return the right options" "it should return the right options"
); );
controller.set("pollOptionsCount", 2); controller.set("pollOptions", "z\nx");
assert.deepEqual( assert.deepEqual(
controller.pollMinOptions, controller.pollMinOptions,
@ -108,7 +108,7 @@ test("pollMaxOptions", function(assert) {
controller.setProperties({ controller.setProperties({
pollType: controller.multiplePollType, pollType: controller.multiplePollType,
pollOptionsCount: 1, pollOptions: "y",
pollMin: 1 pollMin: 1
}); });
@ -118,7 +118,7 @@ test("pollMaxOptions", function(assert) {
"it should return the right options" "it should return the right options"
); );
controller.set("pollOptionsCount", 2); controller.set("pollOptions", "x\ny");
assert.deepEqual( assert.deepEqual(
controller.pollMaxOptions, controller.pollMaxOptions,
@ -170,7 +170,7 @@ test("disableInsert", function(assert) {
assert.equal(controller.disableInsert, true, "it should be true"); assert.equal(controller.disableInsert, true, "it should be true");
controller.set("pollOptionsCount", 2); controller.set("pollOptions", "a\nb");
assert.equal(controller.disableInsert, false, "it should be false"); assert.equal(controller.disableInsert, false, "it should be false");
@ -180,21 +180,21 @@ test("disableInsert", function(assert) {
controller.setProperties({ controller.setProperties({
pollType: controller.regularPollType, pollType: controller.regularPollType,
pollOptionsCount: 3 pollOptions: "a\nb\nc"
}); });
assert.equal(controller.disableInsert, false, "it should be false"); assert.equal(controller.disableInsert, false, "it should be false");
controller.setProperties({ controller.setProperties({
pollType: controller.regularPollType, pollType: controller.regularPollType,
pollOptionsCount: 0 pollOptions: ""
}); });
assert.equal(controller.disableInsert, true, "it should be true"); assert.equal(controller.disableInsert, true, "it should be true");
controller.setProperties({ controller.setProperties({
pollType: controller.regularPollType, pollType: controller.regularPollType,
pollOptionsCount: 1 pollOptions: "w"
}); });
assert.equal(controller.disableInsert, false, "it should be false"); assert.equal(controller.disableInsert, false, "it should be false");
@ -278,7 +278,6 @@ test("multiple pollOutput", function(assert) {
controller.siteSettings.poll_maximum_options = 20; controller.siteSettings.poll_maximum_options = 20;
controller.setProperties({ controller.setProperties({
isMultiple: true,
pollType: controller.multiplePollType, pollType: controller.multiplePollType,
pollMin: 1, pollMin: 1,
pollOptions: "\n\n1\n\n2" pollOptions: "\n\n1\n\n2"