github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 01:47:22 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: anonymous FAQ link to external URL (#20568)

Browse Source 
When FAQ url is set to external resource, site is failing for anonymous user.
This commit is contained in:
Krzysztof Kotlarek 2023-03-08 11:21:02 +11:00 committed by GitHub
parent 5e0c95ed83
commit 1c881c1037
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/sidebar/section-link.js
View File

@ -39,7 +39,7 @@ export default class SectionLink extends Component {
}
get target() {
return this.currentUser.user_option.external_links_in_new_tab
return this.currentUser?.user_option?.external_links_in_new_tab
? "_blank"
: "_self";
}

1
app/assets/javascripts/discourse/tests/acceptance/sidebar-anonymous-community-section-test.js
View File

@ -13,6 +13,7 @@ import { click, visit } from "@ember/test-helpers";
acceptance("Sidebar - Anonymous user - Community Section", function (needs) {
needs.settings({
navigation_menu: "sidebar",
faq_url: "https://discourse.org",
});
test("display short site description site setting when it is set", async function (assert) {