From 1dde6a535565d029aa897e75197f75f9ae0f000b Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX <j.jaffeux@gmail.com> Date: Thu, 25 Jul 2019 11:54:23 +0200 Subject: [PATCH] DEV: prevents post.siteSettings computed property to be overridden (#7941) This happens when loading a post from a json object and is a behavior which will be impossble in future Ember updates. --- .../javascripts/discourse/models/post.js.es6 | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/discourse/models/post.js.es6 b/app/assets/javascripts/discourse/models/post.js.es6 index 2e3681c5c62..9a9fbe8e635 100644 --- a/app/assets/javascripts/discourse/models/post.js.es6 +++ b/app/assets/javascripts/discourse/models/post.js.es6 @@ -11,11 +11,17 @@ import { userPath } from "discourse/lib/url"; import Composer from "discourse/models/composer"; const Post = RestModel.extend({ - @computed() - siteSettings() { - // TODO: Remove this once one instantiate all `Discourse.Post` models via the store. - return Discourse.SiteSettings; - }, + // TODO: Remove this once one instantiate all `Discourse.Post` models via the store. + siteSettings: Ember.computed({ + get() { + return Discourse.SiteSettings; + }, + + // prevents model created from json to overridde this property + set() { + return Discourse.SiteSettings; + } + }), @computed("url") shareUrl(url) {