github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 20:43:39 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

FIX: Show Uncategorized in category-chooser (#25794)

Browse Source 
The uncategorized category was not rendered correctly and it was also
sometimes displayed twice. This commit is a similar bug fix to commit
76647d3a34 and is a follow up to commit
63a50b12fd.
This commit is contained in:
Bianca Nenciu 2024-02-22 19:30:55 +02:00 committed by GitHub
parent f4848ae989
commit 1df473b530
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/select-kit/addon/components/category-chooser.js
View File

@ -17,7 +17,8 @@ export default ComboBoxComponent.extend({
selectKitOptions: {
filterable: true,
allowUncategorized: false,
autoInsertNoneItem: false,
allowUncategorized: "allowUncategorizedTopics",
allowSubCategories: true,
permissionType: PermissionType.FULL,
excludeCategoryId: null,
@ -54,10 +55,7 @@ export default ComboBoxComponent.extend({
I18n.t(isString ? this.selectKit.options.none : "category.none")
)
);
} else if (
this.allowUncategorizedTopics ||
this.selectKit.options.allowUncategorized
) {
} else if (this.selectKit.options.allowUncategorized) {
return Category.findUncategorized();
} else {
const defaultCategoryId = parseInt(
@ -94,6 +92,7 @@ export default ComboBoxComponent.extend({
search(filter) {
if (this.site.lazy_load_categories) {
return Category.asyncSearch(this._normalize(filter), {
includeUncategorized: this.allowUncategorizedTopics,
scopedCategoryId: this.selectKit.options?.scopedCategoryId,
prioritizedCategoryId: this.selectKit.options?.prioritizedCategoryId,
});

3
app/assets/javascripts/select-kit/addon/components/category-drop.js
View File

@ -24,6 +24,7 @@ export default ComboBoxComponent.extend({
navigateToEdit: false,
editingCategory: false,
editingCategoryTab: null,
allowUncategorizedTopics: setting("allow_uncategorized_topics"),
selectKitOptions: {
filterable: true,
@ -40,7 +41,7 @@ export default ComboBoxComponent.extend({
displayCategoryDescription: "displayCategoryDescription",
headerComponent: "category-drop/category-drop-header",
parentCategory: false,
allowUncategorized: setting("allow_uncategorized_topics"),
allowUncategorized: "allowUncategorizedTopics",
},
modifyComponentForRow() {