From 20f84a364bbcd835487cf1ed241f434674f3954d Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 7 May 2019 09:48:14 +1000 Subject: [PATCH] Correct regression, correctly raise exception when setting incorrect param --- lib/site_setting_extension.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/site_setting_extension.rb b/lib/site_setting_extension.rb index 6822dcb611a..83172f10325 100644 --- a/lib/site_setting_extension.rb +++ b/lib/site_setting_extension.rb @@ -406,6 +406,8 @@ module SiteSettingExtension set(name, value) value = prev_value = "[FILTERED]" if secret_settings.include?(name.to_sym) StaffActionLogger.new(user).log_site_setting_change(name, prev_value, value) + else + raise Discourse::InvalidParameters end end