From 213117b84c373a74b4c71710583ae07e5f751e68 Mon Sep 17 00:00:00 2001 From: Sam Saffron <sam.saffron@gmail.com> Date: Wed, 4 Sep 2019 18:20:55 +1000 Subject: [PATCH] PERF: use CDN url for proxy of favicon This avoids hitting S3 direct which is usually not desirable. --- app/controllers/static_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/static_controller.rb b/app/controllers/static_controller.rb index d8844047b8b..b546c2bc867 100644 --- a/app/controllers/static_controller.rb +++ b/app/controllers/static_controller.rb @@ -135,7 +135,7 @@ class StaticController < ApplicationController if Discourse.store.external? begin file = FileHelper.download( - UrlHelper.absolute(favicon.url), + Discourse.store.cdn_url(favicon.url), max_file_size: favicon.filesize, tmp_file_name: FAVICON, follow_redirect: true