github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-27 08:23:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Skip a flaky FF test (#18996)

Browse Source 
On Firefox Evergreen this upload test often fails, because the order of uploads in markdown is somehow reversed.
This commit is contained in:
Jarek Radosz 2022-11-14 12:16:00 +01:00 committed by GitHub
parent 3d5753c42b
commit 2325bec3c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js
View File

@ -1,5 +1,6 @@
import { import {
acceptance, acceptance,
chromeTest,
createFile, createFile,
loggedInUser, loggedInUser,
paste, paste,
@ -114,34 +115,39 @@ acceptance("Uppy Composer Attachment - Upload Placeholder", function (needs) {
appEvents.trigger("composer:add-files", image); appEvents.trigger("composer:add-files", image);
}); });
test("should handle adding one file for upload then adding another when the first is still in progress", async function (assert) { // TODO: On Firefox Evergreen this often fails, because the order of uploads
await visit("/"); // in markdown is reversed
await click("#create-topic"); chromeTest(
await fillIn(".d-editor-input", "The image:\n"); "handles adding one file for upload then adding another when the first is still in progress",
const appEvents = loggedInUser().appEvents; async function (assert) {
const done = assert.async(); await visit("/");
await click("#create-topic");
await fillIn(".d-editor-input", "The image:\n");
const appEvents = loggedInUser().appEvents;
const done = assert.async();
appEvents.on("composer:all-uploads-complete", async () => { appEvents.on("composer:all-uploads-complete", async () => {
await settled(); await settled();
assert.strictEqual( assert.strictEqual(
query(".d-editor-input").value, query(".d-editor-input").value,
"The image:\n![avatar.PNG|690x320](upload://yoj8pf9DdIeHRRULyw7i57GAYdz.jpeg)\n![avatar2.PNG|690x320](upload://sdfljsdfgjlkwg4328.jpeg)\n" "The image:\n![avatar.PNG|690x320](upload://yoj8pf9DdIeHRRULyw7i57GAYdz.jpeg)\n![avatar2.PNG|690x320](upload://sdfljsdfgjlkwg4328.jpeg)\n"
); );
done(); done();
}); });
let image2Added = false; let image2Added = false;
appEvents.on("composer:upload-started", () => { appEvents.on("composer:upload-started", () => {
if (!image2Added) { if (!image2Added) {
appEvents.trigger("composer:add-files", image2); appEvents.trigger("composer:add-files", image2);
image2Added = true; image2Added = true;
} }
}); });
const image1 = createFile("avatar.png"); const image1 = createFile("avatar.png");
const image2 = createFile("avatar2.png"); const image2 = createFile("avatar2.png");
appEvents.trigger("composer:add-files", image1); appEvents.trigger("composer:add-files", image1);
}); }
);
test("should handle placeholders correctly even if the OS rewrites ellipses", async function (assert) { test("should handle placeholders correctly even if the OS rewrites ellipses", async function (assert) {
const execCommand = document.execCommand; const execCommand = document.execCommand;