github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-22 00:03:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Raise error instead of warning in testing (#22440)

Browse Source 
Some plugins call require_plugin with a wrong argument instead of the
plugin name. In a production environment that used to be a warning, but
there is no reason to keep it like that in a testing environment
because the issue will continue to be ignored.
This commit is contained in:
Bianca Nenciu 2023-07-07 13:58:42 +03:00 committed by GitHub
parent 2dfeb5f0c2
commit 25a0c00e72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/application_controller.rb
View File

@ -348,6 +348,8 @@ class ApplicationController < ActionController::Base
before_action do before_action do
if plugin = Discourse.plugins_by_name[plugin_name] if plugin = Discourse.plugins_by_name[plugin_name]
raise PluginDisabled.new if !plugin.enabled? raise PluginDisabled.new if !plugin.enabled?
elsif Rails.env.test?
raise "Required plugin '#{plugin_name}' not found. The string passed to requires_plugin should match the plugin's name at the top of plugin.rb"
else else
Rails.logger.warn("Required plugin '#{plugin_name}' not found") Rails.logger.warn("Required plugin '#{plugin_name}' not found")
end end