github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 17:53:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: 'most_liked_by_users' wasn't sorting users properly

Browse Source
This commit is contained in:
Régis Hanol 2016-04-18 18:03:33 +02:00
parent c0138c0277
commit 270ab5b71d
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/models/user_summary.rb
View File

@ -50,8 +50,7 @@ class UserSummary
end
def most_liked_by_users
likers_ids = []
counts = []
likers = {}
UserAction.joins("JOIN posts ON posts.id = user_actions.target_post_id")
.joins("JOIN topics ON topics.id = posts.topic_id")
.where("posts.deleted_at IS NULL")
@ -63,22 +62,19 @@ class UserSummary
.order("COUNT(*) DESC")
.limit(MAX_SUMMARY_RESULTS)
.pluck("acting_user_id, COUNT(*)")
.each do |i|
likers_ids << i[0]
counts << i[1]
end
.each { |l| likers[l[0].to_s] = l[1] }
User.where(id: likers_ids)
User.where(id: likers.keys)
.pluck(:id, :username, :name, :uploaded_avatar_id)
.map.with_index do |u, i|
.map do |u|
LikedByUser.new(
id: u[0],
username: u[1],
name: u[2],
avatar_template: User.avatar_template(u[1], u[3]),
likes: counts[i]
likes: likers[u[0].to_s]
)
end
end.sort_by { |u| -u[:likes] }
end
def badges