Otherwise please Reset Password.
not_found_template_link: |This invitation to %{site_name} can no longer be redeemed. Please ask the person who invited you to send you a new invitation.
+ existing_user_cannot_redeem: "This invitation cannot be redeemed. Please ask the person who invited you to send you a new invitation." + existing_user_already_redemeed: "You have already redeemed this invite link." user_exists: "There's no need to invite %{email}, they already have an account!" invite_exists: "You already invited %{email}." invalid_email: "%{email} isn't a valid email address." diff --git a/spec/models/invite_spec.rb b/spec/models/invite_spec.rb index 56d09fe7413..99b9767ba54 100644 --- a/spec/models/invite_spec.rb +++ b/spec/models/invite_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' describe Invite do - fab!(:user) { Fabricate(:user) } + fab!(:user) { Fabricate(:user, email: "existinguser@invitetest.com") } let(:xss_email) { "email@test.com" } let(:escaped_email) { "<b onmouseover=alert('wufff!')>email</b><script>alert('test');</script>@test.com" } @@ -481,4 +481,91 @@ describe Invite do expect(invite.warnings(admin.guardian)).to contain_exactly(I18n.t("invite.requires_groups", groups: group.name)) end end + + describe "#can_be_redeemed_by?" do + context "for invite links" do + fab!(:invite) { Fabricate(:invite, email: nil, domain: nil, max_redemptions_allowed: 1) } + + it "returns false if invite is already redeemed" do + invite.update!(redemption_count: 1) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if the invite is expired" do + invite.update!(expires_at: 10.days.ago) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if invite is deleted" do + invite.trash! + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if invite is invalidated" do + invite.update!(invalidated_at: 1.day.ago) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if the user already redeemed it" do + InvitedUser.create(user: user, invite: invite) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if domain does not match user email" do + invite.update!(domain: "zzzzz.com") + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns true if domain does match user email" do + invite.update!(domain: "invitetest.com") + expect(invite.can_be_redeemed_by?(user)).to eq(true) + end + + it "returns true by default if all other conditions are met and domain and invite are blank" do + expect(invite.can_be_redeemed_by?(user)).to eq(true) + end + end + + context "for email invites" do + fab!(:invite) do + invite = Fabricate(:invite, email: "otherexisting@invitetest.com", domain: nil) + user.update!(email: "otherexisting@invitetest.com") + invite + end + + it "returns false if invite is already redeemed" do + InvitedUser.create(user: Fabricate(:user), invite: invite) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if the invite is expired" do + invite.update!(expires_at: 10.days.ago) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if invite is deleted" do + invite.trash! + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if invite is invalidated" do + invite.update!(invalidated_at: 1.day.ago) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if the user already redeemed it" do + InvitedUser.create(user: user, invite: invite) + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns false if email does not match user email" do + invite.update!(email: "blahblah@test.com") + expect(invite.can_be_redeemed_by?(user)).to eq(false) + end + + it "returns true if email does match user email" do + expect(invite.can_be_redeemed_by?(user)).to eq(true) + end + end + end end diff --git a/spec/requests/invites_controller_spec.rb b/spec/requests/invites_controller_spec.rb index d2564f68b2f..c3eaea4b9f7 100644 --- a/spec/requests/invites_controller_spec.rb +++ b/spec/requests/invites_controller_spec.rb @@ -117,6 +117,7 @@ describe InvitesController do json = JSON.parse(element.current_scope.attribute('data-preloaded').value) invite_info = JSON.parse(json['invite_info']) expect(invite_info['existing_user_can_redeem']).to eq(false) + expect(invite_info['existing_user_can_redeem_error']).to eq(I18n.t("invite.existing_user_cannot_redeem")) end end @@ -130,6 +131,37 @@ describe InvitesController do json = JSON.parse(element.current_scope.attribute('data-preloaded').value) invite_info = JSON.parse(json['invite_info']) expect(invite_info['existing_user_can_redeem']).to eq(false) + expect(invite_info['existing_user_can_redeem_error']).to eq(I18n.t("invite.existing_user_cannot_redeem")) + end + end + + it "does not allow the user to accept the invite when a multi-use invite link has already been redeemed by the user" do + invite.update!(email: nil, max_redemptions_allowed: 10) + expect(invite.redeem(redeeming_user: user)).not_to eq(nil) + + get "/invites/#{invite.invite_key}" + expect(response.status).to eq(200) + + expect(response.body).to have_tag('div#data-preloaded') do |element| + json = JSON.parse(element.current_scope.attribute('data-preloaded').value) + invite_info = JSON.parse(json['invite_info']) + expect(invite_info['existing_user_id']).to eq(user.id) + expect(invite_info['existing_user_can_redeem']).to eq(false) + expect(invite_info['existing_user_can_redeem_error']).to eq(I18n.t("invite.existing_user_already_redemeed")) + end + end + + it "allows the user to accept the invite when its an invite link that they have not redeemed" do + invite.update!(email: nil, max_redemptions_allowed: 10) + + get "/invites/#{invite.invite_key}" + expect(response.status).to eq(200) + + expect(response.body).to have_tag('div#data-preloaded') do |element| + json = JSON.parse(element.current_scope.attribute('data-preloaded').value) + invite_info = JSON.parse(json['invite_info']) + expect(invite_info['existing_user_id']).to eq(user.id) + expect(invite_info['existing_user_can_redeem']).to eq(true) end end end