github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 06:29:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: avoid flashing error when loading form template (#28700)

Browse Source
This commit is contained in:
Renato Atilio 2024-09-03 17:41:20 -03:00 committed by GitHub
parent 460b875d03
commit 289249303c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/app/components/d-editor.js
View File

@ -276,11 +276,7 @@ export default class DEditor extends Component.extend(
@discourseComputed("formTemplateIds", "replyingToTopic", "editingPost")
showFormTemplateForm(formTemplateIds, replyingToTopic, editingPost) {
// TODO(@keegan): Remove !editingPost once we add edit/draft support for form templates
if (formTemplateIds?.length > 0 && !replyingToTopic && !editingPost) {
return true;
}
return false;
return formTemplateIds?.length > 0 && !replyingToTopic && !editingPost;
}
@discourseComputed("placeholder")

2
app/assets/javascripts/discourse/app/components/form-template-field/wrapper.gjs
View File

@ -87,7 +87,7 @@ export default class FormTemplateFieldWrapper extends Component {
/>
{{/each}}
</div>
{{else}}
{{else if this.error}}
<div class="alert alert-error">
{{this.error}}
</div>