github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 06:03:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: disables the modal on mobile bookmark-menu (#26958)

Browse Source 
It's a temporary solution while I work a better solution. The problem here is quite tricky. We are showing a modal from a modal. But if we close the previous modal, before the second one is show it means we destroy the menu holding the first modal which prevents showing the second modal.

One possible solution would be to refactor d-modal’s show function. At the moment if you await on show it will await until closed and not when the modal has been inserted to the DOM. It means we don't have a clean moment to close the d-menu.

The second issue it that even though it's possible to have multiple modals on screen, the close modal assumes only one active modal at a time.
This commit is contained in:
Joffrey JAFFEUX 2024-05-09 22:17:31 +02:00 committed by GitHub
parent 9e696a0305
commit 2a2eaf835f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/components/bookmark-menu.gjs
View File

@ -246,7 +246,6 @@ export default class BookmarkMenu extends Component {
@onClose={{this.onCloseMenu}}
@onShow={{this.onShowMenu}}
@onRegisterApi={{this.onRegisterApi}}
@modalForMobile={{true}}
@arrow={{false}}
>
<:content>