gist oneboxer issues

This commit is contained in:
Sam Saffron 2013-02-12 13:45:08 +11:00
parent 2609350457
commit 2b276bc2c8
2 changed files with 17 additions and 7 deletions

View File

@ -7,22 +7,16 @@ module Oneboxer
favicon 'github.png'
def translate_url
m = @url.match(/gist\.github\.com\/(?<id>[0-9a-f]+)/mi)
m = @url.match(/gist\.github\.com\/([^\/]+\/)?(?<id>[0-9a-f]+)/mi)
return "https://api.github.com/gists/#{m[:id]}" if m
@url
end
def parse(data)
parsed = JSON.parse(data)
result = {files: [], title: parsed['description']}
parsed['files'].each do |filename, attrs|
result[:files] << {filename: filename}.merge!(attrs)
end
result
end

View File

@ -0,0 +1,16 @@
require 'spec_helper'
require 'oneboxer'
require 'oneboxer/gist_onebox'
describe Oneboxer::GistOnebox do
it "does not trip on user names" do
o = Oneboxer::GistOnebox.new('https://gist.github.com/aaa/4599619')
o.translate_url.should == 'https://api.github.com/gists/4599619'
end
it "works for old school urls too" do
o = Oneboxer::GistOnebox.new('https://gist.github.com/4599619')
o.translate_url.should == 'https://api.github.com/gists/4599619'
end
end