mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 13:03:45 +08:00
gist oneboxer issues
This commit is contained in:
parent
2609350457
commit
2b276bc2c8
|
@ -7,22 +7,16 @@ module Oneboxer
|
|||
favicon 'github.png'
|
||||
|
||||
def translate_url
|
||||
m = @url.match(/gist\.github\.com\/(?<id>[0-9a-f]+)/mi)
|
||||
m = @url.match(/gist\.github\.com\/([^\/]+\/)?(?<id>[0-9a-f]+)/mi)
|
||||
return "https://api.github.com/gists/#{m[:id]}" if m
|
||||
@url
|
||||
end
|
||||
|
||||
def parse(data)
|
||||
|
||||
parsed = JSON.parse(data)
|
||||
|
||||
result = {files: [], title: parsed['description']}
|
||||
|
||||
parsed['files'].each do |filename, attrs|
|
||||
result[:files] << {filename: filename}.merge!(attrs)
|
||||
end
|
||||
|
||||
|
||||
result
|
||||
end
|
||||
|
||||
|
|
16
spec/components/oneboxer/gist_onebox_spec.rb
Normal file
16
spec/components/oneboxer/gist_onebox_spec.rb
Normal file
|
@ -0,0 +1,16 @@
|
|||
require 'spec_helper'
|
||||
require 'oneboxer'
|
||||
require 'oneboxer/gist_onebox'
|
||||
|
||||
describe Oneboxer::GistOnebox do
|
||||
it "does not trip on user names" do
|
||||
o = Oneboxer::GistOnebox.new('https://gist.github.com/aaa/4599619')
|
||||
o.translate_url.should == 'https://api.github.com/gists/4599619'
|
||||
end
|
||||
|
||||
it "works for old school urls too" do
|
||||
o = Oneboxer::GistOnebox.new('https://gist.github.com/4599619')
|
||||
o.translate_url.should == 'https://api.github.com/gists/4599619'
|
||||
end
|
||||
end
|
||||
|
Loading…
Reference in New Issue
Block a user