UX: Perform icon replacements before calling icon renderer

This commit is contained in:
Robin Ward 2017-10-03 15:38:45 -04:00
parent 1faae3c765
commit 2ce6e0bb07

View File

@ -40,7 +40,7 @@ export function renderIcon(renderType, id, params) {
let rendererForType = renderer[renderType];
if (rendererForType) {
let result = rendererForType(id, params || {});
let result = rendererForType(REPLACEMENTS[id] || id, params || {});
if (result) {
return result;
}
@ -80,8 +80,6 @@ registerIconRenderer({
name: 'font-awesome',
string(id, params) {
id = REPLACEMENTS[id] || id;
let tagName = params.tagName || 'i';
let html = `<${tagName} class='${faClasses(id, params)}'`;
if (params.title) { html += ` title='${I18n.t(params.title)}'`; }
@ -94,8 +92,6 @@ registerIconRenderer({
},
node(id, params) {
id = REPLACEMENTS[id] || id;
let tagName = params.tagName || 'i';
const properties = {