github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 03:16:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Pull title logic into its own method

Browse Source
This commit is contained in:
Daniel Waterworth 2019-06-07 09:40:42 +01:00 committed by Robin Ward
parent d83147d137
commit 305562bf66
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/javascripts/discourse/widgets/default-notification-item.js.es6
View File

@ -124,6 +124,18 @@ export const DefaultNotificationItem =
return iconNode(`notification.${infoKey}`);
},
title(notificationName, data) {
if (notificationName) {
if (notificationName === "custom") {
return data.title ? I18n.t(data.title) : "";
} else {
return I18n.t(`notifications.titles.${notificationName}`);
}
} else {
return "";
}
},
html(attrs) {
const notificationType = attrs.notification_type;
const lookup = this.site.get("notificationLookup");
@ -133,17 +145,7 @@ export const DefaultNotificationItem =
let text = emojiUnescape(this.text(notificationType, notificationName));
let icon = this.icon(notificationName, data);
let title;
if (notificationName) {
if (notificationName === "custom") {
title = data.title ? I18n.t(data.title) : "";
} else {
title = I18n.t(`notifications.titles.${notificationName}`);
}
} else {
title = "";
}
const title = this.title(notificationName, data);
// We can use a `<p>` tag here once other languages have fixed their HTML
// translations.